Commit Graph

443 Commits

Author SHA1 Message Date
eric_tian f944ec32e7 follow up code review
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5894 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 06:13:42 +00:00
eric_tian f73e0ad215 follow up code review
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5893 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 06:01:21 +00:00
eric_tian 55f298c3a3 follow up the comments from code review.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5892 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-16 05:22:09 +00:00
qhuang8 3fef0f51d8 1. Add new macro: ALIGN_VALUE to round up a value to the next boundary of a given alignment.
2. Update ALIGN_POINTER to use the new macro
3. Drop the second parameter of ALIGN_VARIABLE for simplicity. It can also directly use the new macro ALIGN_VALUE. 

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5869 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-10 16:00:20 +00:00
eric_tian c57da111f7 cleanup some comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5864 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 07:11:51 +00:00
eric_tian e3a7917f2e fix build issue
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5863 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 06:45:35 +00:00
eric_tian 1106ffe1c0 Function description in baselib.h is not clear. change it to comply with Doxgen format.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5862 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 06:22:30 +00:00
vanjeff e31c47b99a fixed typo.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5855 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-09 03:19:37 +00:00
qhuang8 f83933cff0 Fix typo
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5850 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 23:27:26 +00:00
qwang12 3a26bb17af 1) Add CONST to the pointer type input parameter.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5848 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 12:54:26 +00:00
xli24 4b503a775e Minor update for PI include files according to code review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5839 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 07:55:40 +00:00
qwang12 681b5c23c4 Remove NULL_HANDLE. NULL_HANDLE should be replaced with NULL as consistency. For now, only DXE core is using this macro.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5835 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 05:00:44 +00:00
lgao4 11ceade4ba Add Usb Hid class request type into IndustryStandard/Usb.h, and replace the hard value in UefiUsbLib by them.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5834 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 04:59:00 +00:00
lgao4 cc4e048504 Correct the wrong '?' character to '-', and add check DestinationBuffer == SourceBuffer for CompareMem functions in all BaseMemory library instances.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5831 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-08 01:24:16 +00:00
xli24 f1b420aa4e Make prototype of EFI_PEI_STALL comply with PI spec.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5828 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-05 05:10:54 +00:00
vanjeff ed66e1bc0d clean up the un-suitable ';' location when declaring the functions.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5820 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 09:37:28 +00:00
xli24 dafa11b191 Update MdePkg/Include/Ppi according to code review comments.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5818 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 09:15:21 +00:00
vanjeff 9eb7382f73 1. remove EFI_EVENT_ alias, replace them with EVT_
2. remove definitions of EFI_DESCRIPTION_STRING and EFI_DESCRIPTION_STRING_BUNDLE.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5812 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 07:38:10 +00:00
vanjeff 81c749f767 Changed x64 into X64.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5811 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 06:20:32 +00:00
vanjeff 7b1bf9f61b added additional comments and fixed some typo.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5810 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 06:16:14 +00:00
vanjeff 11227adb14 1. Remove unnecessary CONST.
2. Remove Unnecessarily including <ProcessorBind.h>.
3. Add comments for struct definition.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5806 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-04 03:15:52 +00:00
jljusten 1fb24cc445 edk2/MdePkg/Include/x64/ProcessorBind.h:
edk2/MdePkg/Include/Ipf/ProcessorBind.h:
* Merge ICC warning ignores from Ia32/ProcessorBind.h.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5805 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 23:20:24 +00:00
jljusten 427c6c737e edk2/MdePkg/Include/Ia32/ProcessorBind.h:
* Disable ICC warning for: "LocalVariable" was set but never used


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5804 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 21:07:42 +00:00
vanjeff 4ba967e79a 1.Updated EFI_FVB_ATTRIBUTES to EFI_FVB_ATTRIBUTES_2 to follow PI spec.
2.Changed parameter FvHeader into DriverName to follow PI spec.
3.Updated DXE services functions header to follow PI spec.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5796 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 08:34:34 +00:00
klu2 e6dedf514f Remove MigrateIDT interface from PeiServiceTableLib library class.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5791 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-03 07:56:04 +00:00
xli24 201c76681b Fix 2 flaws in MdePkg/Include/Library/UefiRuntimeLib.h:
1. Add OPTIONAL modifier for parameter Attributes of EfiGetVariable()
2. Add EFIAPI modifier for EfiResetSystem()


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5775 6f19259b-4bc3-4df7-8a09-765794883524
2008-09-02 05:54:48 +00:00
jljusten ed300ce2a6 edk2/MdePkg/Include/Ia32/ProcessorBind.h:
* Add mask for ICC warning when a parameter is not referenced in a
  function.


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5757 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-29 23:04:44 +00:00
qwang12 0276b838a1 Fix a bug in the assert condition.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5753 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-29 05:34:35 +00:00
qwang12 ff197efbbc 1) Update comments for API in DxePiLib.h
2) Fix a bug that SectionInstance is not referenced in the function GetSectionFromFv
3) Some minor cleanup.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5711 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-22 09:09:24 +00:00
vanjeff bb8fb476e1 remove unnecessary IN OUT.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5703 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-21 03:08:04 +00:00
qhuang8 dd1245006f Remove allocate aligned pool services.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5696 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-20 09:39:43 +00:00
lgao4 a8ff971524 Cleanup Cpu library class and CpuLib instance and BaseLib instance; and add comments for the confused logic in IfrSupportLib instance.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5694 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-20 09:15:34 +00:00
qwang12 55a9663bde Add IfrLibCreatePopUp2 and HiiLibExportPackageLists.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5663 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-18 07:47:51 +00:00
klu2 c36659905b Add PCD_MAX_SKU_ID.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5655 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-18 05:36:10 +00:00
klu2 fb5148a0d8 git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5650 6f19259b-4bc3-4df7-8a09-765794883524 2008-08-14 04:30:49 +00:00
klu2 99e8ed219f Use doxygen comment style for document entity such as struct, enum, variable that use /// but not //
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5649 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-14 04:29:48 +00:00
klu2 0688984231 Use doxygen comment style for document entity such as struct, enum, variable that use /// but not //
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5648 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-14 04:11:35 +00:00
klu2 fc30687f39 Use doxygen comment style for document entity such as struct, enum, variable that use /// but not //
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5647 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-14 03:30:12 +00:00
klu2 ec8432e515 Use doxygen comment style for document entity such as struct, enum, variable that use /// but not //
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5646 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-14 03:22:55 +00:00
klu2 1bc5d0217a Use doxygen comment style for document entity such as struct, enum, variable that use /// but not //
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5645 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-14 03:21:03 +00:00
klu2 3566565aa4 Use doxygen comment style for document entity such as struct, enum, variable that use /// but not //
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5644 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-14 02:56:09 +00:00
klu2 55d473ba15 Use doxygen comment style for document entity such as struct, enum, variable that use /// but not //
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5643 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-14 02:54:46 +00:00
klu2 d484d12067 Use doxygen comment style for document entity such as struct, enum, variable that use /// but not //
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5642 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-14 02:53:43 +00:00
eric_tian 584125bcba code review's result.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5633 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-12 07:20:10 +00:00
lgao4 a2ddd00bfe Add SerialPortPoll Api in SerialPortLib to Poll the serial device to see if there is any data waiting.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5624 6f19259b-4bc3-4df7-8a09-765794883524
2008-08-10 05:39:21 +00:00
klu2 9810cdd88c Remove blank for function typedef, it will break generating doxygen document.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5596 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-31 08:53:34 +00:00
klu2 78bf8f2dbf remove blank for function typedef, it will break generating doxygen document.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5593 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-31 08:22:39 +00:00
yshang1 dca1cc5989 Code Scrub for MdePkg.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5584 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-29 03:29:01 +00:00
jljusten c28a55549a edk2/MdePkg/Include/Protocol/TcgService.h:
* Fix error from GCC:
   > redefinition of typedef 'EFI_TCG_PROTOCOL'


git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5583 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-28 18:42:42 +00:00
xli24 e7b1b5963c Refine function header comments of PalCallLib.h.
git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@5574 6f19259b-4bc3-4df7-8a09-765794883524
2008-07-27 11:46:08 +00:00