mirror of https://github.com/acidanthera/audk.git
3f55418d53
When DHCP is misconfigured on a network segment, such that two DHCP servers attempt to reply to requests (and therefore race with each other), the edk2 PXE client can confuse itself. In PxeBcDhcp4BootInfo() / PxeBcDhcp6BootInfo(), the client may refer to a DHCP reply packet as an "earlier" packet from the "same" DHCP server, when in reality both packets are unrelated, and arrive from different DHCP servers. While the edk2 PXE client can do nothing to fix this, it should at least not ASSERT() -- ASSERT() is for catching programming errors (violations of invariants that are under the control of the programmer). ASSERT()s should in particular not refer to external data (such as network packets). What's more, in RELEASE builds, we get NULL pointer references. Check the problem conditions with actual "if"s, and return EFI_PROTOCOL_ERROR. This will trickle out to PxeBcLoadBootFile(), and be reported as "PXE-E99: Unexpected network error". Cc: Jiaxin Wu <jiaxin.wu@intel.com> Cc: Maciej Rabeda <maciej.rabeda@linux.intel.com> Cc: Philippe Mathieu-Daudé <philmd@redhat.com> Cc: Siyuan Fu <siyuan.fu@intel.com> Signed-off-by: Laszlo Ersek <lersek@redhat.com> Message-Id: <20200331004749.16128-1-lersek@redhat.com> Reviewed-by: Siyuan Fu <siyuan.fu@intel.com> Reviewed-by: Maciej Rabeda <maciej.rabeda@linux.intel.com> |
||
|---|---|---|
| .. | ||
| ComponentName.c | ||
| PxeBcBoot.c | ||
| PxeBcBoot.h | ||
| PxeBcDhcp4.c | ||
| PxeBcDhcp4.h | ||
| PxeBcDhcp6.c | ||
| PxeBcDhcp6.h | ||
| PxeBcDriver.c | ||
| PxeBcDriver.h | ||
| PxeBcImpl.c | ||
| PxeBcImpl.h | ||
| PxeBcMtftp.c | ||
| PxeBcMtftp.h | ||
| PxeBcSupport.c | ||
| PxeBcSupport.h | ||
| UefiPxeBcDxe.inf | ||
| UefiPxeBcDxe.uni | ||
| UefiPxeBcDxeExtra.uni | ||