mirror of https://github.com/acidanthera/audk.git
bd0656b5e2
IpSb->Reconfig should not be set to TRUE to focal the reconfiguration during the policy changes from Static to DHCP. It's redundancy because the default router table and default addresses have been freed ahead ( Detailed see Ip4Config2OnPolicyChanged() function). Otherwise, the potential failure will appear if UseDefaultAddress configured. Reproduce steps see below: #1. Set policy to DHCP. #2. If DHCP process is not complete yet, then run one APP to invoke UDP4 Configure with "UseDefaultAddress = TRUE" (loop to call UDP4 Configure until Ip4Mode.IsConfigured changes to TRUE). #3. Even DHCP succeed but Ip4Mode.IsConfigured flag never set to TRUE Concrete analysis is as follows: In #1, the policy will be set to DHCP, and then Ip4Config2OnPolicyChanged() will be called. In this function, if "IpSb->Reconfig" flag is set to TRUE, the original "IpSb->DefaultInterface" will be abandoned/freed once the DHCP process finished. In #2, UDP4 Configure with "UseDefaultAddress = TRUE" is called, that means the default interface (IpSb->DefaultInterface) will be selected as current instance's interface. In #3, when DHCP process finished, the original DefaultInterface will be abandoned/freed because "IpSb->Reconfig" flag is true. Meanwhile, one new interface is assigned to "IpSb->DefaultInterface". This new interface is different to the original one assigned to the UDP4 Configured instance. So, even DHCP process succeed, the up caller will never have the chance to get it's truly status. Cc: Cohen Eugene <eugene@hp.com> Cc: Ye Ting <ting.ye@intel.com> Cc: Fu Siyuan <siyuan.fu@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com> Tested-by: Eugene Cohen <eugene@hp.com> Reviewed-by: Ye Ting <ting.ye@intel.com> |
||
|---|---|---|
| .. | ||
| ComponentName.c | ||
| Ip4Common.c | ||
| Ip4Common.h | ||
| Ip4Config2.vfr | ||
| Ip4Config2Impl.c | ||
| Ip4Config2Impl.h | ||
| Ip4Config2Nv.c | ||
| Ip4Config2Nv.h | ||
| Ip4Driver.c | ||
| Ip4Driver.h | ||
| Ip4Dxe.inf | ||
| Ip4Dxe.uni | ||
| Ip4DxeExtra.uni | ||
| Ip4DxeStrings.uni | ||
| Ip4Icmp.c | ||
| Ip4Icmp.h | ||
| Ip4If.c | ||
| Ip4If.h | ||
| Ip4Igmp.c | ||
| Ip4Igmp.h | ||
| Ip4Impl.c | ||
| Ip4Impl.h | ||
| Ip4Input.c | ||
| Ip4Input.h | ||
| Ip4NvData.h | ||
| Ip4Option.c | ||
| Ip4Option.h | ||
| Ip4Output.c | ||
| Ip4Output.h | ||
| Ip4Route.c | ||
| Ip4Route.h | ||