tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
audk/UefiCpuPkg/Library/CpuCommonFeaturesLib
History
Ruiyu Ni 8558838922 UefiCpuPkg/CommonFeature: Always set FEATURE_CONTROL.Lock 
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1305

The patch reverts commit 1ed6498c4a
* UefiCpuPkg/CommonFeature: Skip locking when the feature is disabled

FEATURE_CONTROL.Lock bit is controlled by feature
CPU_FEATURE_LOCK_FEATURE_CONTROL_REGISTER. The commit 1ed649 fixes
a bug that when the feature is disabled, the Lock bit is cleared.
But it's a security hole if the bit is cleared when booting OS.
We can argue that platform needs to make sure the value
of PcdCpuFeaturesUserConfiguration should be set properly to make
sure feature CPU_FEATURE_LOCK_FEATURE_CONTROL_REGISTER is enabled.

But it's better to guarantee this in the generic core code.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
Reviewed-by: Eric Dong <eric.dong@intel.com>
Acked-by: Laszlo Ersek <lersek@redhat.com>
Cc: Andrew Fish <afish@apple.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
 		2018-11-14 11:02:48 +08:00
..
Aesni.c
…
C1e.c UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info. 2018-10-22 11:19:49 +08:00
ClockModulation.c
…
CpuCommonFeatures.h
…
CpuCommonFeaturesLib.c
…
CpuCommonFeaturesLib.inf
…
CpuCommonFeaturesLib.uni
…
Eist.c UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info. 2018-10-22 11:19:49 +08:00
ExecuteDisable.c UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info. 2018-10-22 11:19:49 +08:00
FastStrings.c UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info. 2018-10-22 11:19:49 +08:00
FeatureControl.c UefiCpuPkg/CommonFeature: Always set FEATURE_CONTROL.Lock 2018-11-14 11:02:48 +08:00
LimitCpuIdMaxval.c UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info. 2018-10-22 11:19:49 +08:00
MachineCheck.c UefiCpuPkg/CpuCommonFeaturesLib: Remove white space at line end. 2018-10-26 11:28:36 +08:00
MonitorMwait.c UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info. 2018-10-22 11:19:49 +08:00
PendingBreak.c UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info. 2018-10-22 11:19:49 +08:00
Ppin.c UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info. 2018-10-22 11:19:49 +08:00
ProcTrace.c UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info. 2018-10-22 11:19:49 +08:00
X2Apic.c UefiCpuPkg/CpuCommonFeaturesLib: Register MSR base on scope Info. 2018-10-22 11:19:49 +08:00