mirror of https://github.com/acidanthera/audk.git
d2a0d2e6ac
Fix various errors when piping a UNICODE or ASCII file to a simple shell application that reads standard input and writes it to standard output. 1) When the memory file is created by CreateFileInferfaceMem() to capture the pipe output, no UNICODE BOM is written to the memory file. Later, when the memory file is read by the application using ShellFileHandleReadLine(), the function indicates that the file is ASCII because there is no BOM. 2) If the file is piped as ASCII, the ASCII memory image is not correctly created by FileInterfaceMemWrite() as each ASCII character is followed by '\0' in the image (when the ASCII data is written to the memory image, the file position should only be incremented by half the buffer size). 3) ShellFileHandleReadLine() does not read ASCII files correctly (writes to Buffer need to be cast as CHAR8*). 4) FileInterfaceMemRead() and FileInterfaceMemWrite() as somewhat hard to read and difficult to debug with certain tools due to the typecasting of This. Added a local variable (MemFile) of the correct type to these functions and used it instead of This. Enhancement: ShellFileHandleReadLine() now returns EFI_END_OF_FILE when appropriate. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Jim Dailey <jim_dailey@dell.com> reviewed-by: Jaben Carsey <jaben.carsey@intel.com> |
||
|---|---|---|
| .. | ||
| Application | ||
| Include | ||
| Library | ||
| Contributions.txt | ||
| License.txt | ||
| Readme.txt | ||
| ShellPkg.dec | ||
| ShellPkg.dsc | ||
Readme.txt
============================================================================ OVERVIEW ============================================================================ The UEFI 2.0 shell provides a standard pre-boot command line processor. It is similar to the EDK EFI Shell or a *nix command line parser. ============================================================================ HOW TO INCORPORATE THIS SHELL INTO NT32 ============================================================================ The instructions below are included as a sample and template on how a developer may integrate this code into an existing platform: 1. Add this shell build to the NT32 build: Add the shell.inf to the [components] section as it is in the ShellPkg.dsc. 2. Update system PCDs to support this new module Update the PCD as follows using the Shell's PCD: gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 } 3. Remove the old shell from the NT32 Firmware list Remove the FILE APPLICATION section for the old shell. 4. Add this shell to the NT32 firmware list Add the Shell.INF to the end of the list of DXE modules. 5. Build NT32 ============================================================================