mirror of https://github.com/acidanthera/audk.git
a8acc12dfd
In case ShellConvertStringToUint64() fails the Handles are left uninitialized. That can for example happen for Handle2 and Handle3 in case only one parameter was specified on the command line. Which can trigger the ASSERT() in line 185. Reproducer: boot ovmf to efi shell in qemu, using q35 machine type, then try disconnect the sata controller in efi shell. Fix that by explicitly setting them to NULL in that case. While being at it also simplify the logic and avoid pointlessly calling ShellConvertStringToUint64() in case ParamN is NULL. Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> |
||
|---|---|---|
| .. | ||
| Connect.c | ||
| DevTree.c | ||
| Devices.c | ||
| Dh.c | ||
| Disconnect.c | ||
| Drivers.c | ||
| DrvCfg.c | ||
| DrvDiag.c | ||
| OpenInfo.c | ||
| Reconnect.c | ||
| UefiShellDriver1CommandsLib.c | ||
| UefiShellDriver1CommandsLib.h | ||
| UefiShellDriver1CommandsLib.inf | ||
| UefiShellDriver1CommandsLib.uni | ||
| Unload.c | ||