tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
audk/MdeModulePkg
History
Star Zeng 62016c1e89 MdeModulePkg VariableSmm: Do not need check CommBufferSize buffer 
Current code in SmmVariableHandler() checks CommBufferSize
buffer to make sure it points to outside SMRAM in
"case SMM_VARIABLE_FUNCTION_GET_STATISTICS".

But after eaae7b33b1,
CommBufferSize buffer points to SMRAM that was used by
SMM core to cache CommSize from SmmCommunication protocol,
then the check will fail definitely and GET_STATISTICS
feature breaks.

In fact, do not need check CommBufferSize buffer at all
even before eaae7b33b1.
Before eaae7b33b1,
CommBufferSize buffer pointed to gSmmCorePrivate->BufferSize
that is outside SMRAM, the check will success definitely;
after eaae7b33b1,
CommBufferSize buffer points to local variable BufferSize
(in SMRAM) in SmmEntryPoint(), the check is not needed
definitely.

The patch is to remove the check.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.zeng@intel.com>
Reviewed-by: Jiewen Yao <jiewen.yao@intel.com>
 		2016-12-12 09:17:58 +08:00
..
Application MdeModulePkg/CapsuleApp: add Internal for function name. 2016-12-01 19:07:52 +08:00
Bus MdeModulePkg/NonDiscoverablePciDevice: add missing cast and EFIAPI modifiers 2016-12-09 14:51:36 +00:00
Core MdeModulePkg/PiSmmCore: use EfiPagesToSize to prevent build error. 2016-12-07 13:13:54 +08:00
Include MdeModulePkg: introduce helper library to register non-discoverable devices 2016-12-07 09:01:27 +00:00
Library MdeModulePkg: introduce helper library to register non-discoverable devices 2016-12-07 09:01:27 +00:00
Logo MdeModulePkg/Logo: rebase to ARRAY_SIZE() 2016-10-27 11:10:57 +02:00
Universal MdeModulePkg VariableSmm: Do not need check CommBufferSize buffer 2016-12-12 09:17:58 +08:00
Contributions.txt
…
License.txt
…
MdeModulePkg.dec MdeModulePkg: introduce helper library to register non-discoverable devices 2016-12-07 09:01:27 +00:00
MdeModulePkg.dsc MdeModulePkg: implement generic PCI I/O driver for non-discoverable devices 2016-12-07 09:45:56 +00:00
MdeModulePkg.uni MdeModulePkg: Add PcdPciDegradeResourceForOptionRom prompt&help to UNI 2016-10-25 10:52:44 +08:00
MdeModulePkgExtra.uni
…