mirror of https://github.com/acidanthera/audk.git
8b0932c19f
In DxeImageVerificationHandler(), we should return EFI_SECURITY_VIOLATION
for a rejected image only if the platform sets
DEFER_EXECUTE_ON_SECURITY_VIOLATION as the policy for the image's source.
Otherwise, EFI_ACCESS_DENIED must be returned.
Right now, EFI_SECURITY_VIOLATION is returned for all rejected images,
which is wrong -- it causes LoadImage() to hold on to rejected images (in
untrusted state), for further platform actions. However, if a platform
already set DENY_EXECUTE_ON_SECURITY_VIOLATION, the platform will not
expect the rejected image to stick around in memory (regardless of its
untrusted state).
Therefore, adhere to the platform policy in the return value of the
DxeImageVerificationHandler() function.
Furthermore, according to "32.4.2 Image Execution Information Table" in
the UEFI v2.8 spec, and considering that edk2 only supports (AuditMode==0)
at the moment:
> When AuditMode==0, if the image's signature is not found in the
> authorized database, or is found in the forbidden database, the image
> will not be started and instead, information about it will be placed in
> this table.
we have to store an EFI_IMAGE_EXECUTION_INFO record in both the "defer"
case and the "deny" case. Thus, the AddImageExeInfo() call is not being
made conditional on (Policy == DEFER_EXECUTE_ON_SECURITY_VIOLATION); the
documentation is updated instead.
Cc: Chao Zhang <chao.b.zhang@intel.com>
Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2129
Fixes:
|
||
|---|---|---|
| .. | ||
| AuthVariableLib | ||
| DxeImageAuthenticationStatusLib | ||
| DxeImageVerificationLib | ||
| DxeRsa2048Sha256GuidedSectionExtractLib | ||
| DxeTcg2PhysicalPresenceLib | ||
| DxeTcgPhysicalPresenceLib | ||
| DxeTpm2MeasureBootLib | ||
| DxeTpmMeasureBootLib | ||
| DxeTpmMeasurementLib | ||
| FmpAuthenticationLibPkcs7 | ||
| FmpAuthenticationLibRsa2048Sha256 | ||
| HashInstanceLibSha1 | ||
| HashInstanceLibSha256 | ||
| HashInstanceLibSha384 | ||
| HashInstanceLibSha512 | ||
| HashInstanceLibSm3 | ||
| HashLibBaseCryptoRouter | ||
| HashLibTpm2 | ||
| PeiRsa2048Sha256GuidedSectionExtractLib | ||
| PeiTcg2PhysicalPresenceLib | ||
| PlatformSecureLibNull | ||
| SmmTcg2PhysicalPresenceLib | ||
| Tcg2PpVendorLibNull | ||
| TcgPpVendorLibNull | ||
| TcgStorageCoreLib | ||
| TcgStorageOpalLib | ||
| Tpm2CommandLib | ||
| Tpm2DeviceLibDTpm | ||
| Tpm2DeviceLibRouter | ||
| Tpm2DeviceLibTcg2 | ||
| Tpm12CommandLib | ||
| Tpm12DeviceLibDTpm | ||
| Tpm12DeviceLibTcg | ||
| TpmCommLib | ||