mirror of
https://github.com/acidanthera/audk.git
synced 2025-04-08 17:05:09 +02:00
33c81c25bb
Resolves a new CodeQL error due to the value being incremented in the loop being a narrower type than the variable it is being compared against. The variable is changed to a UINT32 type so it has the same width as the type it is being compared against. Issue explanation: In a loop condition, comparison of a value of a narrow type with a value of a wide type may result in unexpected behavior if the wider value is sufficiently large (or small). This is because the narrower value may overflow. This can lead to an infinite loop. Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Gua Guo <gua.guo@intel.com> Cc: Prakashan Krishnadas Veliyathuparambil <krishnadas.veliyathuparambil.prakashan@intel.com> Cc: K N Karthik <karthik.k.n@intel.com> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Reviewed-by: Gua Guo <gua.guo@intel.com>
75 lines
2.0 KiB
C
75 lines
2.0 KiB
C
/** @file
|
|
Functions implementation in this file are not common for all type of TraceHubDebugSysTLib.
|
|
|
|
Copyright (c) 2023, Intel Corporation. All rights reserved.<BR>
|
|
|
|
SPDX-License-Identifier: BSD-2-Clause-Patent
|
|
|
|
**/
|
|
|
|
#include <Base.h>
|
|
#include <Guid/TraceHubDebugInfoHob.h>
|
|
#include <Library/BaseMemoryLib.h>
|
|
#include <Library/HobLib.h>
|
|
#include "InternalTraceHubApi.h"
|
|
|
|
/**
|
|
Count the total number of Trace Hub debug instance in the system.
|
|
|
|
@retval UINT32 The total number of Trace Hub debug instance in the system.
|
|
**/
|
|
UINT32
|
|
EFIAPI
|
|
CountThDebugInstance (
|
|
VOID
|
|
)
|
|
{
|
|
UINT8 *DbgContext;
|
|
UINT32 DbgInstCount;
|
|
|
|
DbgInstCount = 0;
|
|
|
|
DbgContext = (UINT8 *)GetFirstGuidHob (&gTraceHubDebugInfoHobGuid);
|
|
if (DbgContext != NULL) {
|
|
while (DbgContext != NULL) {
|
|
DbgInstCount++;
|
|
DbgContext = (UINT8 *)GetNextGuidHob (&gTraceHubDebugInfoHobGuid, GET_NEXT_HOB (DbgContext));
|
|
}
|
|
} else {
|
|
DbgInstCount++;
|
|
}
|
|
|
|
return DbgInstCount;
|
|
}
|
|
|
|
/**
|
|
Pack Trace Hub debug instances in the system.
|
|
|
|
@param[in, out] ThPtr A pointer to TRACEHUB_DEBUG_INFO_HOB structure.
|
|
@param[in] Count Number of Trace Hub HOBs.
|
|
**/
|
|
VOID
|
|
EFIAPI
|
|
PackThDebugInstance (
|
|
IN OUT TRACEHUB_DEBUG_INFO_HOB *ThPtr,
|
|
IN UINT32 Count
|
|
)
|
|
{
|
|
UINT8 *DbgContext;
|
|
UINT32 Index;
|
|
|
|
DbgContext = GetFirstGuidHob (&gTraceHubDebugInfoHobGuid);
|
|
if (DbgContext != NULL) {
|
|
for (Index = 0; Index < Count; Index++) {
|
|
CopyMem (&ThPtr[Index], GET_GUID_HOB_DATA (DbgContext), sizeof (TRACEHUB_DEBUG_INFO_HOB));
|
|
DbgContext = GetNextGuidHob (&gTraceHubDebugInfoHobGuid, GET_NEXT_HOB (DbgContext));
|
|
}
|
|
} else {
|
|
for (Index = 0; Index < Count; Index++) {
|
|
ThPtr[Index].TraceHubMmioAddress = FixedPcdGet64 (PcdTraceHubDebugMmioAddress);
|
|
ThPtr[Index].Flag = FixedPcdGetBool (PcdEnableTraceHubDebugMsg);
|
|
ThPtr[Index].DebugLevel = FixedPcdGet8 (PcdTraceHubDebugLevel);
|
|
}
|
|
}
|
|
}
|