audk/MdeModulePkg/Core/PiSmmCore
Jian J Wang 54ec85dd29 MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM
This patch fixes an issue introduced by commit

  5b91bf82c6

and

  0c9f2cb10b

This issue will only happen if PcdDxeNxMemoryProtectionPolicy is
enabled for reserved memory, which will mark SMM RAM as NX (non-
executable) during DXE core initialization. SMM IPL driver will
unset the NX attribute for SMM RAM to allow loading and running
SMM core/drivers.

But above commit will fail the unset operation of the NX attribute
due to a fact that SMM RAM has zero cache attribute (MRC code always
sets 0 attribute to reserved memory), which will cause GCD internal
method ConverToCpuArchAttributes() to return 0 attribute, which is
taken as invalid CPU paging attribute and skip the calling of
gCpu->SetMemoryAttributes().

The solution is to make use of existing functionality in PiSmmIpl
to make sure one cache attribute is set for SMM RAM. For performance
consideration, PiSmmIpl will always try to set SMM RAM to write-back.
But there's a hole in the code which will fail the setting write-back
attribute because of no corresponding cache capabilities. This patch
will add necessary cache capabilities before setting corresponding
attributes.

Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
Reviewed-by: Star Zeng <star.zeng@intel.com>
2018-04-13 13:05:00 +08:00
..
Dependency.c
Dispatcher.c
Handle.c
HeapGuard.c MdeModulePkg/SmmCore: add sanity check for SetMemoryAttributes 2018-04-13 13:04:59 +08:00
HeapGuard.h
InstallConfigurationTable.c
Locate.c
MemoryAttributesTable.c
Notify.c
Page.c
PiSmmCore.c MdeModulePkg PiSmmCore: Register SMI handler to install S3SmmInitDone 2018-03-03 14:20:38 +08:00
PiSmmCore.h MdeModulePkg PiSmmCore: Register SMI handler to install S3SmmInitDone 2018-03-03 14:20:38 +08:00
PiSmmCore.inf MdeModulePkg PiSmmCore: Register SMI handler to install S3SmmInitDone 2018-03-03 14:20:38 +08:00
PiSmmCore.uni
PiSmmCoreExtra.uni
PiSmmCorePrivateData.h
PiSmmIpl.c MdeModulePkg/PiSmmIpl: fix non-executable SMM RAM 2018-04-13 13:05:00 +08:00
PiSmmIpl.inf
PiSmmIpl.uni
PiSmmIplExtra.uni
Pool.c
Smi.c MdeModulePkg/SmmCore: Fix hang due to already-freed memory deference 2018-02-03 14:48:58 +08:00
SmiHandlerProfile.c
SmramProfileRecord.c