Acidanthera UEFI Development Kit based on EDK II edk2-stable202311
Go to file
Ard Biesheuvel d430568887 MdeModulePkg/UefiBootManagerLib: fix crash on uninitialized ExitData
As reported by Gary, the recent LoadImage/StartImage changes to
accommodate dispatching PE/COFF images built for foreign architectures
may result in a crash when loading an IA32 option ROM into a X64 VM
running OVMF:

  Loading driver at 0x0007E537000 EntryPoint=0x0007E53C06D 8086100e.efi
  InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 7F003B98
  ProtectUefiImageCommon - 0x7F002BC0
    - 0x000000007E537000 - 0x000000000009F900
  Image type IA32 can't be started on X64 UEFI system.
  ASSERT MdeModulePkg/Core/Dxe/Mem/Pool.c(698): Head->Signature == ((('p') |
              ('h' << 8)) | ((('d') | ('0' << 8)) << 16)) || Head->Signature
              == ((('p') | ('h' << 8)) | ((('d') | ('1' << 8)) << 16))

This turns out to be caused by the deferred image loading code in BDS,
which ends up trying to free an uninitialized 'ExitData' pointer.

Given that ExitData is never actually used, let's just get rid of it
entirely. While we're at it, drop the pointless assignment of Status
as well.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Tested-by: Gary Lin <glin@suse.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
2019-04-17 18:02:37 -07:00
AppPkg AppPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:32 -07:00
ArmPkg ArmPkg: Replace BSD License with BSD+Patent License 2019-04-09 09:10:21 -07:00
ArmPlatformPkg ArmPlatformPkg: Replace BSD License with BSD+Patent License 2019-04-09 09:10:21 -07:00
ArmVirtPkg ArmVirtPkg: Update UefiDecompressLib instance 2019-04-10 14:11:48 +08:00
BaseTools BaseTools:update ConvertFceToStructurePcd.py with the char order PCD name. 2019-04-18 08:55:21 +08:00
BeagleBoardPkg BeagleBoardPkg: Update UefiDecompressLib instance 2019-04-10 14:11:48 +08:00
Conf
CorebootModulePkg CorebootModulePkg: Replace BSD License with BSD+Patent License 2019-04-09 09:10:22 -07:00
CorebootPayloadPkg CorebootPayloadPkg: Remove the dependency of ShellBinPkg 2019-04-15 23:00:59 +08:00
CryptoPkg CryptoPkg: Replace BSD License with BSD+Patent License 2019-04-09 09:10:22 -07:00
DynamicTablesPkg DynamicTablesPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:57:57 -07:00
EmbeddedPkg EmbeddedPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:57:58 -07:00
EmulatorPkg EmulatorPkg/Unix: Rename GdbRun to GdbRun.sh 2019-04-15 14:54:08 -07:00
FatPkg FatPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:57:59 -07:00
FmpDevicePkg FmpDevicePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:00 -07:00
IntelFrameworkModulePkg IntelFrameworkModulePkg: Fix comments and improve E820 debug output 2019-04-11 08:29:10 +08:00
IntelFrameworkPkg IntelFrameworkPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:02 -07:00
IntelFsp2Pkg IntelFsp2Pkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:03 -07:00
IntelFsp2WrapperPkg IntelFsp2WrapperPkg: Perform post FSP-S process. 2019-04-16 12:46:58 +08:00
IntelFspPkg IntelFspPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:04 -07:00
IntelFspWrapperPkg IntelFspWrapperPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:05 -07:00
IntelSiliconPkg IntelSiliconPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:05 -07:00
MdeModulePkg MdeModulePkg/UefiBootManagerLib: fix crash on uninitialized ExitData 2019-04-17 18:02:37 -07:00
MdePkg MdePkg/UefiBaseType.h: treat EBC as a non-native machine type 2019-04-14 18:37:36 -07:00
NetworkPkg NetworkPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:15 -07:00
Nt32Pkg Nt32Pkg: Update to use UefiDecompressLib in MdeModulePkg 2019-04-10 14:11:49 +08:00
Omap35xxPkg Omap35xxPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:17 -07:00
OptionRomPkg OptionRomPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:18 -07:00
OvmfPkg OvmfPkg/XenBusDxe: replace MIT license text with SPDX ID 2019-04-12 12:04:38 +02:00
PcAtChipsetPkg PcAtChipsetPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:20 -07:00
QuarkPlatformPkg Quark: Update to use UefiDecompressLib in MdeModulePkg 2019-04-10 14:11:49 +08:00
QuarkSocPkg QuarkSocPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:22 -07:00
SecurityPkg SecurityPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:23 -07:00
ShellBinPkg ShellBinPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:24 -07:00
ShellPkg ShellPkg: Clarify the description of acpiview option '-s' 2019-04-11 14:45:33 +08:00
SignedCapsulePkg SignedCapsulePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:26 -07:00
SourceLevelDebugPkg SourceLevelDebugPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:27 -07:00
StandaloneMmPkg StandaloneMmPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:27 -07:00
StdLib StdLib: Replace BSD License with BSD+Patent License 2019-04-09 10:58:33 -07:00
StdLibPrivateInternalFiles StdLibPrivateInternalFiles: Replace BSD License with BSD+Patent License 2019-04-09 10:58:33 -07:00
UefiCpuPkg UefiCpuPkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:28 -07:00
UefiPayloadPkg UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader 2019-04-15 12:30:05 -07:00
Vlv2DeviceRefCodePkg Vlv2DeviceRefCodePkg: Replace BSD License with BSD+Patent License 2019-04-09 10:58:30 -07:00
Vlv2TbltDevicePkg Vlv2TbltDevicePkg: Update to use UefiDecompressLib in MdeModulePkg 2019-04-10 14:11:49 +08:00
.gitignore
.gitmodules
BuildNotes2.txt BaseTools: Various typo 2019-02-14 10:02:28 +08:00
License-History.txt edk2: Add License-History.txt 2019-04-09 09:10:18 -07:00
License.txt edk2: Change License.txt from 2-Clause BSD to BSD+Patent 2019-04-09 09:10:18 -07:00
Maintainers.txt Maintainers.txt: Remove EdkCompatibilityPkg information 2019-03-27 11:31:35 +08:00
Readme.md edk2: Remove Contributions.txt and update Readme.md 2019-04-09 10:58:34 -07:00
edksetup.bat edk2: Replace BSD License with BSD+Patent License 2019-04-09 09:10:18 -07:00
edksetup.sh edk2: Replace BSD License with BSD+Patent License 2019-04-09 09:10:18 -07:00

Readme.md

EDK II Project

A modern, feature-rich, cross-platform firmware development environment for the UEFI and PI specifications from www.uefi.org.

The majority of the content in the EDK II open source project uses a BSD-2-Clause Plus Patent License. The EDK II open source project contains the following components that are covered by additional licenses:

The EDK II Project is composed of packages. The maintainers for each package are listed in Maintainers.txt.

Resources

Code Contributions

To make a contribution to a TianoCore project, follow these steps.

  1. Create a change description in the format specified below to use in the source control commit log.

  2. Your commit message must include your Signed-off-by signature

  3. Submit your code to the TianoCore project using the process that the project documents on its web page. If the process is not documented, then submit the code on development email list for the project.

  4. It is preferred that contributions are submitted using the same copyright license as the base project. When that is not possible, then contributions using the following licenses can be accepted:

    For documentation:

    Contributions of code put into the public domain can also be accepted.

    Contributions using other licenses might be accepted, but further review will be required.

Developer Certificate of Origin

Your change description should use the standard format for a commit message, and must include your Signed-off-by signature.

In order to keep track of who did what, all patches contributed must include a statement that to the best of the contributor's knowledge they have the right to contribute it under the specified license.

The test for this is as specified in the Developer's Certificate of Origin (DCO) 1.1. The contributor certifies compliance by adding a line saying

Signed-off-by: Developer Name developer@example.org

where Developer Name is the contributor's real name, and the email address is one the developer is reachable through at the time of contributing.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Sample Change Description / Commit Message

From: Contributor Name <contributor@example.com>
Subject: [Repository/Branch PATCH] Pkg-Module: Brief-single-line-summary

Full-commit-message

Signed-off-by: Contributor Name <contributor@example.com>

Notes for sample patch email

  • The first line of commit message is taken from the email's subject line following [Repository/Branch PATCH]. The remaining portion of the commit message is the email's content.
  • git format-patch is one way to create this format

Definitions for sample patch email

  • Repository is the identifier of the repository the patch applies. This identifier should only be provided for repositories other than edk2. For example edk2-BuildSpecification or staging.
  • Branch is the identifier of the branch the patch applies. This identifier should only be provided for branches other than edk2/master. For example edk2/UDK2015, edk2-BuildSpecification/release/1.27, or staging/edk2-test.
  • Module is a short identifier for the affected code or documentation. For example MdePkg, MdeModulePkg/UsbBusDxe, Introduction, or EDK II INF File Format.
  • Brief-single-line-summary is a short summary of the change.
  • The entire first line should be less than ~70 characters.
  • Full-commit-message a verbose multiple line comment describing the change. Each line should be less than ~70 characters.
  • Signed-off-by is the contributor's signature identifying them by their real/legal name and their email address.