Ruiyu Ni dd190645eb MdeModulePkg/UsbKb: fix shell edit cannot read '!@#$%^&*' characters ... Commit 5563281fa2 * ShellPkg/[hex]edit: use SimpleTextInEx to read console changes shell edit and hexedit to read input through SimpleTextInEx. It exposes a issue in UsbKeyboard driver: Per UEFI Spec, When interpreting the data from this function (ReadKeyStrokeEx), it should be noted that if a class of printable characters that are normally adjusted by shift modifiers (e.g. Shift Key + "f" key) would be presented solely as a KeyData.Key.UnicodeChar without the associated shift state. So in the previous example of a Shift Key + "f" key being pressed, the only pertinent data returned would be KeyData.Key.UnicodeChar with the value of "F". UsbKeyboard driver does convert Shift Key + "f" to "F" without the shift state. But it doesn't do the conversion for all printable characters, e.g.: Shift Key + "1" --> "!". The root cause is today's logic to check whether a character is printable or not is as below: if ((KeyDescriptor->AffectedAttribute & EFI_AFFECTED_BY_CAPS_LOCK) != 0) { So it only converts Shift + "a"-"z", but doesn't for Shift + "0"-"9", and Shift + "["... The patch updates the check logic as below to fix the issue: if ((KeyDescriptor->Unicode != CHAR_NULL) && (KeyDescriptor->ShiftedUnicode != CHAR_NULL) && (KeyDescriptor->Unicode != KeyDescriptor->ShiftedUnicode)) { The above check is TRUE when the character is printable and it's *really* affected by Shift key. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com> Reviewed-by: Star Zeng <star.zeng@intel.com>		2018-03-26 09:28:58 +08:00
..
Ata	MdeModulePkg/AtaAtapiPassThru: Revert patch to disable PCI attributes	2017-11-29 09:02:46 +08:00
I2c/I2cDxe	MdeModulePkg: Convert all .uni files to utf-8	2015-12-15 04:56:23 +00:00
Isa	MdeModulePkg/Ps2Kb: ReadKeyStrokeEx always return key state	2018-02-01 14:04:02 +08:00
Pci	MdeModulePkg/PciBus: return CPU address for GetBarAttributes	2018-03-15 08:26:06 +00:00
Scsi	MdeModulePkg/ScsiDisk: Return EFI_NO_MEDIA when no media presents	2017-12-09 12:32:42 +08:00
Sd	MdeModulePkg/SdBlockIoPei: Support IoMmu	2017-11-17 11:38:46 +08:00
Ufs	MdeModulePkg/UfsBlockIoPei: Support IoMmu	2017-11-17 11:35:02 +08:00
Usb	MdeModulePkg/UsbKb: fix shell edit cannot read '!@#$%^&*' characters	2018-03-26 09:28:58 +08:00