mirror of https://github.com/acidanthera/audk.git
cce01f538f
The EDK II C Coding Standards Specification (v2.20) strongly discourages
variable declarations in nested block scope:
5 Source Files
5.4 Code File Structure
5.4.1 Scoping Rules
5.4.1.1 Scope
> Block (local) Scope
>
> [...]
>
> Data declarations may follow the opening brace of a compound statement,
> regardless of nesting depth, and before any code generating statements
> have been entered. Other than at the outermost block of a function body,
> this type of declaration is strongly discouraged.
Hoist such variable declarations in Base64Decode() to the outermost
function scope.
Cc: Liming Gao <liming.gao@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Fixes:
|
||
|---|---|---|
| .. | ||
| AArch64 | ||
| Arm | ||
| Ebc | ||
| Ia32 | ||
| X64 | ||
| ARShiftU64.c | ||
| BaseLib.inf | ||
| BaseLib.uni | ||
| BaseLibInternals.h | ||
| BitField.c | ||
| CheckSum.c | ||
| ChkStkGcc.c | ||
| Cpu.c | ||
| CpuDeadLoop.c | ||
| DivS64x64Remainder.c | ||
| DivU64x32.c | ||
| DivU64x32Remainder.c | ||
| DivU64x64Remainder.c | ||
| FilePaths.c | ||
| GetPowerOfTwo32.c | ||
| GetPowerOfTwo64.c | ||
| HighBitSet32.c | ||
| HighBitSet64.c | ||
| LRotU32.c | ||
| LRotU64.c | ||
| LShiftU64.c | ||
| LinkedList.c | ||
| LongJump.c | ||
| LowBitSet32.c | ||
| LowBitSet64.c | ||
| Math64.c | ||
| ModU64x32.c | ||
| MultS64x64.c | ||
| MultU64x32.c | ||
| MultU64x64.c | ||
| RRotU32.c | ||
| RRotU64.c | ||
| RShiftU64.c | ||
| SafeString.c | ||
| SetJump.c | ||
| String.c | ||
| SwapBytes16.c | ||
| SwapBytes32.c | ||
| SwapBytes64.c | ||
| SwitchStack.c | ||
| Unaligned.c | ||
| X86DisablePaging32.c | ||
| X86DisablePaging64.c | ||
| X86EnablePaging32.c | ||
| X86EnablePaging64.c | ||
| X86FxRestore.c | ||
| X86FxSave.c | ||
| X86GetInterruptState.c | ||
| X86MemoryFence.c | ||
| X86Msr.c | ||
| X86PatchInstruction.c | ||
| X86RdRand.c | ||
| X86ReadGdtr.c | ||
| X86ReadIdtr.c | ||
| X86SpeculationBarrier.c | ||
| X86Thunk.c | ||
| X86WriteGdtr.c | ||
| X86WriteIdtr.c | ||