mirror of https://github.com/acidanthera/audk.git
2ddae5df31
The current dependency evaluator violates the memory access permission when patching depex grammar directly in the read-only depex memory area. Laszlo pointed out the optimization issue in the thread (1) "Memory Attribute for depex section" and provided suggested patch to remove the perf optimization. In my testing, removing the optimization does not make significant perf reduction. That makes sense that StandaloneMM dispatcher only searches in MM protocol database and does not depend on UEFI/DXE protocol database. Also, we don't have many protocols in StandaloneMM like UEFI/DXE. From Laszlo, "The patch removes the EFI_DEP_REPLACE_TRUE handling altogether, plus it CONST-ifies the Iterator pointer (which points into the DEPEX section), so that the compiler catch any possible accesses at *build time* that would write to the write-protected DEPEX memory area." (1) https://edk2.groups.io/g/devel/message/113531 Signed-off-by: Nhi Pham <nhi@os.amperecomputing.com> Tested-by: levi.yun <yeoreum.yun@arm.com> Reviewed-by: levi.yun <yeoreum.yun@arm.com> Reviewed-by: Ray Ni <ray.ni@intel.com> |
||
|---|---|---|
| .. | ||
| Dependency.c | ||
| Dispatcher.c | ||
| FwVol.c | ||
| Handle.c | ||
| InstallConfigurationTable.c | ||
| Locate.c | ||
| Mmi.c | ||
| Notify.c | ||
| Page.c | ||
| Pool.c | ||
| StandaloneMmCore.c | ||
| StandaloneMmCore.h | ||
| StandaloneMmCore.inf | ||
| StandaloneMmCorePrivateData.h | ||