tyler.durden
/
audk
mirror of https://github.com/acidanthera/audk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
audk/OvmfPkg/VirtNorFlashDxe
History
Gerd Hoffmann e5ec3ba409 OvmfPkg/VirtNorFlashDxe: map flash memory as uncacheable 
Switching from the ArmPlatformPkg/NorFlashDxe driver to the
OvmfPkg/VirtNorFlashDxe driver had the side effect that flash address
space got registered as EFI_MEMORY_WC instead of EFI_MEMORY_UC.

That confuses the linux kernel's numa code, seems this makes kernel
consider the flash being node memory.  "lsmem" changes from ...

    RANGE                                 SIZE  STATE REMOVABLE BLOCK
    0x0000000040000000-0x000000013fffffff   4G online       yes  8-39

... to ...

    RANGE                                  SIZE  STATE REMOVABLE BLOCK
    0x0000000000000000-0x0000000007ffffff  128M online       yes     0
    0x0000000040000000-0x000000013fffffff    4G online       yes  8-39

... and in the kernel log got new error lines:

    NUMA: Warning: invalid memblk node 512 [mem 0x0000000004000000-0x0000000007ffffff]
    NUMA: Faking a node at [mem 0x0000000004000000-0x000000013fffffff]

Changing the attributes back to EFI_MEMORY_UC fixes this.

Fixes: b92298af82 ("ArmVirtPkg/ArmVirtQemu: migrate to OVMF's VirtNorFlashDxe")
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
 		2023-01-12 10:37:16 +00:00
..
VirtNorFlash.c OvmfPkg/VirtNorFlashDxe: use EFI_MEMORY_WC and drop AlignedCopyMem() 2022-10-27 16:52:01 +00:00
VirtNorFlash.h OvmfPkg/VirtNorFlashDxe: drop block I/O protocol implementation 2022-10-27 16:52:01 +00:00
VirtNorFlashDxe.c OvmfPkg/VirtNorFlashDxe: map flash memory as uncacheable 2023-01-12 10:37:16 +00:00
VirtNorFlashDxe.inf OvmfPkg/VirtNorFlashDxe: drop block I/O protocol implementation 2022-10-27 16:52:01 +00:00
VirtNorFlashFvb.c OvmfPkg/VirtNorFlashDxe: drop block I/O protocol implementation 2022-10-27 16:52:01 +00:00