Fix service unit file on Arch Linux (#190)

* Fix service unit file on arch.

* Remove duplication in installer script.

* Improve formatting of installer script bash code.
This commit is contained in:
Marco Vermeulen 2021-03-14 18:23:06 +00:00 committed by GitHub
parent f870049d91
commit e87a32f6c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 106 additions and 114 deletions

View File

@ -11,43 +11,45 @@ distro="$(lsb_release -is)"
release="$(lsb_release -rs)" release="$(lsb_release -rs)"
codename="$(lsb_release -cs)" codename="$(lsb_release -cs)"
separator(){ function separator {
sep="\n-------------------------------------------------------------------------------" sep="\n-------------------------------------------------------------------------------"
echo -e $sep echo -e $sep
} }
# root check # root check
root_check(){ function root_check {
if (( $EUID != 0 )); if (($EUID != 0)); then
then
separator separator
echo -e "\nMust be run as root (i.e: 'sudo $0')." echo -e "\nMust be run as root (i.e: 'sudo $0')."
separator separator
exit 1 exit 1
fi fi
} }
# python packages install # python packages install
pip_pkg_install(){ function pip_pkg_install {
python3 -m pip install -r requirements.txt python3 -m pip install -r requirements.txt
} }
complete_msg(){ function complete_msg {
echo -e "\nauto-cpufreq tool successfully installed.\n" echo -e "\nauto-cpufreq tool successfully installed.\n"
echo -e "For list of options, run:\nauto-cpufreq" echo -e "For list of options, run:\nauto-cpufreq"
} }
# tool install # tool install
install(){ function install {
python3 setup.py install --record files.txt python3 setup.py install --record files.txt
mkdir -p /usr/local/share/auto-cpufreq/ mkdir -p /usr/local/share/auto-cpufreq/
cp -r scripts/ /usr/local/share/auto-cpufreq/ cp -r scripts/ /usr/local/share/auto-cpufreq/
} }
tool_install(){ function update_service_file {
# Debian sed -i 's|ExecStart=/usr/local/bin/auto-cpufreq|ExecStart=/usr/bin/auto-cpufreq|' /usr/local/share/auto-cpufreq/scripts/auto-cpufreq.service
if [ -f /etc/debian_version ]; }
then
function tool_install {
# Debian
if [ -f /etc/debian_version ]; then
separator separator
echo -e "\nDetected Debian based distribution" echo -e "\nDetected Debian based distribution"
separator separator
@ -62,18 +64,16 @@ then
separator separator
complete_msg complete_msg
separator separator
# RedHat # RedHat
elif [ -f /etc/redhat-release ]; elif [ -f /etc/redhat-release ]; then
then
separator separator
echo -e "\nDetected RedHat based distribution\n" echo -e "\nDetected RedHat based distribution\n"
echo -e "\nSetting up Python environment\n" echo -e "\nSetting up Python environment\n"
# CentOS exception # CentOS exception
if [ -f /etc/centos-release ]; if [ -f /etc/centos-release ]; then
then yum install platform-python-devel dmidecode
yum install platform-python-devel dmidecode
else else
yum install python-devel dmidecode yum install python-devel dmidecode
fi fi
echo -e "\nInstalling necessary Python packages\n" echo -e "\nInstalling necessary Python packages\n"
pip_pkg_install pip_pkg_install
@ -83,9 +83,8 @@ then
separator separator
complete_msg complete_msg
separator separator
# Solus # Solus
elif [ -f /etc/solus-release ]; elif [ -f /etc/solus-release ]; then
then
separator separator
echo -e "\nDetected Solus distribution\n" echo -e "\nDetected Solus distribution\n"
echo -e "\nSetting up Python environment\n" echo -e "\nSetting up Python environment\n"
@ -96,21 +95,19 @@ then
separator separator
echo -e "\ninstalling auto-cpufreq tool\n" echo -e "\ninstalling auto-cpufreq tool\n"
install install
sed -i 's/ExecStart=\/usr\/local\/bin\/auto-cpufreq/ExecStart=\/usr\/bin\/auto-cpufreq/' /usr/local/share/auto-cpufreq/scripts/auto-cpufreq.service update_service_file
separator separator
complete_msg complete_msg
separator separator
# OpenSUSE # OpenSUSE
elif [ -f /etc/os-release ] && eval "$(cat /etc/os-release)" && [[ $ID == "opensuse"* ]]; elif [ -f /etc/os-release ] && eval "$(cat /etc/os-release)" && [[ $ID == "opensuse"* ]]; then
then
separator separator
echo -e "\nDetected an OpenSUSE distribution\n" echo -e "\nDetected an OpenSUSE distribution\n"
echo -e "\nSetting up Python environment\n" echo -e "\nSetting up Python environment\n"
if [[ $ID == "opensuse-leap" ]]; if [[ $ID == "opensuse-leap" ]]; then
then zypper install -y python3 python3-pip python3-setuptools python3-devel gcc dmidecode
zypper install -y python3 python3-pip python3-setuptools python3-devel gcc dmidecode
else else
zypper install -y python38 python3-pip python3-setuptools python3-devel gcc dmidecode zypper install -y python38 python3-pip python3-setuptools python3-devel gcc dmidecode
fi fi
echo -e "\nInstalling necessary Python packages\n" echo -e "\nInstalling necessary Python packages\n"
pip_pkg_install pip_pkg_install
@ -120,9 +117,8 @@ then
separator separator
complete_msg complete_msg
separator separator
# Manjaro/Arch # Manjaro/Arch
elif [ -f /etc/os-release ] && eval "$(cat /etc/os-release)" && [[ $ID == "manjaro" || $ID == "arch" || $ID == "garuda" ]]; elif [ -f /etc/os-release ] && eval "$(cat /etc/os-release)" && [[ $ID == "manjaro" || $ID == "arch" || $ID == "garuda" ]]; then
then
separator separator
echo -e "\nDetected an Arch Linux based distribution\n" echo -e "\nDetected an Arch Linux based distribution\n"
echo -e "\nSetting up Python environment\n" echo -e "\nSetting up Python environment\n"
@ -132,11 +128,12 @@ then
separator separator
echo -e "\ninstalling auto-cpufreq tool\n" echo -e "\ninstalling auto-cpufreq tool\n"
install install
update_service_file
separator separator
complete_msg complete_msg
separator separator
# Other # Other
else else
separator separator
echo -e "\nDidn't detect Debian or RedHat based distro.\n" echo -e "\nDidn't detect Debian or RedHat based distro.\n"
echo -e "To complete installation, you need to:" echo -e "To complete installation, you need to:"
@ -159,51 +156,50 @@ else
echo -e "Release: $release" echo -e "Release: $release"
echo -e "Codename: $codename" echo -e "Codename: $codename"
separator separator
fi
}
tool_remove(){
files="files.txt"
share_dir="/usr/local/share/auto-cpufreq/"
srv_install="/usr/bin/auto-cpufreq-install"
srv_remove="/usr/bin/auto-cpufreq-remove"
stats_file="/var/run/auto-cpufreq.stats"
tool_proc_rm="auto-cpufreq --remove"
# stop any running auto-cpufreq argument (daemon/live/monitor)
tool_arg_pids=( $(pgrep -f "auto-cpufreq --") )
for pid in "${tool_arg_pids[@]}"; do
if [[ $tool_arg_pids != $$ ]]; then
kill "$tool_arg_pids"
fi fi
done
# run uninstall in case of installed daemon
if [ -f $srv_remove ]
then
eval $tool_proc_rm
fi
# remove auto-cpufreq and all its supporting files
[ -f $files ] && cat $files | xargs sudo rm -rf && rm -f $files
[ -f $share_dir ] && rm -rf $share_dir
# files cleanup
[ -f $srv_install ] && rm $srv_install
[ -f $srv_remove ] && rm $srv_remove
[ -f $stats_file ] && rm $stats_file
separator
echo -e "\nauto-cpufreq tool and all its supporting files successfully removed."
separator
} }
ask_operation(){ function tool_remove {
echo -e "\n-------------------------- auto-cpufreq installer -----------------------------"
echo -e "\nWelcome to auto-cpufreq tool installer." files="files.txt"
echo -e "\nOptions:\n" share_dir="/usr/local/share/auto-cpufreq/"
read -p "[I]nstall srv_install="/usr/bin/auto-cpufreq-install"
srv_remove="/usr/bin/auto-cpufreq-remove"
stats_file="/var/run/auto-cpufreq.stats"
tool_proc_rm="auto-cpufreq --remove"
# stop any running auto-cpufreq argument (daemon/live/monitor)
tool_arg_pids=($(pgrep -f "auto-cpufreq --"))
for pid in "${tool_arg_pids[@]}"; do
if [[ $tool_arg_pids != $$ ]]; then
kill "$tool_arg_pids"
fi
done
# run uninstall in case of installed daemon
if [ -f $srv_remove ]; then
eval $tool_proc_rm
fi
# remove auto-cpufreq and all its supporting files
[ -f $files ] && cat $files | xargs sudo rm -rf && rm -f $files
[ -f $share_dir ] && rm -rf $share_dir
# files cleanup
[ -f $srv_install ] && rm $srv_install
[ -f $srv_remove ] && rm $srv_remove
[ -f $stats_file ] && rm $stats_file
separator
echo -e "\nauto-cpufreq tool and all its supporting files successfully removed."
separator
}
function ask_operation {
echo -e "\n-------------------------- auto-cpufreq installer -----------------------------"
echo -e "\nWelcome to auto-cpufreq tool installer."
echo -e "\nOptions:\n"
read -p "[I]nstall
[R]emove [R]emove
[Q]uit [Q]uit
@ -212,38 +208,34 @@ Select a key: [i/r/q]: " answer
root_check root_check
if [[ -z "${1}" ]]; if [[ -z "${1}" ]]; then
then ask_operation
ask_operation
else else
case "${1}" in case "${1}" in
"--install") "--install")
answer="i" answer="i"
;; ;;
"--remove") "--remove")
answer="r" answer="r"
;; ;;
*) *)
answer="n" answer="n"
;; ;;
esac esac
fi fi
if [[ $answer == [Ii] ]]; if [[ $answer == [Ii] ]]; then
then root_check
root_check tool_install
tool_install elif [[ $answer == [Rr] ]]; then
elif [[ $answer == [Rr] ]]; root_check
then tool_remove
root_check elif [[ $answer == [Qq] ]]; then
tool_remove separator
elif [[ $answer == [Qq] ]]; echo ""
then exit 0
separator
echo ""
exit 0
else else
separator separator
echo -e "\nUnknown key, aborting ...\n" echo -e "\nUnknown key, aborting ...\n"
exit 1 exit 1
fi fi

View File

@ -5,6 +5,6 @@ After=network.target network-online.target
[Service] [Service]
Type=simple Type=simple
User=root User=root
ExecStart=/usr/bin/auto-cpufreq --daemon ExecStart=/usr/local/bin/auto-cpufreq --daemon
[Install] [Install]
WantedBy=multi-user.target WantedBy=multi-user.target