tyler.durden/bottom
1
0
Fork 0
mirror of https://github.com/ClementTsang/bottom.git synced 2025-07-21 12:45:05 +02:00
Code Issues Packages Projects Releases Wiki Activity

bug: fix -V not working and causing Cirrus CI to fail (#1478)

Browse Source 
* bug: fix -V not working and causing Cirrus CI to fail

* add comment

* update workflows and fix tests
This commit is contained in:
Clement Tsang 2024-06-05 01:12:00 -04:00 committed by GitHub
parent ee2e1fee1c
commit 7aa379aabf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/coverage.yml vendored
View File

@ -64,7 +64,7 @@ jobs:
- name: Install cargo-llvm-cov - name: Install cargo-llvm-cov
run: | run: |
rustup component add llvm-tools-preview rustup component add llvm-tools-preview
cargo install cargo-llvm-cov --version 0.5.37 --locked cargo install cargo-llvm-cov --version 0.6.10 --locked
- name: Generate code coverage - name: Generate code coverage
run: | run: |
@ -72,7 +72,7 @@ jobs:
# The token is generally not needed, but sometimes the default shared token hits limits. # The token is generally not needed, but sometimes the default shared token hits limits.
- name: Upload to codecov.io - name: Upload to codecov.io
uses: Wandalen/wretry.action@a163f62ae554a8f3cbe27b23db15b60c0ae2e93c # v1.3.0 uses: Wandalen/wretry.action@6feedb7dedadeb826de0f45ff482b53b379a7844 # v3.5.0
with: with:
action: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # 3.1.4 action: codecov/codecov-action@eaaf4bedf32dbdc6b720b63067d99c4d77d6047d # 3.1.4
with: | with: |

2
src/options/args.rs
View File

@ -564,7 +564,7 @@ pub struct OtherArgs {
#[arg(short = 'h', long, action = ArgAction::Help, help = "Prints help info (for more details use `--help`.")] #[arg(short = 'h', long, action = ArgAction::Help, help = "Prints help info (for more details use `--help`.")]
help: (), help: (),
#[arg(short = 'v', long, action = ArgAction::Version, help = "Prints version information.")] #[arg(short = 'V', long, action = ArgAction::Version, help = "Prints version information.")]
version: (), version: (),
} }

14
tests/integration/arg_tests.rs
View File

@ -161,3 +161,17 @@ fn test_gpu_flag() {
"unexpected argument '--enable_gpu' found", "unexpected argument '--enable_gpu' found",
)); ));
} }
/// Sanity test due to <https://github.com/ClementTsang/bottom/pull/1478>.
#[test]
fn test_version() {
btm_command(&["--version"]).assert().success();
btm_command(&["-V"]).assert().success();
}
/// Sanity test due to <https://github.com/ClementTsang/bottom/pull/1478>.
#[test]
fn test_help() {
btm_command(&["--help"]).assert().success();
btm_command(&["-h"]).assert().success();
}