From 8fba8b1443a7dce0609ee843fb5616d3665e7f8b Mon Sep 17 00:00:00 2001 From: ClementTsang <34804052+ClementTsang@users.noreply.github.com> Date: Sun, 22 Sep 2024 02:11:24 -0400 Subject: [PATCH] some notes --- src/data_collection/disks/unix/macos/counters.rs | 2 +- src/utils/logging.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/data_collection/disks/unix/macos/counters.rs b/src/data_collection/disks/unix/macos/counters.rs index 7d3d6768..55ce6d52 100644 --- a/src/data_collection/disks/unix/macos/counters.rs +++ b/src/data_collection/disks/unix/macos/counters.rs @@ -6,7 +6,7 @@ use crate::data_collection::disks::IoCounters; fn get_device_io(device: io_kit::IoObject) -> anyhow::Result { let parent = device.service_parent()?; - // XXX: Re: Conform check being disabled. + // NB: Regarding the conform check being disabled. // // Okay, so this is weird. // diff --git a/src/utils/logging.rs b/src/utils/logging.rs index 85230ccb..975122c5 100644 --- a/src/utils/logging.rs +++ b/src/utils/logging.rs @@ -18,7 +18,7 @@ pub fn init_logger( // logging at all in a debug context which is generally fine, // release builds should have this logging disabled entirely for now. unsafe { - // XXX: If we ever DO add general logging as a release feature, evaluate this + // NB: If we ever DO add general logging as a release feature, evaluate this // again and whether this is something we want enabled in // release builds! What might be safe is falling back to the non-set-soundness // mode when specifically using certain feature flags (e.g. dev-logging feature