From c67ba4c4970b11af805328297814a41ad11c7c37 Mon Sep 17 00:00:00 2001
From: Clement Tsang <34804052+ClementTsang@users.noreply.github.com>
Date: Sun, 9 May 2021 23:19:01 -0400
Subject: [PATCH] github: Remove strip from Windows deploy/nightly (#472)

Removes `strip` from the Windows build in deploy/nightly.  It seems to cause VirusTotal to report some false positives.
---
 .github/workflows/deployment.yml | 7 +------
 .github/workflows/nightly.yml    | 7 +------
 2 files changed, 2 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/deployment.yml b/.github/workflows/deployment.yml
index 91d396c1..2b889296 100644
--- a/.github/workflows/deployment.yml
+++ b/.github/workflows/deployment.yml
@@ -96,7 +96,7 @@ jobs:
               target: "x86_64-pc-windows-msvc",
               cross: false,
             }
-          - { os: "windows-2019", target: "i686-pc-windows-msvc", cross: true }
+          - { os: "windows-2019", target: "i686-pc-windows-msvc", cross: false }
           - {
               os: "windows-2019",
               target: "x86_64-pc-windows-gnu",
@@ -193,11 +193,6 @@ jobs:
         run: |
           cp -r ./target/${{ matrix.triple.target }}/release/build/bottom-*/out completion
 
-      - name: Strip release binary (Windows x86-64/i686)
-        if: matrix.triple.os == 'windows-2019' && matrix.triple.target != 'aarch64-unknown-linux-gnu' && matrix.triple.target != 'armv7-unknown-linux-gnueabihf' && matrix.triple.target != 'powerpc64le-unknown-linux-gnu'
-        run: |
-          strip target/${{ matrix.triple.target }}/release/btm.exe
-
       - name: Strip release binary (macOS or Linux x86-64/i686)
         if: matrix.triple.os != 'windows-2019' && matrix.triple.target != 'aarch64-unknown-linux-gnu' && matrix.triple.target != 'armv7-unknown-linux-gnueabihf' && matrix.triple.target != 'powerpc64le-unknown-linux-gnu'
         run: |
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
index d7a46620..aa130a2a 100644
--- a/.github/workflows/nightly.yml
+++ b/.github/workflows/nightly.yml
@@ -87,7 +87,7 @@ jobs:
               target: "x86_64-pc-windows-msvc",
               cross: false,
             }
-          - { os: "windows-2019", target: "i686-pc-windows-msvc", cross: true }
+          - { os: "windows-2019", target: "i686-pc-windows-msvc", cross: false }
           - {
               os: "windows-2019",
               target: "x86_64-pc-windows-gnu",
@@ -179,11 +179,6 @@ jobs:
         run: |
           cp -r ./target/${{ matrix.triple.target }}/release/build/bottom-*/out completion
 
-      - name: Strip release binary (Windows x86-64/i686)
-        if: matrix.triple.os == 'windows-2019' && matrix.triple.target != 'aarch64-unknown-linux-gnu' && matrix.triple.target != 'armv7-unknown-linux-gnueabihf' && matrix.triple.target != 'powerpc64le-unknown-linux-gnu'
-        run: |
-          strip target/${{ matrix.triple.target }}/release/btm.exe
-
       - name: Strip release binary (macOS or Linux x86-64/i686)
         if: matrix.triple.os != 'windows-2019' && matrix.triple.target != 'aarch64-unknown-linux-gnu' && matrix.triple.target != 'armv7-unknown-linux-gnueabihf' && matrix.triple.target != 'powerpc64le-unknown-linux-gnu'
         run: |