From caba6110360f9f4b487779433b09ef493627d5c7 Mon Sep 17 00:00:00 2001 From: Clement Tsang <34804052+ClementTsang@users.noreply.github.com> Date: Fri, 3 Mar 2023 01:00:33 -0500 Subject: [PATCH] docs: update changelog and some comments (#1040) --- CHANGELOG.md | 4 ++++ src/app/data_harvester/disks/freebsd.rs | 1 + src/app/data_harvester/disks/heim.rs | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index cdd09b07..7c64ceae 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Bug Fixes - [#1021](https://github.com/ClementTsang/bottom/pull/1021): Fix selected text background colour being wrong if only the foreground colour was set. +- [#1037](https://github.com/ClementTsang/bottom/pull/1037): Fix `is_list_ignored` accepting all results if set to `false`. ## Features @@ -20,6 +21,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## Changes - [#1025](https://github.com/ClementTsang/bottom/pull/1025): Officially support M1 macOS. +- [#1035](https://github.com/ClementTsang/bottom/pull/1035): Migrate away from heim for CPU information. +- [#1036](https://github.com/ClementTsang/bottom/pull/1036): Migrate away from heim for memory information; Linux + platforms will now try to use `MemAvailable` to determine used memory if supported. ## Other diff --git a/src/app/data_harvester/disks/freebsd.rs b/src/app/data_harvester/disks/freebsd.rs index 5c6f6e80..a7eb7a8c 100644 --- a/src/app/data_harvester/disks/freebsd.rs +++ b/src/app/data_harvester/disks/freebsd.rs @@ -98,6 +98,7 @@ fn matches_ignore_list(filter_check_map: &[(&Option, &String)]) -> bool } fn get_disk_info() -> io::Result { + // TODO: Ideally we don't have to shell out to a new program. let output = std::process::Command::new("df") .args(["--libxo", "json", "-k", "-t", "ufs,msdosfs,zfs"]) .output()?; diff --git a/src/app/data_harvester/disks/heim.rs b/src/app/data_harvester/disks/heim.rs index 70840aba..ad8b08eb 100644 --- a/src/app/data_harvester/disks/heim.rs +++ b/src/app/data_harvester/disks/heim.rs @@ -76,7 +76,7 @@ pub async fn get_disk_usage( let filter_check_map = [(disk_filter, &name), (mount_filter, &mount_point)]; - // This represents case 1. That is, if there is a match in an allowing list - if there is, then + // This represents case 1. That is, if there is a match in an allowing list - if there is, then // immediately allow it! let matches_allow_list = filter_check_map.iter().any(|(filter, text)| { if let Some(filter) = filter {