From ccf58bace90d65f0a0b1ec7ac06f5716d6748690 Mon Sep 17 00:00:00 2001 From: ClementTsang Date: Sat, 15 Feb 2020 18:14:05 -0500 Subject: [PATCH] [skip travis] Some notes and readme changes... and an additional commit before starting next feature. --- README.md | 2 ++ src/app/data_harvester.rs | 4 +++- src/app/data_harvester/temperature.rs | 2 +- src/main.rs | 2 -- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 672f16c0..49be3332 100644 --- a/README.md +++ b/README.md @@ -26,6 +26,8 @@ Features of bottom include: - Maximizing of widgets of interest. +Details about each widget can be found [here](./docs/widgets.md). + The compatibility of each widget and operating systems are, as of version 0.1.0, as follows: | OS | CPU | Memory | Disks | Temperature | Processes | Networks | diff --git a/src/app/data_harvester.rs b/src/app/data_harvester.rs index 1b481ee9..bee29eb7 100644 --- a/src/app/data_harvester.rs +++ b/src/app/data_harvester.rs @@ -117,7 +117,9 @@ impl DataState { // CPU self.data.cpu = cpu::get_cpu_data_list(&self.sys); - // Processes + // Processes. This is the longest part of the harvesting process... changing this might be + // good in the future. What was tried already: + // * Splitting the internal part into multiple scoped threads (dropped by ~.01 seconds, but upped usage) if let Ok(process_list) = processes::get_sorted_processes_list( &self.sys, &mut self.prev_idle, diff --git a/src/app/data_harvester/temperature.rs b/src/app/data_harvester/temperature.rs index dcaa986d..52500047 100644 --- a/src/app/data_harvester/temperature.rs +++ b/src/app/data_harvester/temperature.rs @@ -67,7 +67,7 @@ pub async fn get_temperature_data( } } - // By default, sort temperature, then by alphabetically! Allow for configuring this... + // By default, sort temperature, then by alphabetically! // Note we sort in reverse here; we want greater temps to be higher priority. temperature_vec.sort_by(|a, b| match a.temperature.partial_cmp(&b.temperature) { diff --git a/src/main.rs b/src/main.rs index 44cb2d5a..9a321178 100644 --- a/src/main.rs +++ b/src/main.rs @@ -227,8 +227,6 @@ fn main() -> error::Result<()> { // Convert all data into tui-compliant components - // TODO: [OPT] MT the conversion step. - // Network let network_data = convert_network_data_points(&app.data_collection); app.canvas_data.network_data_rx = network_data.rx;