From d6ad688ab8a24614104bf7969e5ce08d85d11dbc Mon Sep 17 00:00:00 2001
From: Clement Tsang <34804052+ClementTsang@users.noreply.github.com>
Date: Mon, 3 Feb 2025 01:48:12 -0500
Subject: [PATCH] refactor: use cow for disk widget io read/write strings
 (#1664)

---
 src/app/data/store.rs     | 6 +++---
 src/widgets/disk_table.rs | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/app/data/store.rs b/src/app/data/store.rs
index caba5153..db27292f 100644
--- a/src/app/data/store.rs
+++ b/src/app/data/store.rs
@@ -230,7 +230,7 @@ impl StoredData {
                 }
             };
 
-            let (mut io_read, mut io_write) = ("N/A".to_string(), "N/A".to_string());
+            let (mut io_read, mut io_write) = ("N/A".into(), "N/A".into());
             if let Some(Some(io_device)) = io_device {
                 if let Some(prev_io) = self.prev_io.get_mut(itx) {
                     let r_rate = ((io_device.read_bytes.saturating_sub(prev_io.0)) as f64
@@ -243,8 +243,8 @@ impl StoredData {
 
                     *prev_io = (io_device.read_bytes, io_device.write_bytes);
 
-                    io_read = dec_bytes_per_second_string(r_rate);
-                    io_write = dec_bytes_per_second_string(w_rate);
+                    io_read = dec_bytes_per_second_string(r_rate).into();
+                    io_write = dec_bytes_per_second_string(w_rate).into();
                 }
             }
 
diff --git a/src/widgets/disk_table.rs b/src/widgets/disk_table.rs
index c45942ef..7561c150 100644
--- a/src/widgets/disk_table.rs
+++ b/src/widgets/disk_table.rs
@@ -20,8 +20,8 @@ pub struct DiskWidgetData {
     pub used_bytes: Option<u64>,
     pub total_bytes: Option<u64>,
     pub summed_total_bytes: Option<u64>,
-    pub io_read: String,
-    pub io_write: String,
+    pub io_read: Cow<'static, str>,
+    pub io_write: Cow<'static, str>,
 }
 
 impl DiskWidgetData {
@@ -177,8 +177,8 @@ impl DataToCell<DiskColumn> for DiskWidgetData {
             DiskColumn::UsedPercent => percent_string(self.used_percent()),
             DiskColumn::FreePercent => percent_string(self.free_percent()),
             DiskColumn::Total => self.total_space(),
-            DiskColumn::IoRead => self.io_read.clone().into(),
-            DiskColumn::IoWrite => self.io_write.clone().into(),
+            DiskColumn::IoRead => self.io_read.clone(),
+            DiskColumn::IoWrite => self.io_write.clone(),
         };
 
         Some(text)