From 0333d131db1d7bd47e6dcd1a88844e722652e492 Mon Sep 17 00:00:00 2001 From: UrBnW <40244829+UrBnW@users.noreply.github.com> Date: Wed, 16 Jun 2021 13:05:09 +0200 Subject: [PATCH] enh(qnap): memory mode - add a --force-counters-legacy (#2880) as a workaround to memory buggy counters --- .../storage/qnap/snmp/mode/memory.pm | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/centreon-plugins/storage/qnap/snmp/mode/memory.pm b/centreon-plugins/storage/qnap/snmp/mode/memory.pm index d7b817b99..a47e6bed6 100644 --- a/centreon-plugins/storage/qnap/snmp/mode/memory.pm +++ b/centreon-plugins/storage/qnap/snmp/mode/memory.pm @@ -77,7 +77,11 @@ sub new { my ($class, %options) = @_; my $self = $class->SUPER::new(package => __PACKAGE__, %options, force_new_perfdata => 1); bless $self, $class; - + + $options{options}->add_options(arguments => { + 'force-counters-legacy' => { name => 'force_counters_legacy' } + }); + return $self; } @@ -149,8 +153,10 @@ sub manage_selection { oids => [ map($_->{oid} . '.0', values(%{$mapping->{legacy}}), values(%{$mapping->{ex}}), values(%{$mapping->{es}})) ], nothing_quit => 1 ); - $self->check_memory(snmp => $options{snmp}, type => 'ex', snmp_result => $snmp_result); - $self->check_memory(snmp => $options{snmp}, type => 'es', snmp_result => $snmp_result, convert => 1); + if (!defined($self->{option_results}->{force_counters_legacy})) { + $self->check_memory(snmp => $options{snmp}, type => 'ex', snmp_result => $snmp_result); + $self->check_memory(snmp => $options{snmp}, type => 'es', snmp_result => $snmp_result, convert => 1); + } $self->check_memory(snmp => $options{snmp}, type => 'legacy', snmp_result => $snmp_result, convert => 1); } @@ -164,6 +170,10 @@ Check memory. =over 8 +=item B<--force-counters-legacy> + +Force to use legacy counters. Should be used when EX/ES counters are buggy. + =item B<--warning-*> B<--critical-*> Thresholds.