enh(hp-procurve-snmp): new stack mode stack (#5306 #5082)

Co-authored-by: Roman Morandell <46994680+rmorandell-pgum@users.noreply.github.com>

Refs: CTOR-723
This commit is contained in:
Lucie Dubrunfaut 2024-12-03 17:29:26 +01:00 committed by GitHub
parent bbbee4bb37
commit 056589f360
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 418 additions and 6 deletions

View File

@ -40,21 +40,29 @@ for filepath in os.popen('find packaging -type f -name pkg.json').read().split('
packaging_file = open(filepath)
packaging = json.load(packaging_file)
packaging_file.close()
packaging_path = re.search('.*\/(centreon-plugin-.*)\/pkg.json', filepath).group(1)
if not packaging_path == packaging["pkg_name"]:
packaging_path = packaging["pkg_name"]
packaging_path = packaging["pkg_name"]
directory_path = re.search('^(.+)\/pkg.json', filepath).group(1)
if common:
# if the common flag is true, then all packages are included
list_packages.add(packaging_path)
elif directory_path in packages:
# if a package file is changed or created, then the package is included
list_packages.add(packaging_path)
else:
# if we don't build all the plugins and no modification have been made to this package's
# specification, then examine if its source code has been changed
for pkg_file in packaging["files"]:
# for each source code file or directory included in the current package
pkg_file_dir = pkg_file.strip('/').removeprefix('src/')
if pkg_file_dir in list_plugins:
list_packages.add(packaging_path)
# the current package is impacted by the changes if one of the changed files
# is located inside one of the directories of the package
for modified_file in list_plugins:
# if the beginning of the changed file path includes one of the package's directories
if modified_file.find(pkg_file_dir) == 0:
# then the package is included
list_packages.add(packaging_path)
break
print(*list_packages)

View File

@ -0,0 +1,312 @@
#
# Copyright 2023 Centreon (http://www.centreon.com/)
#
# Centreon is a full-fledged industry-strength solution that meets
# the needs in IT infrastructure and application monitoring for
# service performance.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
package network::hp::procurve::snmp::mode::stack;
use base qw(centreon::plugins::templates::counter);
use strict;
use warnings;
use Digest::MD5 qw(md5_hex);
use centreon::plugins::templates::catalog_functions qw(catalog_status_threshold catalog_status_calc);
sub custom_member_status_output {
my ($self, %options) = @_;
my $msg = sprintf(
'role: %s [state: %s]',
$self->{result_values}->{role},
$self->{result_values}->{state},
);
return $msg;
}
sub custom_member_status_calc {
my ($self, %options) = @_;
$self->{result_values}->{roleLast} = $options{old_datas}->{$self->{instance} . '_role'};
$self->{result_values}->{role} = $options{new_datas}->{$self->{instance} . '_role'};
$self->{result_values}->{stateLast} = $options{old_datas}->{$self->{instance} . '_state'};
$self->{result_values}->{state} = $options{new_datas}->{$self->{instance} . '_state'};
if (!defined($options{old_datas}->{$self->{instance} . '_role'})) {
$self->{error_msg} = "buffer creation";
return -2;
}
return 0;
}
sub custom_port_status_output {
my ($self, %options) = @_;
my $msg = sprintf(
'operational status: %s [admin status: %s]',
$self->{result_values}->{oper_status},
$self->{result_values}->{admin_status}
);
return $msg;
}
sub set_counters {
my ($self, %options) = @_;
$self->{maps_counters_type} = [
{ name => 'member',
type => 3,
cb_prefix_output => 'prefix_member_output',
cb_long_output => 'member_long_output',
indent_long_output => ' ',
message_multiple => 'All stack members are ok',
group =>
[
{ name => 'global', type => 0, skipped_code => { -10 => 1 } },
{ name => 'port',
display_long => 1,
cb_prefix_output => 'prefix_port_output',
message_multiple => 'All ports are ok',
type => 1,
skipped_code => { -10 => 1 } },
]
}
];
$self->{maps_counters}->{global} = [
{ label => 'member-status', threshold => 0, set => {
key_values => [ { name => 'role' }, { name => 'display' }, { name => 'state'} ],
closure_custom_calc => $self->can('custom_member_status_calc'),
closure_custom_output => $self->can('custom_member_status_output'),
closure_custom_perfdata => sub {return 0;},
closure_custom_threshold_check => \&catalog_status_threshold,
}
},
];
$self->{maps_counters}->{port} = [
{ label => 'port-status', threshold => 0, set => {
key_values =>
[ { name => 'oper_status' }, { name => 'admin_status' }, { name => 'display' } ],
closure_custom_calc => \&catalog_status_calc,
closure_custom_output => $self->can('custom_port_status_output'),
closure_custom_perfdata => sub {return 0;},
closure_custom_threshold_check => \&catalog_status_threshold,
}
},
];
}
sub member_long_output {
my ($self, %options) = @_;
return "checking stack member '" . $options{instance_value}->{display} . "'";
}
sub prefix_member_output {
my ($self, %options) = @_;
return "Stack member '" . $options{instance_value}->{display} . "' ";
}
sub prefix_port_output {
my ($self, %options) = @_;
return "port '" . $options{instance_value}->{display} . "' ";
}
sub new {
my ($class, %options) = @_;
my $self = $class->SUPER::new(package => __PACKAGE__, %options, statefile => 1, force_new_perfdata => 1);
bless $self, $class;
$options{options}->add_options(arguments => {
'unknown-member-status:s' => { name => 'unknown_member_status', default => '' },
'warning-member-status:s' => { name => 'warning_member_status', default => '' },
'critical-member-status:s' => { name => 'critical_member_status', default => '%{role} ne %{roleLast}' },
'unknown-port-status:s' => { name => 'unknown_port_status', default => '' },
'warning-port-status:s' => { name => 'warning_port_status', default => '' },
'critical-port-status:s' => {
name => 'critical_port_status',
default => '%{admin_status} eq "up" and %{oper_status} ne "up"'
},
});
return $self;
}
sub check_options {
my ($self, %options) = @_;
$self->SUPER::check_options(%options);
$self->change_macros(
macros => [
'unknown_member_status', 'warning_member_status', 'critical_member_status',
'unknown_port_status', 'warning_port_status', 'critical_port_status'
]
);
}
my $map_member_state = {
0 => 'unusedId',
1 => 'missing',
2 => 'provision',
3 => 'commander',
4 => 'standby',
5 => 'member',
6 => 'shutdown',
7 => 'booting',
8 => 'communicationFailure',
9 => 'incompatibleOs',
10 => 'unknownState',
11 => 'standbyBooting'
};
my $map_member_role_status = {
1 => 'active',
2 => 'notInService',
3 => 'notReady',
4 => 'createAndGo',
5 => 'createAndWait',
6 => 'destroy'
};
my $map_port_admin_status = {
1 => 'enabled',
2 => 'disabled'
};
my $map_port_operation_status = {
1 => 'up',
2 => 'down',
3 => 'disabled',
4 => 'blocked'
};
my $mapping_member_table = {
stackMemberSerialNum => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.14' },
stackMemberRoleStatus => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.7', map => $map_member_role_status },
stackMemberState => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.9', map => $map_member_state },
};
my $mapping_port_table = {
stackPortAdminStatus => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.8', map => $map_port_admin_status },
stackPortOperStatus => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.3', map => $map_port_operation_status }
};
my $oid_memberTableEntry = '.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1';
my $oid_portTableEntry = '.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1';
sub manage_selection {
my ($self, %options) = @_;
$self->{member} = {};
my $snmp_result = $options{snmp}->get_multiple_table(
oids => [
{ oid => $oid_memberTableEntry },
{ oid => $mapping_member_table->{stackMemberSerialNum}->{oid} },
{ oid => $mapping_member_table->{stackMemberRoleStatus}->{oid} },
{ oid => $mapping_member_table->{stackMemberState}->{oid} }
,
{ oid => $oid_portTableEntry },
{ oid => $mapping_port_table->{stackPortAdminStatus}->{oid} },
{ oid => $mapping_port_table->{stackPortOperStatus}->{oid} },
,
],
nothing_quit => 1
);
foreach my $oid (keys %{$snmp_result->{$oid_memberTableEntry}}) {
next if ($oid !~ /^$mapping_member_table->{stackMemberRoleStatus}->{oid}\.(.*)$/);
my $instance_id = $1;
my $result = $options{snmp}->map_instance(
mapping => $mapping_member_table,
results => $snmp_result->{$oid_memberTableEntry},
instance => $instance_id);
$self->{member}->{$result->{stackMemberSerialNum}} = {
display => $result->{stackMemberSerialNum},
global => {
display => $result->{stackMemberSerialNum},
role => $result->{stackMemberRoleStatus},
state => $result->{stackMemberState},
},
port => {},
};
foreach (keys %{$snmp_result->{$oid_portTableEntry}}) {
next if (!/^$mapping_port_table->{stackPortOperStatus}->{oid}\.$instance_id\.(.*?)\.(.*)$/);
my $port_name = $1;
my $result2 = $options{snmp}->map_instance(
mapping => $mapping_port_table,
results => $snmp_result->{$oid_portTableEntry},
instance => $instance_id . '.' . $port_name . '.1');
$self->{member}->{$result->{stackMemberSerialNum}}->{port}->{$port_name} = {
display => $port_name,
admin_status => $result2->{stackPortAdminStatus},
oper_status => $result2->{stackPortOperStatus},
};
}
}
$self->{cache_name} = "hp_procurve_" . $self->{mode} . '_' . $options{snmp}->get_hostname() . '_' . $options{snmp}->get_port() . '_' .
(defined($self->{option_results}->{filter_counters}) ?
md5_hex($self->{option_results}->{filter_counters}) :
md5_hex('all'));
}
1;
__END__
=head1 MODE
Check stack members.
=over 8
=item B<--unknown-member-status>
Define the conditions to match for the status to be UNKNOWN (Default: '').
You can use the following variables: %{role}, %{roleLast}, %{state}, %{stateLast}
=item B<--warning-member-status>
Define the conditions to match for the status to be WARNING (Default: '').
You can use the following variables: %{role}, %{roleLast}, %{state}, %{stateLast}
=item B<--critical-member-status>
Define the conditions to match for the status to be CRITICAL (Default: '%{role} ne %{roleLast}').
You can use the following variables: %{role}, %{roleLast}, %{state}, %{stateLast}
=item B<--unknown-port-status>
Define the conditions to match for the status to be UNKNOWN (Default: '').
You can use the following variables: %{admin_status}, %{oper_status}, %{display}
=item B<--warning-port-status>
Define the conditions to match for the status to be WARNING (Default: '').
You can use the following variables: %{admin_status}, %{oper_status}, %{display}
=item B<--critical-port-status>
Define the conditions to match for the status to be CRITICAL (Default: '%{admin_status} eq "up" and %{oper_status} ne "up"').
You can use the following variables: %{admin_status}, %{oper_status}, %{display}
=back
=cut

View File

@ -36,6 +36,7 @@ sub new {
'interfaces' => 'network::hp::procurve::snmp::mode::interfaces',
'list-interfaces' => 'snmp_standard::mode::listinterfaces',
'memory' => 'network::hp::procurve::snmp::mode::memory',
'stack' => 'network::hp::procurve::snmp::mode::stack',
'virtual-chassis' => 'network::hp::procurve::snmp::mode::virtualchassis'
};

View File

@ -0,0 +1,52 @@
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.2.1 = STRING: Anonymized 121
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.2.2 = STRING: Anonymized 175
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.3.1 = Hex-STRING: 94 18 82 D8 04 40
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.3.2 = Hex-STRING: D0 67 26 72 32 80
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.4.1 = INTEGER: 2
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.4.2 = INTEGER: 2
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.5.1 = INTEGER: 2
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.5.2 = INTEGER: 2
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.6.1 = INTEGER: 255
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.6.2 = INTEGER: 128
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.7.1 = INTEGER: 3
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.7.2 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.8.1 = INTEGER: 101001
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.8.2 = INTEGER: 201001
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.9.1 = INTEGER: 3
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.9.2 = INTEGER: 4
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.10.1 = STRING: Anonymized 000
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.10.2 = STRING: Anonymized 011
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.11.1 = Timeticks: (1730459700) 200 days, 6:49:57.00
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.11.2 = Timeticks: (1730463400) 200 days, 6:50:34.00
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.12.1 = OID: .1.3.6.1.4.1.11.2.3.7.11.155
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.12.2 = OID: .1.3.6.1.4.1.11.2.3.7.11.155
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.14.1 = STRING: Anonymized 239
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.14.2 = STRING: Anonymized 238
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.15.1 = INTEGER: 84
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.15.2 = INTEGER: 4
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.16.1 = INTEGER: 74322432
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.16.2 = INTEGER: 74322432
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.17.1 = INTEGER: 41957260
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.17.2 = INTEGER: 44788680
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.18.1 = STRING: Anonymized 151
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.18.2 = STRING: Anonymized 141
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.19.1 = STRING: Anonymized 177
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.19.2 = STRING: Anonymized 100
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.20.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.3.1.20.2 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.3.1.1.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.3.1.2.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.3.2.1.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.3.2.2.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.4.1.1.1 = STRING: "2.2"
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.4.1.2.1 = STRING: "2.1"
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.4.2.1.1 = STRING: "1.2"
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.4.2.2.1 = STRING: "1.1"
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.5.1.1.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.5.1.2.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.5.2.1.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.5.2.2.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.8.1.1.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.8.1.2.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.8.2.1.1 = INTEGER: 1
.1.3.6.1.4.1.11.2.14.11.5.1.69.1.5.1.8.2.2.1 = INTEGER: 1

View File

@ -0,0 +1,37 @@
*** Settings ***
Documentation Check stack members.
Resource ${CURDIR}${/}..${/}..${/}..${/}..${/}resources/import.resource
Test Timeout 120s
Test Setup Ctn Generic Suite Setup
*** Variables ***
${CMD} ${CENTREON_PLUGINS} --plugin=network::hp::procurve::snmp::plugin
*** Test Cases ***
stack ${tc}
[Tags] network hp
${command} Catenate
... ${CMD}
... --mode=stack
... --hostname=${HOSTNAME}
... --snmp-version=${SNMPVERSION}
... --snmp-port=${SNMPPORT}
... --snmp-community=network/hp/procurve/snmp/slim_procurve_stack
... --snmp-timeout=1
... ${extra_options}
# first run to build cache
Run ${command}
# second run to control the output
Ctn Run Command And Check Result As Strings ${command} ${expected_result}
Examples: tc extra_options expected_result --
... 1 --verbose OK: All stack members are ok ${\n}checking stack member 'Anonymized 238'${\n}${SPACE}${SPACE}${SPACE}${SPACE}role: active [state: standby]${\n}${SPACE}${SPACE}${SPACE}${SPACE}port '1' operational status: up [admin status: enabled]${\n}${SPACE}${SPACE}${SPACE}${SPACE}port '2' operational status: up [admin status: enabled]${\n}checking stack member 'Anonymized 239'${\n}${SPACE}${SPACE}${SPACE}${SPACE}role: notReady [state: commander]${\n}${SPACE}${SPACE}${SPACE}${SPACE}port '1' operational status: up [admin status: enabled]${\n}${SPACE}${SPACE}${SPACE}${SPACE}port '2' operational status: up [admin status: enabled]
... 2 --unknown-member-status='${PERCENT}\\{role\\} ne "notReady"' UNKNOWN: Stack member 'Anonymized 238' role: active [state: standby]
... 3 --warning-member-status='${PERCENT}\\{state\\} ne "down"' WARNING: Stack member 'Anonymized 238' role: active [state: standby] - Stack member 'Anonymized 239' role: notReady [state: commander]
... 4 --critical-member-status='${PERCENT}\\{role\\} eq ${PERCENT}\\{roleLast\\}' CRITICAL: Stack member 'Anonymized 238' role: active [state: standby] - Stack member 'Anonymized 239' role: notReady [state: commander]
... 5 --unknown-port-status='${PERCENT}\\{oper_status\\} eq "up"' UNKNOWN: Stack member 'Anonymized 238' port '1' operational status: up [admin status: enabled] - port '2' operational status: up [admin status: enabled] - Stack member 'Anonymized 239' port '1' operational status: up [admin status: enabled] - port '2' operational status: up [admin status: enabled]
... 6 --warning-port-status='${PERCENT}\\{oper_status\\} eq "up"' WARNING: Stack member 'Anonymized 238' port '1' operational status: up [admin status: enabled] - port '2' operational status: up [admin status: enabled] - Stack member 'Anonymized 239' port '1' operational status: up [admin status: enabled] - port '2' operational status: up [admin status: enabled]
... 7 --critical-port-status='${PERCENT}\\{oper_status\\} eq "up" and ${PERCENT}\\{display\\} ne "up"' CRITICAL: Stack member 'Anonymized 238' port '1' operational status: up [admin status: enabled] - port '2' operational status: up [admin status: enabled] - Stack member 'Anonymized 239' port '1' operational status: up [admin status: enabled] - port '2' operational status: up [admin status: enabled]

View File

@ -18,6 +18,7 @@ ${PERCENT} %
*** Keywords ***
Start Mockoon
[Arguments] ${MOCKOON_JSON}
Ctn Generic Suite Setup
${process} Start Process
... mockoon-cli
... start

View File

@ -188,6 +188,7 @@ powershell.exe
PPID
prct
Primera
Procurve
proto
--proxyurl
psu