tyler.durden
/
centreon-plugins
mirror of https://github.com/centreon/centreon-plugins.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

optimize call dell me4

This commit is contained in:
garnier-quentin 2020-02-03 11:41:55 +01:00
parent 90a724c3f6
commit 093ecd88e4
2 changed files with 47 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
storage/dell/me4/restapi/custom/api.pm
View File

@ -57,7 +57,8 @@ sub new {
$self->{mode} = $options{mode};
$self->{http} = centreon::plugins::http->new(%options);
$self->{cache} = centreon::plugins::statefile->new(%options);
$self->{set_lang} = 0;
return $self;
}
@ -195,25 +196,23 @@ sub request_api {
}
$self->settings();
my $lang = $self->{http}->request(method => 'GET', url_path => '/api/set/cli-parameters/locale/English');
$self->{output}->output_add(long_msg => "URL: '" . $self->{proto} . '://' . $self->{hostname} . ':' . $self->{port} .
$options{url_path} . "'", debug => 1);
if ($self->{set_lang} == 0) {
$self->{http}->request(method => 'GET', url_path => '/api/set/cli-parameters/locale/English');
$self->{set_lang} = 1;
}
my $content = $self->{http}->request(%options);
if (!defined($content) || $content eq '') {
$self->{output}->add_option_msg(short_msg => "API returns empty content [code: '" . $self->{http}->get_code() . "'] [message: '" . $self->{http}->get_message() . "']");
$self->{output}->option_exit();
}
my $decoded;
eval {
$decoded = JSON::XS->new->utf8->decode($content);
};
if ($@) {
$self->{output}->output_add(long_msg => $content, debug => 1);
$self->{output}->add_option_msg(short_msg => "Cannot decode response (add --debug option to display returned content)");
$self->{output}->option_exit();
}

52
storage/dell/me4/restapi/mode/components/disk.pm
View File

@ -44,31 +44,59 @@ sub check {
$self->{components}->{disk}->{total}++;
$self->{output}->output_add(long_msg => sprintf("Disk '%s' status is '%s', health is '%s', state is '%s' [instance = %s] [temperature = %s C]",
$result->{'serial-number'}, $result->{status}, $result->{health}, $result->{state}, $instance,
$result->{'temperature-numeric'}));
$self->{output}->output_add(
long_msg => sprintf(
"Disk '%s' status is '%s', health is '%s', state is '%s' [instance = %s] [temperature = %s C]",
$result->{'serial-number'}, $result->{status}, $result->{health}, $result->{state}, $instance,
$result->{'temperature-numeric'}
)
);
my $exit1 = $self->get_severity(section => 'disk', value => $result->{status});
if (!$self->{output}->is_status(value => $exit1, compare => 'ok', litteral => 1)) {
$self->{output}->output_add(severity => $exit1,
short_msg => sprintf("Disk '%s' status is '%s'", $result->{'serial-number'}, $result->{status}));
$self->{output}->output_add(
severity => $exit1,
short_msg => sprintf(
"Disk '%s' status is '%s'",
$result->{'serial-number'},
$result->{status}
)
);
}
my $exit2 = $self->get_severity(section => 'disk', value => $result->{health});
if (!$self->{output}->is_status(value => $exit2, compare => 'ok', litteral => 1)) {
$self->{output}->output_add(severity => $exit2,
short_msg => sprintf("Disk '%s' health is '%s'", $result->{'serial-number'}, $result->{health}));
$self->{output}->output_add(
severity => $exit2,
short_msg => sprintf(
"Disk '%s' health is '%s'",
$result->{'serial-number'},
$result->{health}
)
);
}
my $exit3 = $self->get_severity(section => 'disk', value => $result->{state});
if (!$self->{output}->is_status(value => $exit3, compare => 'ok', litteral => 1)) {
$self->{output}->output_add(severity => $exit3,
short_msg => sprintf("Disk '%s' state is '%s'", $result->{'serial-number'}, $result->{state}));
$self->{output}->output_add(
severity => $exit3,
short_msg => sprintf(
"Disk '%s' state is '%s'",
$result->{'serial-number'},
$result->{state}
)
);
}
next if ($result->{'temperature-numeric'} !~ /[0-9]/);
my ($exit4, $warn, $crit, $checked) = $self->get_severity_numeric(section => 'disk', instance => $instance, value => $result->{'temperature-numeric'});
if (!$self->{output}->is_status(value => $exit4, compare => 'ok', litteral => 1)) {
$self->{output}->output_add(severity => $exit4,
short_msg => sprintf("Disk '%s' temperature is %s C", $result->{'serial-number'}, $result->{'temperature-numeric'}));
$self->{output}->output_add(
severity => $exit4,
short_msg => sprintf(
"Disk '%s' temperature is %s C",
$result->{'serial-number'},
$result->{'temperature-numeric'}
)
);
}
$self->{output}->perfdata_add(
label => 'temperature', unit => 'C',