From 0945d5374aa431cb656e5804f56a2b841a4fd728 Mon Sep 17 00:00:00 2001
From: garnier-quentin <garnier.quentin@gmail.com>
Date: Fri, 29 Jan 2021 16:44:30 +0100
Subject: [PATCH] fix hp vc hardware unitialized value

---
 .../vc/snmp/mode/components/physicalserver.pm | 29 ++++++++++++-------
 .../network/hp/vc/snmp/mode/hardware.pm       |  6 ++--
 2 files changed, 21 insertions(+), 14 deletions(-)

diff --git a/centreon-plugins/network/hp/vc/snmp/mode/components/physicalserver.pm b/centreon-plugins/network/hp/vc/snmp/mode/components/physicalserver.pm
index 53eb2720f..59cd2e83c 100644
--- a/centreon-plugins/network/hp/vc/snmp/mode/components/physicalserver.pm
+++ b/centreon-plugins/network/hp/vc/snmp/mode/components/physicalserver.pm
@@ -26,19 +26,19 @@ use network::hp::vc::snmp::mode::components::resources qw($map_managed_status $m
 
 my $mapping = {
     vcPhysicalServerManagedStatus => { oid => '.1.3.6.1.4.1.11.5.7.5.2.1.1.5.1.1.3', map => $map_managed_status },
-    vcPhysicalServerReasonCode => { oid => '.1.3.6.1.4.1.11.5.7.5.2.1.1.5.1.1.10', map => $map_reason_code },
+    vcPhysicalServerReasonCode => { oid => '.1.3.6.1.4.1.11.5.7.5.2.1.1.5.1.1.10', map => $map_reason_code }
 };
 my $oid_vcPhysicalServerEntry = '.1.3.6.1.4.1.11.5.7.5.2.1.1.5.1.1';
 
 sub load {
     my ($self) = @_;
-    
+
     push @{$self->{request}}, { oid => $oid_vcPhysicalServerEntry };
 }
 
 sub check {
     my ($self) = @_;
-    
+
     $self->{output}->output_add(long_msg => "Checking physical servers");
     $self->{components}->{physicalserver} = { name => 'physical servers', total => 0, skip => 0 };
     return if ($self->check_filter(section => 'physicalserver'));
@@ -51,17 +51,24 @@ sub check {
         next if ($self->check_filter(section => 'physicalserver', instance => $instance));
         $self->{components}->{physicalserver}->{total}++;
 
-        $self->{output}->output_add(long_msg => sprintf("physical server '%s' status is '%s' [instance: %s, reason: %s].",
-                                    $instance, $result->{vcPhysicalServerManagedStatus},
-                                    $instance, $result->{vcPhysicalServerReasonCode}
-                                    ));
+        $self->{output}->output_add(
+            long_msg => sprintf(
+                "physical server '%s' status is '%s' [instance: %s, reason: %s].",
+                $instance, $result->{vcPhysicalServerManagedStatus},
+                $instance, $result->{vcPhysicalServerReasonCode}
+            )
+        );
         my $exit = $self->get_severity(section => 'physicalserver', label => 'default', value => $result->{vcPhysicalServerManagedStatus});
         if (!$self->{output}->is_status(value => $exit, compare => 'ok', litteral => 1)) {
-            $self->{output}->output_add(severity =>  $exit,
-                                        short_msg => sprintf("Physical server '%s' status is '%s'",
-                                                             $result->{vcModuleProductName}, $result->{vcPhysicalServerManagedStatus}));
+            $self->{output}->output_add(
+                severity =>  $exit,
+                short_msg => sprintf(
+                    "Physical server '%s' status is '%s'",
+                    $instance, $result->{vcPhysicalServerManagedStatus}
+                )
+            );
         }
     }
 }
 
-1;
\ No newline at end of file
+1;
diff --git a/centreon-plugins/network/hp/vc/snmp/mode/hardware.pm b/centreon-plugins/network/hp/vc/snmp/mode/hardware.pm
index 254f4e860..6a54b1c76 100644
--- a/centreon-plugins/network/hp/vc/snmp/mode/hardware.pm
+++ b/centreon-plugins/network/hp/vc/snmp/mode/hardware.pm
@@ -39,16 +39,16 @@ sub set_system {
             ['major', 'CRITICAL'],
             ['critical', 'CRITICAL'],
             ['disabled', 'OK'],
-            ['info', 'OK'],
+            ['info', 'OK']
         ],
         'moduleport.loop' => [
             ['ok', 'OK'],
-            ['loop-detected', 'CRITICAL'],
+            ['loop-detected', 'CRITICAL']
         ],
         'moduleport.protection' => [
             ['ok', 'OK'],
             ['pause-flood-detected', 'CRITICAL'],
-            ['in-pause-condition', 'WARNING'],
+            ['in-pause-condition', 'WARNING']
         ],
     };