From 14b098cb439e6ac4c3f8cb28abfc2d980b4f76d4 Mon Sep 17 00:00:00 2001
From: Kevin Duret <kduret@centreon.com>
Date: Mon, 9 Dec 2024 10:43:54 +0100
Subject: [PATCH] enh(ci): keep packages cache during plugins testing (#5321)

---
 .../docker/testing/Dockerfile.testing-plugins-bookworm |  4 ++++
 .../docker/testing/Dockerfile.testing-plugins-bullseye |  4 ++++
 .../docker/testing/Dockerfile.testing-plugins-jammy    |  4 ++++
 .github/scripts/test-all-plugins.py                    |  8 ++++----
 .github/workflows/docker-builder-testing-plugins.yml   | 10 +++++-----
 5 files changed, 21 insertions(+), 9 deletions(-)

diff --git a/.github/docker/testing/Dockerfile.testing-plugins-bookworm b/.github/docker/testing/Dockerfile.testing-plugins-bookworm
index 95ae97a30..4a7b86861 100644
--- a/.github/docker/testing/Dockerfile.testing-plugins-bookworm
+++ b/.github/docker/testing/Dockerfile.testing-plugins-bookworm
@@ -18,6 +18,10 @@ EOF
 ENV LANG en_US.utf8
 
 RUN bash -e <<EOF
+
+# Avoid apt to clean packages cache directory
+rm -f /etc/apt/apt.conf.d/docker-clean
+
 apt-get update
 # Install Robotframework
 apt-get install -y python3-dev python3-pip
diff --git a/.github/docker/testing/Dockerfile.testing-plugins-bullseye b/.github/docker/testing/Dockerfile.testing-plugins-bullseye
index 982506b7d..7029976fb 100644
--- a/.github/docker/testing/Dockerfile.testing-plugins-bullseye
+++ b/.github/docker/testing/Dockerfile.testing-plugins-bullseye
@@ -18,6 +18,10 @@ EOF
 ENV LANG en_US.utf8
 
 RUN bash -e <<EOF
+
+# Avoid apt to clean packages cache directory
+rm -f /etc/apt/apt.conf.d/docker-clean
+
 apt-get update
 # Install Robotframework
 apt-get install -y python3 python3-dev python3-pip
diff --git a/.github/docker/testing/Dockerfile.testing-plugins-jammy b/.github/docker/testing/Dockerfile.testing-plugins-jammy
index eb2a5920d..54a819ffa 100644
--- a/.github/docker/testing/Dockerfile.testing-plugins-jammy
+++ b/.github/docker/testing/Dockerfile.testing-plugins-jammy
@@ -18,6 +18,10 @@ EOF
 ENV LANG en_US.utf8
 
 RUN bash -e <<EOF
+
+# Avoid apt to clean packages cache directory
+rm -f /etc/apt/apt.conf.d/docker-clean
+
 apt-get update
 # Install Robotframework
 apt-get install -y python3 python3-dev python3-pip
diff --git a/.github/scripts/test-all-plugins.py b/.github/scripts/test-all-plugins.py
index 9fb7f6fda..5596964d9 100644
--- a/.github/scripts/test-all-plugins.py
+++ b/.github/scripts/test-all-plugins.py
@@ -74,8 +74,8 @@ def install_plugin(plugin, archi):
                     "apt-get install -o 'Binary::apt::APT::Keep-Downloaded-Packages=1;' -y ./" + plugin.lower() + "*.deb",
                 shell=True, check=False, stderr=subprocess.STDOUT, stdout=outfile)).returncode
         elif archi == "rpm":
-            outfile.write("dnf install -y ./" + plugin + "*.rpm\n")
-            output_status = (subprocess.run("dnf install -y ./" + plugin + "*.rpm", shell=True, check=False,
+            outfile.write("dnf install --setopt=keepcache=True -y ./" + plugin + "*.rpm\n")
+            output_status = (subprocess.run("dnf install --setopt=keepcache=True -y ./" + plugin + "*.rpm", shell=True, check=False,
                                         stderr=subprocess.STDOUT, stdout=outfile)).returncode
         else:
             print(f"Unknown architecture, expected deb or rpm, got {archi}. Exiting.")
@@ -95,8 +95,8 @@ def remove_plugin(plugin, archi):
             # 'autoremove', contrary to 'remove' all dependancy while removing the original package.
 
         elif archi == "rpm":
-            outfile.write("dnf remove -y " + plugin + "\n")
-            output_status = (subprocess.run("dnf remove -y " + plugin, shell=True, check=False,
+            outfile.write("dnf remove --setopt=keepcache=True -y " + plugin + "\n")
+            output_status = (subprocess.run("dnf remove --setopt=keepcache=True -y " + plugin, shell=True, check=False,
                                             stderr=subprocess.STDOUT, stdout=outfile)).returncode
         else:
             print(f"Unknown architecture, expected deb or rpm, got {archi}. Exiting.")
diff --git a/.github/workflows/docker-builder-testing-plugins.yml b/.github/workflows/docker-builder-testing-plugins.yml
index 99c9105e8..07ea371bb 100644
--- a/.github/workflows/docker-builder-testing-plugins.yml
+++ b/.github/workflows/docker-builder-testing-plugins.yml
@@ -23,22 +23,22 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - runner: ubuntu-22.04
+          - runner: ubuntu-24.04
             dockerfile: alma8
             image: alma8
-          - runner: ubuntu-22.04
+          - runner: ubuntu-24.04
             dockerfile: alma9
             image: alma9
-          - runner: ubuntu-22.04
+          - runner: ubuntu-24.04
             dockerfile: bullseye
             image: bullseye
           - runner: ["self-hosted", "collect-arm64"]
             dockerfile: bullseye
             image: bullseye-arm64
-          - runner: ubuntu-22.04
+          - runner: ubuntu-24.04
             dockerfile: bookworm
             image: bookworm
-          - runner: ubuntu-22.04
+          - runner: ubuntu-24.04
             dockerfile: jammy
             image: jammy