(plugin) storage::dell::powerstore::restapi - add memory mode (#4214)

src/storage/dell/powerstore/restapi/custom/api.pm

@@ -133,7 +133,7 @@ sub get_port {
     return $self->{port};
 }
 
-sub get_metrics_by_clusters {
+sub get_performance_metrics_by_clusters {
     my ($self, %options) = @_;
 
     my $clusters = $self->request_api(endpoint => '/api/rest/cluster');
@@ -160,6 +160,33 @@ sub get_metrics_by_clusters {
     return $results;
 }
 
+sub get_space_metrics_by_appliance {
+    my ($self, %options) = @_;
+
+    my $appliances = $self->request_api(endpoint => '/api/rest/appliance');
+
+    my $results = {};
+    foreach (@$appliances) {
+        my $post_json = JSON::XS->new->utf8->encode(
+            {
+                entity => 'space_metrics_by_appliance',
+                entity_id => $_->{id},
+                interval => 'Five_Mins'
+            }
+        );
+
+        my $perfs = $self->request_api(
+            method => 'POST',
+            endpoint => '/api/rest/metrics/generate',
+            headers => ['Content-Type: application/json'],
+            query_form_post => $post_json
+        );
+        $results->{ $_->{id} } = $perfs;
+    }
+
+    return $results;
+}
+
 sub request_api {
     my ($self, %options) = @_;
 

src/storage/dell/powerstore/restapi/mode/clusters.pm

@@ -170,7 +170,7 @@ sub new {
 sub manage_selection {
     my ($self, %options) = @_;
 
-    my $clusters = $options{custom}->get_metrics_by_clusters();
+    my $clusters = $options{custom}->get_performance_metrics_by_clusters();
 
     $self->{global} = { detected => 0 };
     $self->{clusters} = {};

src/storage/dell/powerstore/restapi/mode/memory.pm

@@ -0,0 +1,136 @@
+#
+# Copyright 2023 Centreon (http://www.centreon.com/)
+#
+# Centreon is a full-fledged industry-strength solution that meets
+# the needs in IT infrastructure and application monitoring for
+# service performance.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+package storage::dell::powerstore::restapi::mode::memory;
+
+use base qw(centreon::plugins::templates::counter);
+
+use strict;
+use warnings;
+
+sub custom_usage_output {
+    my ($self, %options) = @_;
+
+    return sprintf(
+        'memory total: %s %s used: %s %s (%.2f%%) free: %s %s (%.2f%%)',
+        $self->{perfdata}->change_bytes(value => $self->{result_values}->{total}),
+        $self->{perfdata}->change_bytes(value => $self->{result_values}->{used}),
+        $self->{result_values}->{prct_used},
+        $self->{perfdata}->change_bytes(value => $self->{result_values}->{free}),
+        $self->{result_values}->{prct_free}
+    );
+}
+
+sub prefix_appliance_output {
+    my ($self, %options) = @_;
+
+    return "Appliance '" . $options{instance} . "' ";
+}
+
+sub set_counters {
+    my ($self, %options) = @_;
+
+    $self->{maps_counters_type} = [
+        { name => 'memory', type => 1, cb_prefix_output => 'prefix_appliance_output', message_multiple => 'All appliances memory usage are ok' },
+    ];
+
+    $self->{maps_counters}->{memory} = [
+        { label => 'usage', nlabel => 'memory.usage.bytes', set => {
+                key_values => [ { name => 'used' }, { name => 'free' }, { name => 'prct_used' }, { name => 'prct_free' }, { name => 'total' } ],
+                closure_custom_output => $self->can('custom_usage_output'),
+                perfdatas => [
+                    { template => '%d', min => 0, max => 'total', unit => 'B', cast_int => 1, label_extra_instance => 1 }
+                ]
+            }
+        },
+        { label => 'usage-free', display_ok => 0, nlabel => 'memory.free.bytes', set => {
+                key_values => [ { name => 'free' }, { name => 'used' }, { name => 'prct_used' }, { name => 'prct_free' }, { name => 'total' } ],
+                closure_custom_output => $self->can('custom_usage_output'),
+                perfdatas => [
+                    { template => '%d', min => 0, max => 'total', unit => 'B', cast_int => 1, label_extra_instance => 1 }
+                ]
+            }
+        },
+        { label => 'usage-prct', display_ok => 0, nlabel => 'memory.usage.percentage', set => {
+                key_values => [ { name => 'prct_used' }, { name => 'used' }, { name => 'free' }, { name => 'prct_free' }, { name => 'total' } ],
+                closure_custom_output => $self->can('custom_usage_output'),
+                perfdatas => [
+                    { template => '%.2f', min => 0, max => 100, unit => '%', label_extra_instance => 1 }
+                ]
+            }
+        }
+    ];
+}
+
+sub new {
+    my ($class, %options) = @_;
+    my $self = $class->SUPER::new(package => __PACKAGE__, %options, force_new_perfdata => 1);
+    bless $self, $class;
+
+    $options{options}->add_options(arguments => {
+        'filter-appliance-id:s' => { name => 'filter_appliance_id' }
+    });
+
+    return $self;
+}
+
+sub manage_selection {
+    my ($self, %options) = @_;
+
+    my $appliances = $options{custom}->get_space_metrics_by_appliance();
+
+    $self->{memory} = {};
+    foreach my $appliance_id (keys %$appliances) {
+        next if (defined($self->{option_results}->{filter_appliance_id}) && $self->{option_results}->{filter_appliance_id} ne '' &&
+            $appliance_id !~ /$self->{option_results}->{filter_appliance_id}/);
+
+        my $free = $appliances->{$appliance_id}->{last_physical_total} - $appliances->{$appliance_id}->{last_physical_used};
+        $self->{memory}->{ $appliance_id } = {
+            total => $appliances->{$appliance_id}->{last_physical_total},
+            used => $appliances->{$appliance_id}->{last_physical_used},
+            free => $free,
+            prct_used => $appliances->{$appliance_id}->{last_physical_used} * 100 / $appliances->{$appliance_id}->{last_physical_total},
+            prct_free => $free * 100 / $appliances->{$appliance_id}->{last_physical_total}
+        };
+    }
+}
+
+1;
+
+__END__
+
+=head1 MODE
+
+Check appliances memory usage.
+
+=over 8
+
+=item B<--filter-appliance-id>
+
+Filter appliance ID.
+
+=item B<--warning-*> B<--critical-*>
+
+Thresholds.
+Can be: 'usage' (B), 'usage-free' (B), 'usage-prct' (%).
+
+=back
+
+=cut

src/storage/dell/powerstore/restapi/plugin.pm

@@ -32,7 +32,8 @@ sub new {
     $self->{modes} = {
         'alerts'   => 'storage::dell::powerstore::restapi::mode::alerts',
         'clusters' => 'storage::dell::powerstore::restapi::mode::clusters',
-        'hardware' => 'storage::dell::powerstore::restapi::mode::hardware'
+        'hardware' => 'storage::dell::powerstore::restapi::mode::hardware',
+        'memory'   => 'storage::dell::powerstore::restapi::mode::memory'
     };
 
     $self->{custom_modes}->{api} = 'storage::dell::powerstore::restapi::custom::api';