(plugin) network::dlink::standard::snmp - mode hardware unitialized speed value (#3539)

This commit is contained in:
qgarnier 2022-03-10 15:16:34 +01:00 committed by GitHub
parent 4b09db9991
commit 245ae670d1

View File

@ -53,7 +53,7 @@ my $oid_esEntityExtEnvFanEntry = '.1.3.6.1.4.1.171.17.5.1.1.2.1';
sub load { sub load {
my ($self) = @_; my ($self) = @_;
push @{$self->{request}}, push @{$self->{request}},
{ oid => $oid_swFanEntry, start => $mapping_equipment->{swFanStatus}->{oid} }, { oid => $oid_swFanEntry, start => $mapping_equipment->{swFanStatus}->{oid} },
{ oid => $oid_dEntityExtEnvFanEntry, start => $mapping_industrial->{description}->{oid} }, { oid => $oid_dEntityExtEnvFanEntry, start => $mapping_industrial->{description}->{oid} },
@ -80,7 +80,7 @@ sub check_fan_equipment {
$description, $description,
$result->{swFanStatus}, $result->{swFanStatus},
$instance, $instance,
$result->{swFanSpeed} defined($result->{swFanSpeed}) ? $result->{swFanSpeed} : '-'
) )
); );
my $exit = $self->get_severity(section => 'fan', value => $result->{swFanStatus}); my $exit = $self->get_severity(section => 'fan', value => $result->{swFanStatus});
@ -93,29 +93,29 @@ sub check_fan_equipment {
) )
); );
} }
if (defined($result->{swFanSpeed})) { next if (!defined($result->{swFanSpeed}));
my ($exit2, $warn, $crit, $checked) = $self->get_severity_numeric(section => 'fan', instance => $instance, value => $result->{swFanSpeed});
if (!$self->{output}->is_status(value => $exit2, compare => 'ok', litteral => 1)) { my ($exit2, $warn, $crit, $checked) = $self->get_severity_numeric(section => 'fan', instance => $instance, value => $result->{swFanSpeed});
$self->{output}->output_add( if (!$self->{output}->is_status(value => $exit2, compare => 'ok', litteral => 1)) {
severity => $exit2, $self->{output}->output_add(
short_msg => sprintf( severity => $exit2,
"fan '%s' speed is %s rpm", short_msg => sprintf(
$description, "fan '%s' speed is %s rpm",
$result->{swFanSpeed} $description,
) $result->{swFanSpeed}
); )
}
$self->{output}->perfdata_add(
unit => 'rpm',
nlabel => 'hardware.fan.speed.rpm',
instances => ['unit' . $unit_id, 'fan' . $fan_id],
value => $result->{swFanSpeed},
warning => $warn,
critical => $crit,
min => 0
); );
} }
$self->{output}->perfdata_add(
unit => 'rpm',
nlabel => 'hardware.fan.speed.rpm',
instances => ['unit' . $unit_id, 'fan' . $fan_id],
value => $result->{swFanSpeed},
warning => $warn,
critical => $crit,
min => 0
);
} }
} }