tyler.durden/centreon-plugins
1
0
Fork 0
mirror of https://github.com/centreon/centreon-plugins.git synced 2025-07-31 01:24:35 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(netapp-restapi): Fix wrong volumes calculation

Browse Source 
Fix wrong volumes usage calculation and add
snapshot metrics

Refs:CTOR-1439
This commit is contained in:
itoussies@centreon.com 2025-02-20 10:05:50 +01:00
parent 2c868ab9dd
commit 247f65d52b
1 changed files with 53 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

57
src/storage/netapp/ontap/restapi/mode/volumes.pm
View File

@ -60,6 +60,20 @@ sub custom_logical_usage_output {
);
}
sub custom_snapshot_usage_output {
my ($self, %options) = @_;
my ($total_size_value, $total_size_unit) = $self->{perfdata}->change_bytes(value => $self->{result_values}->{total_snapshot_space});
my ($total_used_value, $total_used_unit) = $self->{perfdata}->change_bytes(value => $self->{result_values}->{snapshot_used_space});
my ($total_free_value, $total_free_unit) = $self->{perfdata}->change_bytes(value => $self->{result_values}->{snapshot_free_space});
return sprintf(
'snapshot reserved size: %s used: %s (%.2f%%) reserve available: %s (%.2f%%)',
$total_size_value . " " . $total_size_unit,
$total_used_value . " " . $total_used_unit, $self->{result_values}->{snapshot_prct_used_space},
$total_free_value . " " . $total_free_unit, $self->{result_values}->{snapshot_prct_free_space}
);
}
sub prefix_volume_output {
my ($self, %options) = @_;
@ -135,6 +149,33 @@ sub set_counters {
]
}
},
{ label => 'snapshot-usage', nlabel => 'volume.space.snapshot.usage.bytes', set => {
key_values => [ { name => 'snapshot_used_space' }, { name => 'snapshot_free_space' }, { name => 'snapshot_prct_used_space' }, { name => 'snapshot_prct_free_space' }, { name => 'total_snapshot_space' }, { name => 'display' }, ],
closure_custom_output => $self->can('custom_snapshot_usage_output'),
perfdatas => [
{ template => '%d', min => 0, max => 'total_snapshot_space',
unit => 'B', cast_int => 1, label_extra_instance => 1 }
]
}
},
{ label => 'snapshot-usage-free', nlabel => 'volume.space.snapshot.free.bytes', display_ok => 0, set => {
key_values => [ { name => 'snapshot_free_space' }, { name => 'snapshot_used_space' }, { name => 'snapshot_prct_used_space' }, { name => 'snapshot_prct_free_space' }, { name => 'total_snapshot_space' }, { name => 'display' }, ],
closure_custom_output => $self->can('custom_snapshot_usage_output'),
perfdatas => [
{ template => '%d', min => 0, max => 'total_snapshot_space',
unit => 'B', cast_int => 1, label_extra_instance => 1 }
]
}
},
{ label => 'snapshot-usage-prct', nlabel => 'volume.space.snapshot.usage.percentage', display_ok => 0, set => {
key_values => [ { name => 'snapshot_prct_used_space' }, { name => 'snapshot_used_space' }, { name => 'snapshot_free_space' }, { name => 'snapshot_prct_free_space' }, { name => 'total_snapshot_space' }, { name => 'display' }, ],
closure_custom_output => $self->can('custom_snapshot_usage_output'),
perfdatas => [
{ template => '%.2f', min => 0, max => 100,
unit => '%', label_extra_instance => 1 }
]
}
},
{ label => 'read', nlabel => 'volume.io.read.usage.bytespersecond', display_ok => 0, set => {
key_values => [ { name => 'read' } ],
output_template => 'read: %s %s/s',
@ -283,11 +324,11 @@ sub manage_selection {
display => $name,
state => $_->{state},
total_space => $_->{space}->{size},
used_space => $_->{space}->{used},
total_space => $_->{space}->{afs_total},
used_space => $_->{space}->{used_by_afs},
free_space => $_->{space}->{available},
prct_used_space => (defined($_->{space}->{size}) && $_->{space}->{size} > 0) ? (($_->{space}->{size} - $_->{space}->{available}) * 100 / $_->{space}->{size}) : undef,
prct_free_space => (defined($_->{space}->{size}) && $_->{space}->{size} > 0) ? $_->{space}->{available} * 100 / $_->{space}->{size} : undef,
prct_used_space => (defined($_->{space}->{afs_total}) && $_->{space}->{afs_total} > 0) ? (($_->{space}->{afs_total} - $_->{space}->{available}) * 100 / $_->{space}->{afs_total}) : undef,
prct_free_space => (defined($_->{space}->{afs_total}) && $_->{space}->{afs_total} > 0) ? $_->{space}->{available} * 100 / $_->{space}->{afs_total} : undef,
read => $_->{metric}->{throughput}->{read},
write => $_->{metric}->{throughput}->{write},
@ -303,6 +344,14 @@ sub manage_selection {
total_latency => (defined($_->{metric}->{latency}->{total})) ? ($_->{metric}->{latency}->{total} / 1000) : undef,
};
if (defined($_->{space}->{snapshot})) {
$self->{volumes}->{$name}->{total_snapshot_space} = $_->{space}->{snapshot}->{reserve_size};
$self->{volumes}->{$name}->{snapshot_used_space} = $_->{space}->{snapshot}->{used};
$self->{volumes}->{$name}->{snapshot_free_space} = $_->{space}->{snapshot}->{reserve_available};
$self->{volumes}->{$name}->{snapshot_prct_used_space} = $_->{space}->{snapshot}->{space_used_percent};
$self->{volumes}->{$name}->{snapshot_prct_free_space} = 100 - $_->{space}->{snapshot}->{space_used_percent};
}
if (defined($_->{space}->{logical_space})) {
$self->{volumes}->{$name}->{total_logical_space} = $_->{space}->{logical_space}->{used} + $_->{space}->{logical_space}->{available};
$self->{volumes}->{$name}->{logical_used_space} = $_->{space}->{logical_space}->{used};