tyler.durden/centreon-plugins
1
0
Fork 0
mirror of https://github.com/centreon/centreon-plugins.git synced 2025-07-27 15:44:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

+ minor optimizations

Browse Source 
++ enhance error management when filter by SSID
++ reduce snmp query scope
This commit is contained in:
Sims24 2016-07-20 15:48:50 +02:00 committed by GitHub
parent 793eb710fa
commit 30ecfc7c04
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
centreon-plugins/network/aerohive/snmp/mode/connectedusers.pm
View File

@ -76,7 +76,6 @@ sub new {
return $self; return $self;
} }
my $oid_ahXIfEntry = '.1.3.6.1.4.1.26928.1.1.1.2.1.1.1';
my $oid_ahSSIDNAME = '.1.3.6.1.4.1.26928.1.1.1.2.1.1.1.2'; my $oid_ahSSIDNAME = '.1.3.6.1.4.1.26928.1.1.1.2.1.1.1.2';
my $oid_ahClientSSID = '.1.3.6.1.4.1.26928.1.1.1.2.1.2.1.10'; my $oid_ahClientSSID = '.1.3.6.1.4.1.26928.1.1.1.2.1.2.1.10';
@ -86,13 +85,12 @@ sub manage_selection {
$self->{global} = { total => 0 }; $self->{global} = { total => 0 };
$self->{ssid} = {}; $self->{ssid} = {};
$self->{results} = $options{snmp}->get_multiple_table(oids => [ { oid => $oid_ahXIfEntry }, $self->{results} = $options{snmp}->get_multiple_table(oids => [ { oid => $oid_ahSSIDNAME },
{ oid => $oid_ahClientSSID }, { oid => $oid_ahClientSSID },
], ],
nothing_quit => 1); nothing_quit => 1);
foreach my $oid (keys %{$self->{results}->{ $oid_ahXIfEntry }}) { foreach my $oid (keys %{$self->{results}->{ $oid_ahXIfEntry }}) {
next if $oid !~ /^$oid_ahSSIDNAME\.(.*)$/;
my $ssid = $self->{results}->{ $oid_ahXIfEntry }->{$oid}; my $ssid = $self->{results}->{ $oid_ahXIfEntry }->{$oid};
if (defined($self->{option_results}->{filter_ssid}) && $self->{option_results}->{filter_ssid} ne '' && if (defined($self->{option_results}->{filter_ssid}) && $self->{option_results}->{filter_ssid} ne '' &&
$ssid !~ /$self->{option_results}->{filter_ssid}/) { $ssid !~ /$self->{option_results}->{filter_ssid}/) {
@ -105,7 +103,7 @@ sub manage_selection {
foreach my $oid (keys %{$self->{results}->{ $oid_ahClientSSID }}) { foreach my $oid (keys %{$self->{results}->{ $oid_ahClientSSID }}) {
$self->{global}->{total}++; $self->{global}->{total}++;
my $ssid = $self->{results}->{ $oid_ahClientSSID }->{$oid}; my $ssid = $self->{results}->{ $oid_ahClientSSID }->{$oid};
$self->{ssid}->{$ssid}->{total}++; $self->{ssid}->{$ssid}->{total}++ if defined($self->{ssid}->{$ssid});
} }
} }