fix(cisco-wlc): fixed wrong unit for roundtrip time for radius auth servers (#5277)

Co-authored-by: Lucie Dubrunfaut <123162035+lucie-dubrunfaut@users.noreply.github.com> Refs: CTOR-779
2025-07-27 07:34:35 +02:00 · 2024-11-05 17:07:13 +01:00 · 2024-11-05 17:07:13 +01:00 · 4bf196969c
commit 4bf196969c
parent 790c96d3ac
34 changed files with 108 additions and 25 deletions
--- a/src/centreon/common/airespace/snmp/mode/radiusauthservers.pm
+++ b/src/centreon/common/airespace/snmp/mode/radiusauthservers.pm
@ -52,11 +52,11 @@ sub set_counters {
    ];

    $self->{maps_counters}->{servers} = [
-        { label => 'authserver-roundtrip-time', nlabel => 'radius.authserver.roundtrip.time.milliseconds', set => {
+        { label => 'authserver-roundtrip-time', nlabel => 'radius.authserver.roundtrip.time.microseconds', set => {
                key_values => [ { name => 'round_trip_time' }, { name => 'name' } ],
-                output_template => 'round trip time: %s ms',
+                output_template => 'round trip time: %s µs',
                perfdatas => [
-                    { template => '%s', min => 0, unit => 'ms', label_extra_instance => 1, instance_use => 'name' }
+                    { template => '%s', min => 0, unit => 'µs', label_extra_instance => 1, instance_use => 'name' }
                ]
            }
        },
@ -187,11 +187,46 @@ Example: --filter-counters='^total$'

 Filter radius servers by name (can be a regexp).

-=item B<--warning-*> B<--critical-*>
+=item B<--warning-authservers-total>

 Thresholds.
-Can be: 'authservers-total', 'authserver-roundtrip-time', 'authserver-packets-access-requests',
-'authserver-packets-access-accepts', 'authserver-clients-timeout'.
+
+=item B<--critical-authservers-total>
+
+Thresholds.
+
+=item B<--warning-authserver-roundtrip-time>
+
+Thresholds.
+
+=item B<--critical-authserver-roundtrip-time>
+
+Thresholds.
+
+=item B<--warning-authserver-packets-access-requests>
+
+Thresholds.
+
+=item B<--critical-authserver-packets-access-requests>
+
+Thresholds.
+
+=item B<--warning-authserver-packets-access-accepts>
+
+Thresholds.
+
+=item B<--critical-authserver-packets-access-accepts>
+
+Thresholds.
+
+=item B<--warning-authserver-clients-timeout>
+
+Thresholds.
+
+=item B<--critical-authserver-clients-timeout>
+
+Thresholds.
+

 =back

--- a/tests/os/linux/snmp/cpu-detailed.robot
+++ b/tests/os/linux/snmp/cpu-detailed.robot
@ -3,6 +3,7 @@ Documentation       Check cpu table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/cpu.robot
+++ b/tests/os/linux/snmp/cpu.robot
@ -3,6 +3,7 @@ Documentation       Check cpu table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/disk-usage.robot
+++ b/tests/os/linux/snmp/disk-usage.robot
@ -3,6 +3,7 @@ Documentation       Check disk-usage table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/diskio.robot
+++ b/tests/os/linux/snmp/diskio.robot
@ -3,6 +3,7 @@ Documentation       Check diskio table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/inodes.robot
+++ b/tests/os/linux/snmp/inodes.robot
@ -3,6 +3,7 @@ Documentation       Check inodes table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/list-diskio.robot
+++ b/tests/os/linux/snmp/list-diskio.robot
@ -3,6 +3,7 @@ Documentation       Check the list-diskio mode

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/list-diskspath.robot
+++ b/tests/os/linux/snmp/list-diskspath.robot
@ -3,6 +3,7 @@ Documentation       Check list-diskspath table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/list-interfaces.robot
+++ b/tests/os/linux/snmp/list-interfaces.robot
@ -3,6 +3,7 @@ Documentation       Check list-interfaces table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/list-processes.robot
+++ b/tests/os/linux/snmp/list-processes.robot
@ -3,6 +3,7 @@ Documentation       Check list-processes table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/list-storages.robot
+++ b/tests/os/linux/snmp/list-storages.robot
@ -3,6 +3,7 @@ Documentation       Check list-storages table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/memory.robot
+++ b/tests/os/linux/snmp/memory.robot
@ -3,6 +3,7 @@ Documentation       Check memory table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/network-interfaces.robot
+++ b/tests/os/linux/snmp/network-interfaces.robot
@ -3,6 +3,7 @@ Documentation       Network table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/processcount.robot
+++ b/tests/os/linux/snmp/processcount.robot
@ -3,6 +3,7 @@ Documentation       Check processcount table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/storage.robot
+++ b/tests/os/linux/snmp/storage.robot
@ -3,6 +3,7 @@ Documentation       Check storage table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/swap.robot
+++ b/tests/os/linux/snmp/swap.robot
@ -3,6 +3,7 @@ Documentation       Check swap table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/linux/snmp/uptime.robot
+++ b/tests/os/linux/snmp/uptime.robot
@ -3,6 +3,7 @@ Documentation       Check uptime table

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/cpu.robot
+++ b/tests/os/windows/snmp/cpu.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/interfaces.robot
+++ b/tests/os/windows/snmp/interfaces.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/list-interfaces.robot
+++ b/tests/os/windows/snmp/list-interfaces.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/list-processes.robot
+++ b/tests/os/windows/snmp/list-processes.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/list-services.robot
+++ b/tests/os/windows/snmp/list-services.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/list-storages.robot
+++ b/tests/os/windows/snmp/list-storages.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/memory.robot
+++ b/tests/os/windows/snmp/memory.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/processcount.robot
+++ b/tests/os/windows/snmp/processcount.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/services-en.robot
+++ b/tests/os/windows/snmp/services-en.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/services-fr.robot
+++ b/tests/os/windows/snmp/services-fr.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/storage.robot
+++ b/tests/os/windows/snmp/storage.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/swap.robot
+++ b/tests/os/windows/snmp/swap.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/time.robot
+++ b/tests/os/windows/snmp/time.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/os/windows/snmp/uptime.robot
+++ b/tests/os/windows/snmp/uptime.robot
@ -3,6 +3,7 @@ Documentation       Check Windows operating systems in SNMP.

 Resource            ${CURDIR}${/}..${/}..${/}..${/}resources/import.resource

+Suite Setup         Ctn Generic Suite Setup
 Test Timeout        120s


--- a/tests/resources/resources.resource
+++ b/tests/resources/resources.resource
@ -18,6 +18,7 @@ ${PERCENT}              %
 *** Keywords ***
 Start Mockoon
    [Arguments]    ${MOCKOON_JSON}
+    Ctn Generic Suite Setup
    ${process}    Start Process
    ...    mockoon-cli
    ...    start
@ -30,6 +31,13 @@ Start Mockoon
 Stop Mockoon
    Terminate All Processes

+Ctn Cleanup Cache
+    Remove File    ${/}var${/}lib${/}centreon${/}centplugins${/}*
+    Remove File    ${/}dev${/}shm${/}*
+
+Ctn Generic Suite Setup
+   Ctn Cleanup Cache
+
 Ctn Run Command And Check Result As Strings
    [Arguments]    ${command}    ${expected_result}
    ${output}    Run    ${command}
--- a/tests/resources/spellcheck/stopwords.txt
+++ b/tests/resources/spellcheck/stopwords.txt
@ -1,4 +1,14 @@
 2c
+--warning-authservers-total
+--critical-authservers-total
+--warning-authserver-roundtrip-time
+--critical-authserver-roundtrip-time
+--warning-authserver-packets-access-requests
+--critical-authserver-packets-access-requests
+--warning-authserver-packets-access-accepts
+--critical-authserver-packets-access-accepts
+--warning-authserver-clients-timeout
+--critical-authserver-clients-timeout
 3COM
 3CX
 --3cx-version