tyler.durden/centreon-plugins
1
0
Fork 0
mirror of https://github.com/centreon/centreon-plugins.git synced 2025-07-29 00:24:46 +02:00
Code Issues Packages Projects Releases Wiki Activity

(plugin) cloud::prometheus::exporters::cadvisor - mode memory fix unitialized value (#3659)

Browse Source
This commit is contained in:
qgarnier 2022-05-13 13:59:22 +02:00 committed by GitHub
parent 7dea315a39
commit 52c769f146
1 changed files with 26 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
centreon-plugins/cloud/prometheus/exporters/cadvisor/mode/memory.pm
View File

@ -57,9 +57,13 @@ sub custom_usage_threshold {
if ($self->{instance_mode}->{option_results}->{units} eq '%') { if ($self->{instance_mode}->{option_results}->{units} eq '%') {
$threshold_value = $self->{result_values}->{prct_used}; $threshold_value = $self->{result_values}->{prct_used};
} }
$exit = $self->{perfdata}->threshold_check(value => $threshold_value, $exit = $self->{perfdata}->threshold_check(
threshold => [ { label => 'critical-' . $self->{result_values}->{thlabel}, exit_litteral => 'critical' }, value => $threshold_value,
{ label => 'warning-'. $self->{result_values}->{thlabel}, exit_litteral => 'warning' } ]); threshold => [
{ label => 'critical-' . $self->{thlabel}, exit_litteral => 'critical' },
{ label => 'warning-'. $self->{thlabel}, exit_litteral => 'warning' }
]
);
return $exit; return $exit;
} }
@ -72,9 +76,12 @@ sub custom_usage_output {
$msg = sprintf("%s: %s (unlimited)", ucfirst($self->{result_values}->{label}), $total_used_value . " " . $total_used_unit); $msg = sprintf("%s: %s (unlimited)", ucfirst($self->{result_values}->{label}), $total_used_value . " " . $total_used_unit);
} else { } else {
my ($total_size_value, $total_size_unit) = $self->{perfdata}->change_bytes(value => $self->{result_values}->{total}); my ($total_size_value, $total_size_unit) = $self->{perfdata}->change_bytes(value => $self->{result_values}->{total});
$msg = sprintf("%s: %s (%.2f%% of %s)", ucfirst($self->{result_values}->{label}), $total_used_value . " " . $total_used_unit, $msg = sprintf(
$self->{result_values}->{prct_used}, "%s: %s (%.2f%% of %s)",
$total_size_value . " " . $total_size_unit); ucfirst($self->{result_values}->{label}), $total_used_value . " " . $total_used_unit,
$self->{result_values}->{prct_used},
$total_size_value . " " . $total_size_unit
);
} }
return $msg; return $msg;
@ -102,7 +109,7 @@ sub set_counters {
$self->{maps_counters_type} = [ $self->{maps_counters_type} = [
{ name => 'containers', type => 1, cb_prefix_output => 'prefix_containers_output', { name => 'containers', type => 1, cb_prefix_output => 'prefix_containers_output',
message_multiple => 'All containers memory usage are ok' }, message_multiple => 'All containers memory usage are ok' }
]; ];
$self->{maps_counters}->{containers} = [ $self->{maps_counters}->{containers} = [
@ -123,7 +130,7 @@ sub set_counters {
closure_custom_calc_extra_options => { label_ref => 'working', perfdata_ref => 'working' }, closure_custom_calc_extra_options => { label_ref => 'working', perfdata_ref => 'working' },
closure_custom_output => $self->can('custom_usage_output'), closure_custom_output => $self->can('custom_usage_output'),
closure_custom_perfdata => $self->can('custom_usage_perfdata'), closure_custom_perfdata => $self->can('custom_usage_perfdata'),
closure_custom_threshold_check => $self->can('custom_usage_threshold'), closure_custom_threshold_check => $self->can('custom_usage_threshold')
} }
}, },
{ label => 'cache', nlabel => 'cache.usage.bytes', set => { { label => 'cache', nlabel => 'cache.usage.bytes', set => {
@ -131,9 +138,9 @@ sub set_counters {
output_template => 'Cache: %.2f %s', output_template => 'Cache: %.2f %s',
output_change_bytes => 1, output_change_bytes => 1,
perfdatas => [ perfdatas => [
{ label => 'cache', value => 'cache', template => '%s', { label => 'cache', template => '%s',
min => 0, unit => 'B', label_extra_instance => 1, instance_use => 'perf' }, min => 0, unit => 'B', label_extra_instance => 1, instance_use => 'perf' }
], ]
} }
}, },
{ label => 'rss', nlabel => 'rss.usage.bytes', set => { { label => 'rss', nlabel => 'rss.usage.bytes', set => {
@ -141,9 +148,9 @@ sub set_counters {
output_template => 'Rss: %.2f %s', output_template => 'Rss: %.2f %s',
output_change_bytes => 1, output_change_bytes => 1,
perfdatas => [ perfdatas => [
{ label => 'rss', value => 'rss', template => '%s', { label => 'rss', template => '%s',
min => 0, unit => 'B', label_extra_instance => 1, instance_use => 'perf' }, min => 0, unit => 'B', label_extra_instance => 1, instance_use => 'perf' }
], ]
} }
}, },
{ label => 'swap', nlabel => 'swap.usage.bytes', set => { { label => 'swap', nlabel => 'swap.usage.bytes', set => {
@ -151,11 +158,11 @@ sub set_counters {
output_template => 'Swap: %.2f %s', output_template => 'Swap: %.2f %s',
output_change_bytes => 1, output_change_bytes => 1,
perfdatas => [ perfdatas => [
{ label => 'swap', value => 'swap', template => '%s', { label => 'swap', template => '%s',
min => 0, unit => 'B', label_extra_instance => 1, instance_use => 'perf' }, min => 0, unit => 'B', label_extra_instance => 1, instance_use => 'perf' }
], ]
} }
}, }
]; ];
} }
@ -175,7 +182,7 @@ sub new {
"pod:s" => { name => 'pod', default => 'pod_name=~".*"' }, "pod:s" => { name => 'pod', default => 'pod_name=~".*"' },
"extra-filter:s@" => { name => 'extra_filter' }, "extra-filter:s@" => { name => 'extra_filter' },
"units:s" => { name => 'units', default => '%' }, "units:s" => { name => 'units', default => '%' },
"metric-overload:s@" => { name => 'metric_overload' }, "metric-overload:s@" => { name => 'metric_overload' }
}); });
return $self; return $self;