enh(plugin)azure vm preview memory (#3098)

* enh(plugin)azure-memory-available-preview

* enh(plugin)azure-memory-available-preview-typo

* enh(plugin)azure-memory-available-preview-simplify

* + apply Quentin`s advice

* + fix memory

* + fix compilation errors

cloud/azure/compute/virtualmachine/mode/memory.pm

@@ -0,0 +1,130 @@
+#
+# Copyright 2021 Centreon (http://www.centreon.com/)
+#
+# Centreon is a full-fledged industry-strength solution that meets
+# the needs in IT infrastructure and application monitoring for
+# service performance.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+package cloud::azure::compute::virtualmachine::mode::memory;
+
+use base qw(cloud::azure::custom::mode);
+
+use strict;
+use warnings;
+
+sub get_metrics_mapping {
+    my ($self, %options) = @_;
+
+    my $metrics_mapping = {
+        'Available Memory Bytes' => {
+            'output'  => 'Available Memory Bytes',
+            'label'   => 'memory-available',
+            'nlabel'  => 'memory.available.bytes',
+            'unit'    => 'B'
+        }
+    };
+
+    return $metrics_mapping;
+}
+
+sub new {
+    my ($class, %options) = @_;
+    my $self = $class->SUPER::new(package => __PACKAGE__, %options, force_new_perfdata => 1);
+    bless $self, $class;
+
+    $options{options}->add_options(arguments => {
+        'resource:s'       => { name => 'resource' },
+        'resource-group:s' => { name => 'resource_group' }
+    });
+
+    return $self;
+}
+
+sub check_options {
+    my ($self, %options) = @_;
+    $self->SUPER::check_options(%options);
+
+    if (!defined($self->{option_results}->{resource}) || $self->{option_results}->{resource} eq '') {
+        $self->{output}->add_option_msg(short_msg => 'Need to specify either --resource <name> with --resource-group option or --resource <id>.');
+        $self->{output}->option_exit();
+    }
+    my $resource = $self->{option_results}->{resource};
+    my $resource_group = defined($self->{option_results}->{resource_group}) ? $self->{option_results}->{resource_group} : '';
+    if ($resource =~ /^\/subscriptions\/.*\/resourceGroups\/(.*)\/providers\/Microsoft\.Compute\/virtualMachines\/(.*)$/) {
+        $resource_group = $1;
+        $resource = $2;
+    }
+
+    $self->{az_resource} = $resource;
+    $self->{az_resource_group} = $resource_group;
+    $self->{az_resource_type} = 'virtualMachines';
+    $self->{az_resource_namespace} = 'Microsoft.Compute';
+    $self->{az_timeframe} = defined($self->{option_results}->{timeframe}) ? $self->{option_results}->{timeframe} : 900;
+    $self->{az_interval} = defined($self->{option_results}->{interval}) ? $self->{option_results}->{interval} : 'PT5M';
+    $self->{az_aggregations} = ['Average'];
+    if (defined($self->{option_results}->{aggregation})) {
+        $self->{az_aggregations} = [];
+        foreach my $stat (@{$self->{option_results}->{aggregation}}) {
+            if ($stat ne '') {
+                push @{$self->{az_aggregations}}, ucfirst(lc($stat));
+            }
+        }
+    }
+
+    foreach my $metric (keys %{$self->{metrics_mapping}}) {
+        next if (defined($self->{option_results}->{filter_metric}) && $self->{option_results}->{filter_metric} ne ''
+            && $metric !~ /$self->{option_results}->{filter_metric}/);
+        push @{$self->{az_metrics}}, $metric;
+    }
+}
+
+1;
+
+__END__
+
+=head1 MODE
+
+Check Azure MS Compute Virtual Machine available memory.
+
+perl centreon_plugins.pl --plugin=cloud::azure::compute::virtualmachine::plugin --mode=memory \
+--custommode='api' --resource='***' --resource-group='***' \
+--subscription='***' --tenant='***' --client-id='***' --client-secret='**' --timeframe='900' \
+--interval='PT1M' --aggregation='average' --warning-memory-available=1024: --verbose
+
+Note that using a specific threshold syntax is required to trigger an alert when 
+the value drops below available memory "<value>:"
+
+=over 8
+
+=item B<--resource>
+
+Set resource name or id (Required).
+
+=item B<--resource-group>
+
+Set resource group (Required if resource's name is used).
+
+=item B<--warning-memory-available>
+
+Warning threshold.
+
+=item B<--critical-memory-available>
+
+Critical threshold.
+
+=back
+
+=cut

cloud/azure/compute/virtualmachine/plugin.pm

@@ -36,9 +36,10 @@ sub new {
         'diskio'            => 'cloud::azure::compute::virtualmachine::mode::diskio',
         'health'            => 'cloud::azure::compute::virtualmachine::mode::health',
         'list-resources'    => 'cloud::azure::compute::virtualmachine::mode::listresources',
+        'memory'            => 'cloud::azure::compute::virtualmachine::mode::memory',
         'network'           => 'cloud::azure::compute::virtualmachine::mode::network',
         'vm-sizes'          => 'cloud::azure::compute::virtualmachine::mode::vmsizes',
-        'vms-state'         => 'cloud::azure::compute::virtualmachine::mode::vmsstate',
+        'vms-state'         => 'cloud::azure::compute::virtualmachine::mode::vmsstate'
     );
 
     $self->{custom_modes}{azcli} = 'cloud::azure::custom::azcli';

cloud/azure/custom/mode.pm

@@ -87,10 +87,10 @@ sub custom_metric_output {
 
     my $network = defined($self->{instance_mode}->{metrics_mapping}->{$self->{result_values}->{metric}}->{network}) ? { network => '1' } : undef;
 
+
     my ($value, $unit) = $self->{instance_mode}->{metrics_mapping}->{$self->{result_values}->{metric}}->{unit} eq 'B' ?
         $self->{perfdata}->change_bytes(value => $self->{result_values}->{value}->{absolute}, %{$network}) :
         ($self->{result_values}->{value}->{absolute}, $self->{instance_mode}->{metrics_mapping}->{$self->{result_values}->{metric}}->{unit});
-
     if (defined($self->{instance_mode}->{option_results}->{per_second})) {
         ($value, $unit) = $self->{instance_mode}->{metrics_mapping}->{$self->{result_values}->{metric}}->{unit} eq 'B' ?
             $self->{perfdata}->change_bytes(value => $self->{result_values}->{value}->{per_second}, %{$network}) :
@@ -173,15 +173,16 @@ sub manage_selection {
     );
 
     foreach my $metric (@{$self->{az_metrics}}) {
+        my $metric_name = lc($metric);
+        $metric_name =~ s/ /_/g;
         foreach my $aggregation (@{$self->{az_aggregations}}) {
-            next if (!defined($metric_results{$self->{az_resource}}->{$metric}->{lc($aggregation)}) && !defined($self->{option_results}->{zeroed}));
-
+            next if (!defined($metric_results{$self->{az_resource}}->{$metric_name}->{lc($aggregation)}) && !defined($self->{option_results}->{zeroed}));
             $self->{metrics}->{$self->{az_resource}}->{display} = $self->{az_resource};
             $self->{metrics}->{$self->{az_resource}}->{statistics}->{lc($aggregation)}->{display} = lc($aggregation);
             $self->{metrics}->{$self->{az_resource}}->{statistics}->{lc($aggregation)}->{timeframe} = $self->{az_timeframe};
             $self->{metrics}->{$self->{az_resource}}->{statistics}->{lc($aggregation)}->{$metric} =
-                defined($metric_results{$self->{az_resource}}->{$metric}->{lc($aggregation)}) ?
-                $metric_results{$self->{az_resource}}->{$metric}->{lc($aggregation)} : 0;
+                defined($metric_results{$self->{az_resource}}->{$metric_name}->{lc($aggregation)}) ?
+                $metric_results{$self->{az_resource}}->{$metric_name}->{lc($aggregation)} : 0;
         }
     }