enh(packaging): use nfpm to package perl-keepass-reader (#4909)

.github/workflows/perl-keepass-reader.yml

@@ -18,145 +18,104 @@ on:
     paths:
       - "dependencies/perl-keepass-reader/**"
 
+env:
+  module_name: perl-keepass-reader
+
 jobs:
   get-environment:
     uses: ./.github/workflows/get-environment.yml
 
-  package-rpm:
+  package:
     needs: [get-environment]
-    if: ${{ needs.get-environment.outputs.stability != 'stable' }}
 
-    runs-on: ubuntu-22.04
     strategy:
+      fail-fast: false
       matrix:
         include:
           - image: packaging-plugins-alma8
             distrib: el8
+            package_extension: rpm
           - image: packaging-plugins-alma9
             distrib: el9
-    name: package ${{ matrix.distrib }}
+            package_extension: rpm
+          - image: packaging-plugins-bullseye
+            distrib: bullseye
+            package_extension: deb
+          - image: packaging-plugins-bookworm
+            distrib: bookworm
+            package_extension: deb
+          - image: packaging-plugins-jammy
+            distrib: jammy
+            package_extension: deb
+
+    runs-on: ubuntu-22.04
+
     container:
       image: ${{ vars.DOCKER_INTERNAL_REGISTRY_URL }}/${{ matrix.image }}:latest
       credentials:
         username: ${{ secrets.DOCKER_REGISTRY_ID }}
         password: ${{ secrets.DOCKER_REGISTRY_PASSWD }}
 
-    steps:
-      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
-
-      - run: |
-          yum install -y make perl perl-devel perl-ExtUtils-MakeMaker
-
-          mkdir -p ~/rpmbuild/{BUILD,BUILDROOT,RPMS,SOURCES,SPECS,SRPMS}
-
-          cp -rp dependencies/perl-keepass-reader/src perl-KeePass-Reader/
-          tar czf ~/rpmbuild/SOURCES/perl-KeePass-Reader.tar.gz perl-KeePass-Reader
-
-          rpmbuild -ba dependencies/perl-keepass-reader/packaging/rpm/perl-KeePass-Reader.spec
-
-          cp -r ~/rpmbuild/RPMS/noarch/*.rpm .
-        shell: bash
-
-      - uses: actions/cache/save@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0
-        with:
-          path: ./*.rpm
-          key: unsigned-${{ github.sha }}-${{ github.run_id }}-rpm-${{ matrix.distrib }}
-
-  sign-rpm:
-    needs: [package-rpm]
-    runs-on: ubuntu-22.04
-    strategy:
-      matrix:
-        include:
-          - image: packaging-alma8
-            distrib: el8
-          - image: packaging-alma9
-            distrib: el9
-    name: sign rpm ${{ matrix.distrib }}
-    container:
-      image: ${{ vars.DOCKER_INTERNAL_REGISTRY_URL }}/rpm-signing:ubuntu
-      options: -t
-      credentials:
-        username: ${{ secrets.DOCKER_REGISTRY_ID }}
-        password: ${{ secrets.DOCKER_REGISTRY_PASSWD }}
-
-    steps:
-      - run: |
-            apt-get update
-            apt-get install -y zstd
-        shell: bash
-
-      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
-
-      - uses: actions/cache/restore@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0
-        with:
-          path: ./*.rpm
-          key: unsigned-${{ github.sha }}-${{ github.run_id }}-rpm-${{ matrix.distrib }}
-
-      - run: echo "HOME=/root" >> $GITHUB_ENV
-        shell: bash
-
-      - run: rpmsign --addsign ./*.rpm
-        shell: bash
-
-      - uses: actions/cache/save@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0
-        with:
-          path: ./*.rpm
-          key: ${{ github.sha }}-${{ github.run_id }}-rpm-${{ matrix.distrib }}
-
-      - uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
-        with:
-          name: packages-${{ matrix.distrib }}
-          path: ./*.rpm
-          retention-days: 1
-
-  package-deb:
-    needs: [get-environment]
-    if: ${{ needs.get-environment.outputs.stability != 'stable' }}
-
-    runs-on: ubuntu-22.04
-    strategy:
-      matrix:
-        include:
-          - image: bullseye
-            distrib: bullseye
-          - image: bookworm
-            distrib: bookworm
-          - image: jammy
-            distrib: jammy
     name: package ${{ matrix.distrib }}
-    container:
-      image: ${{ vars.DOCKER_INTERNAL_REGISTRY_URL }}/packaging-plugins-${{ matrix.image }}:latest
-      credentials:
-        username: ${{ secrets.DOCKER_REGISTRY_ID }}
-        password: ${{ secrets.DOCKER_REGISTRY_PASSWD }}
 
     steps:
-      - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
+      - name: Checkout sources
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
 
-      - run: |
+      - name: Build library
-          apt update
+        run: |
-          apt install -y dh-make-perl perl
+          if [[ "${{ matrix.package_extension }}" == "rpm" ]]; then
+            dnf install -y make perl
+          else
+            apt-get update
+            apt-get install -y make perl
+          fi
 
-          mv dependencies/perl-keepass-reader/src/ perl-keepass-reader
+          cd dependencies/perl-keepass-reader/src
-          tar czf perl-keepass-reader.tar.gz perl-keepass-reader
+          perl Makefile.PL INSTALL_BASE=/tmp/perl-keepass-reader
-
+          make
-          DEB_BUILD_OPTIONS="nocheck nodocs notest noautodbgsym" dh-make-perl make -p libkeepass-reader-perl --verbose --build --version 0.2-${{ matrix.distrib }} perl-keepass-reader/
+          make pure_install
         shell: bash
 
-      - uses: actions/cache/save@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # v4.0.0
+      - name: Set package name and paths according to distrib
-        with:
+        run: |
-          path: ./*.deb
+          if [[ "${{ matrix.package_extension }}" == "deb" ]]; then
-          key: ${{ github.sha }}-${{ github.run_id }}-deb-${{ matrix.distrib }}
+            NAME="libkeepass-reader-perl"
+            PERL_VENDORLIB="/usr/share/perl5"
+          else
+            NAME="perl-KeePass-Reader"
+            if [[ "${{ matrix.distrib }}" == "el8" ]]; then
+              PERL_VENDORLIB="/usr/local/share/perl5"
+            else
+              PERL_VENDORLIB="/usr/local/share/perl5/5.32"
+            fi
+          fi
 
-      - uses: actions/upload-artifact@26f96dfa697d77e81fd5907df203aa23a56210a8 # v4.3.0
+          sed -i "s/@NAME@/$NAME/g" dependencies/perl-keepass-reader/packaging/perl-keepass-reader.yaml
+          sed -i "s#@PERL_VENDORLIB@#$PERL_VENDORLIB#g" dependencies/perl-keepass-reader/packaging/perl-keepass-reader.yaml
+
+          cat dependencies/perl-keepass-reader/packaging/perl-keepass-reader.yaml
+        shell: bash
+
+      - name: Package
+        uses: ./.github/actions/package-nfpm
         with:
-          name: packages-${{ matrix.distrib }}
+          nfpm_file_pattern: "dependencies/perl-keepass-reader/packaging/perl-keepass-reader.yaml"
-          path: ./*.deb
+          distrib: ${{ matrix.distrib }}
-          retention-days: 1
+          package_extension: ${{ matrix.package_extension }}
+          version: "0.2"
+          release: "2"
+          arch: all
+          commit_hash: ${{ github.sha }}
+          cache_key: cache-${{ github.run_id }}-${{ matrix.package_extension }}-${{ env.module_name }}-${{ matrix.distrib }}
+          rpm_gpg_key: ${{ secrets.RPM_GPG_SIGNING_KEY }}
+          rpm_gpg_signing_key_id: ${{ secrets.RPM_GPG_SIGNING_KEY_ID }}
+          rpm_gpg_signing_passphrase: ${{ secrets.RPM_GPG_SIGNING_PASSPHRASE }}
+          stability: ${{ needs.get-environment.outputs.stability }}
+
 
   deliver-rpm:
-    needs: [get-environment, sign-rpm]
+    needs: [get-environment, package]
     if: ${{ contains(fromJson('["testing", "unstable"]'), needs.get-environment.outputs.stability) }}
     runs-on: [self-hosted, common]
 
@@ -164,6 +123,8 @@ jobs:
       matrix:
         distrib: [el8, el9]
 
+    name: Deliver ${{ matrix.distrib }}
+
     steps:
       - name: Checkout sources
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
@@ -171,14 +132,14 @@ jobs:
       - name: Delivery
         uses: ./.github/actions/rpm-delivery
         with:
-          module_name: perl-keepass-reader
+          module_name: ${{ env.module_name }}
           distrib: ${{ matrix.distrib }}
           artifactory_token: ${{ secrets.ARTIFACTORY_ACCESS_TOKEN }}
-          cache_key: ${{ github.sha }}-${{ github.run_id }}-rpm-${{ matrix.distrib }}
+          cache_key: cache-${{ github.run_id }}-rpm-${{ env.module_name }}-${{ matrix.distrib }}
           stability: ${{ needs.get-environment.outputs.stability }}
 
   deliver-deb:
-    needs: [get-environment, package-deb]
+    needs: [get-environment, package]
     if: ${{ contains(fromJson('["testing", "unstable"]'), needs.get-environment.outputs.stability) }}
     runs-on: [self-hosted, common]
 
@@ -186,6 +147,8 @@ jobs:
       matrix:
         distrib: [bullseye, bookworm, jammy]
 
+    name: Deliver ${{ matrix.distrib }}
+
     steps:
       - name: Checkout sources
         uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
@@ -193,10 +156,10 @@ jobs:
       - name: Delivery
         uses: ./.github/actions/deb-delivery
         with:
-          module_name: perl-keepass-reader
+          module_name: ${{ env.module_name }}
           distrib: ${{ matrix.distrib }}
           artifactory_token: ${{ secrets.ARTIFACTORY_ACCESS_TOKEN }}
-          cache_key: ${{ github.sha }}-${{ github.run_id }}-deb-${{ matrix.distrib }}
+          cache_key: cache-${{ github.run_id }}-deb-${{ env.module_name }}-${{ matrix.distrib }}
           stability: ${{ needs.get-environment.outputs.stability }}
 
   promote:
@@ -205,7 +168,7 @@ jobs:
     runs-on: [self-hosted, common]
     strategy:
       matrix:
-        distrib: [el8, el9, bullseye, bookworm]
+        distrib: [bullseye, bookworm]
 
     steps:
       - name: Checkout sources
@@ -215,6 +178,6 @@ jobs:
         uses: ./.github/actions/promote-to-stable
         with:
           artifactory_token: ${{ secrets.ARTIFACTORY_ACCESS_TOKEN }}
-          module: perl-keepass-reader
+          module: ${{ env.module_name }}
           distrib: ${{ matrix.distrib }}
           stability: ${{ needs.get-environment.outputs.stability }}

dependencies/perl-keepass-reader/packaging/perl-keepass-reader.yaml

@@ -0,0 +1,44 @@
+name: "@NAME@"
+arch: "${ARCH}"
+platform: "linux"
+version_schema: "none"
+version: "${VERSION}"
+release: "${RELEASE}${DIST}"
+section: "default"
+priority: "optional"
+maintainer: "Centreon <contact@centreon.com>"
+description: |
+  KeePass::Reader is a perl interface to read KeePass version 4.
+  Commit: @COMMIT_HASH@
+vendor: "Centreon"
+homepage: "https://www.centreon.com"
+license: "Apache-2.0"
+
+contents:
+  - src: "/tmp/perl-keepass-reader/lib/perl5/KeePass"
+    dst: "@PERL_VENDORLIB@/Keepass"
+    type: tree
+    file_info:
+      mode: 0644
+
+  - src: "/tmp/perl-keepass-reader/man/man3/KeePass::Reader.3pm"
+    dst: "/usr/share/man/man3/"
+    file_info:
+      mode: 0644
+
+overrides:
+  rpm:
+    depends:
+      - perl(Crypt::Argon2)
+    provides:
+      - perl(KeePass::Reader)
+  deb:
+    depends:
+      - libcrypt-argon2-perl
+
+rpm:
+  summary: Interface to KeePass V4 database files
+  compression: zstd
+  signature:
+    key_file: ${RPM_SIGNING_KEY_FILE}
+    key_id: ${RPM_SIGNING_KEY_ID}

dependencies/perl-keepass-reader/packaging/rpm/perl-KeePass-Reader.spec

@@ -1,48 +0,0 @@
-Name:		perl-KeePass-Reader
-Version:	0.2
-Release:	2%{?dist}
-Summary:	Interface to KeePass V4 database files
-Group:		Development/Libraries
-License:	Apache2
-URL:		https://github.com/garnier-quentin/perl-KeePass-Reader
-Source0:	%{name}.tar.gz
-BuildArch:  noarch
-BuildRoot:	%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
-
-BuildRequires:  make
-BuildRequires:  perl(ExtUtils::MakeMaker)
-
-Requires: perl(Crypt::Argon2)
-
-%description
-KeePass::Reader is a perl interface to read KeePass version 4.
-
-%prep
-%setup -q -n %{name}
-
-%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
-make %{?_smp_mflags}
-
-%install
-rm -rf %{buildroot}
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
-find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -type f -name '*.bs' -a -size 0 -exec rm -f {} ';'
-find $RPM_BUILD_ROOT -type d -depth -exec rmdir {} 2>/dev/null ';'
-rm -rf $RPM_BUILD_ROOT%{_usr}/bin/hexdump
-%{_fixperms} $RPM_BUILD_ROOT/*
-
-%check
-#make test
-
-%clean
-rm -rf %{buildroot}
-
-%files
-%defattr(-,root,root,-)
-%{perl_vendorlib}
-%{_mandir}/man3/*.3*
-
-%changelog
-