From 6e5556045634dabdc37540538e7b844f599c32b0 Mon Sep 17 00:00:00 2001 From: garnier-quentin Date: Wed, 27 May 2015 15:17:29 +0200 Subject: [PATCH] - enhance mode 'environment' for plugin 'hp procurve snmp' (Fix #62) --- .../hp/procurve/mode/components/sensor.pm | 99 +++++++++ .../network/hp/procurve/mode/environment.pm | 209 ++++++++++++++---- 2 files changed, 259 insertions(+), 49 deletions(-) create mode 100644 centreon-plugins/network/hp/procurve/mode/components/sensor.pm diff --git a/centreon-plugins/network/hp/procurve/mode/components/sensor.pm b/centreon-plugins/network/hp/procurve/mode/components/sensor.pm new file mode 100644 index 000000000..b57642b6f --- /dev/null +++ b/centreon-plugins/network/hp/procurve/mode/components/sensor.pm @@ -0,0 +1,99 @@ +################################################################################ +# Copyright 2005-2013 MERETHIS +# Centreon is developped by : Julien Mathis and Romain Le Merlus under +# GPL Licence 2.0. +# +# This program is free software; you can redistribute it and/or modify it under +# the terms of the GNU General Public License as published by the Free Software +# Foundation ; either version 2 of the License. +# +# This program is distributed in the hope that it will be useful, but WITHOUT ANY +# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A +# PARTICULAR PURPOSE. See the GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License along with +# this program; if not, see . +# +# Linking this program statically or dynamically with other modules is making a +# combined work based on this program. Thus, the terms and conditions of the GNU +# General Public License cover the whole combination. +# +# As a special exception, the copyright holders of this program give MERETHIS +# permission to link this program with independent modules to produce an executable, +# regardless of the license terms of these independent modules, and to copy and +# distribute the resulting executable under terms of MERETHIS choice, provided that +# MERETHIS also meet, for each linked independent module, the terms and conditions +# of the license of that module. An independent module is a module which is not +# derived from this program. If you modify this program, you may extend this +# exception to your version of the program, but you are not obliged to do so. If you +# do not wish to do so, delete this exception statement from your version. +# +# For more information : contact@centreon.com +# Authors : Quentin Garnier +# +#################################################################################### + +package network::hp::procurve::mode::components::sensor; + +use strict; +use warnings; + +my %map_status = ( + 1 => 'unknown', + 2 => 'bad', + 3 => 'warning', + 4 => 'good', + 5 => 'not present', +); +my %object_map = ( + '.1.3.6.1.4.1.11.2.3.7.8.3.1' => 'power supply', #icfPowerSupplySensor + '.1.3.6.1.4.1.11.2.3.7.8.3.2' => 'fan', #icfFanSensor + '.1.3.6.1.4.1.11.2.3.7.8.3.3' => 'temperature', #icfTemperatureSensor + '.1.3.6.1.4.1.11.2.3.7.8.3.4' => 'future slot', #icfFutureSlotSensor +); + +my $mapping = { + hpicfSensorObjectId => { oid => '.1.3.6.1.4.1.11.2.14.11.1.2.6.1.2', map => \%object_map }, + hpicfSensorStatus => { oid => '.1.3.6.1.4.1.11.2.14.11.1.2.6.1.4', map => \%map_status }, + hpicfSensorDescr => { oid => '.1.3.6.1.4.1.11.2.14.11.1.2.6.1.7' }, +}; +my $oid_hpicfSensorEntry = '.1.3.6.1.4.1.11.2.14.11.1.2.6.1'; + +sub load { + my (%options) = @_; + + push @{$options{request}}, { oid => $oid_hpicfSensorEntry }; +} + +sub check { + my ($self) = @_; + + + $self->{output}->output_add(long_msg => "Checking sensors"); + $self->{components}->{sensor} = {name => 'sensors', total => 0, skip => 0}; + return if ($self->check_exclude(section => 'sensor')); + + foreach my $oid ($self->{snmp}->oid_lex_sort(keys %{$self->{results}->{$oid_hpicfSensorEntry}})) { + next if ($oid !~ /^$mapping->{hpicfSensorStatus}->{oid}\.(.*)$/); + my $instance_mapping = $1; + my $result = $self->{snmp}->map_instance(mapping => $mapping, results => $self->{results}->{$oid_hpicfSensorEntry}, instance => $instance_mapping); + my $instance = $result->{hpicfSensorObjectId} . '.' . $instance_mapping; + + next if ($self->check_exclude(section => 'sensor', instance => $instance)); + next if ($result->{hpicfSensorStatus} =~ /not present/i && + $self->absent_problem(section => 'sensor', instance => $instance)); + $self->{components}->{sensor}->{total}++; + + $self->{output}->output_add(long_msg => sprintf("%s sensor '%s' state is %s [instance: %s].", + $result->{hpicfSensorObjectId}, $instance, $result->{hpicfSensorStatus}, $instance + )); + my $exit = $self->get_severity(section => 'sensor', value => $result->{hpicfSensorStatus}); + if (!$self->{output}->is_status(value => $exit, compare => 'ok', litteral => 1)) { + $self->{output}->output_add(severity => $exit, + short_msg => sprintf("%s sensor '%s' state is %s", + $result->{hpicfSensorObjectId}, $instance, $result->{hpicfSensorStatus})); + } + } +} + +1; \ No newline at end of file diff --git a/centreon-plugins/network/hp/procurve/mode/environment.pm b/centreon-plugins/network/hp/procurve/mode/environment.pm index e3c6e9c27..2afb92351 100644 --- a/centreon-plugins/network/hp/procurve/mode/environment.pm +++ b/centreon-plugins/network/hp/procurve/mode/environment.pm @@ -41,20 +41,15 @@ use strict; use warnings; use centreon::plugins::misc; -my %states = ( - 1 => ['unknown', 'UNKNOWN'], - 2 => ['bad', 'CRITICAL'], - 3 => ['warning', 'WARNING'], - 4 => ['good', 'OK'], - 5 => ['not present', 'WARNING'], -); - -my %object_map = ( - '.1.3.6.1.4.1.11.2.3.7.8.3.1' => 'power supply', #icfPowerSupplySensor - '.1.3.6.1.4.1.11.2.3.7.8.3.2' => 'fan', #icfFanSensor - '.1.3.6.1.4.1.11.2.3.7.8.3.3' => 'temperature', #icfTemperatureSensor - '.1.3.6.1.4.1.11.2.3.7.8.3.4' => 'future slot', #icfFutureSlotSensor -); +my $thresholds = { + sensor => [ + ['unknown', 'UNKNOWN'], + ['bad', 'CRITICAL'], + ['warning', 'WARNING'], + ['good', 'OK'], + ['not present', 'WARNING'], + ], +}; sub new { my ($class, %options) = @_; @@ -64,7 +59,11 @@ sub new { $self->{version} = '1.0'; $options{options}->add_options(arguments => { - "skip-not-present" => { name => 'skip_not_present' }, + "exclude:s" => { name => 'exclude' }, + "absent-problem:s" => { name => 'absent' }, + "component:s" => { name => 'component', default => '.*' }, + "no-component:s" => { name => 'no_component' }, + "threshold-overload:s@" => { name => 'threshold_overload' }, }); return $self; @@ -73,6 +72,82 @@ sub new { sub check_options { my ($self, %options) = @_; $self->SUPER::init(%options); + + if (defined($self->{option_results}->{no_component})) { + if ($self->{option_results}->{no_component} ne '') { + $self->{no_components} = $self->{option_results}->{no_component}; + } else { + $self->{no_components} = 'critical'; + } + } + + $self->{overload_th} = {}; + foreach my $val (@{$self->{option_results}->{threshold_overload}}) { + if ($val !~ /^(.*?),(.*)$/) { + $self->{output}->add_option_msg(short_msg => "Wrong threshold-overload option '" . $val . "'."); + $self->{output}->option_exit(); + } + my ($section, $status, $filter) = ('sensor', $1, $2); + if ($self->{output}->is_litteral_status(status => $status) == 0) { + $self->{output}->add_option_msg(short_msg => "Wrong threshold-overload status '" . $val . "'."); + $self->{output}->option_exit(); + } + $self->{overload_th}->{$section} = [] if (!defined($self->{overload_th}->{$section})); + push @{$self->{overload_th}->{$section}}, {filter => $filter, status => $status}; + } +} + +sub check_exclude { + my ($self, %options) = @_; + + if (defined($options{instance})) { + if (defined($self->{option_results}->{exclude}) && $self->{option_results}->{exclude} =~ /(^|\s|,)${options{section}}[^,]*#\Q$options{instance}\E#/) { + $self->{components}->{$options{section}}->{skip}++; + $self->{output}->output_add(long_msg => sprintf("Skipping $options{section} section $options{instance} instance.")); + return 1; + } + } elsif (defined($self->{option_results}->{exclude}) && $self->{option_results}->{exclude} =~ /(^|\s|,)$options{section}(\s|,|$)/) { + $self->{output}->output_add(long_msg => sprintf("Skipping $options{section} section.")); + return 1; + } + return 0; +} + +sub absent_problem { + my ($self, %options) = @_; + + if (defined($self->{option_results}->{absent}) && + $self->{option_results}->{absent} =~ /(^|\s|,)($options{section}(\s*,|$)|${options{section}}[^,]*#\Q$options{instance}\E#)/) { + $self->{output}->output_add(severity => 'CRITICAL', + short_msg => sprintf("Component '%s' instance '%s' is not present", + $options{section}, $options{instance})); + } + + $self->{output}->output_add(long_msg => sprintf("Skipping $options{section} section $options{instance} instance (not present)")); + $self->{components}->{$options{section}}->{skip}++; + return 1; +} + +sub get_severity { + my ($self, %options) = @_; + my $status = 'UNKNOWN'; # default + + if (defined($self->{overload_th}->{$options{section}})) { + foreach (@{$self->{overload_th}->{$options{section}}}) { + if ($options{value} =~ /$_->{filter}/i) { + $status = $_->{status}; + return $status; + } + } + } + foreach (@{$thresholds->{$options{section}}}) { + if ($options{value} =~ /$$_[0]/i) { + $status = $$_[1]; + return $status; + } + } + + return $status; } sub run { @@ -80,41 +155,55 @@ sub run { # $options{snmp} = snmp object $self->{snmp} = $options{snmp}; - my $oid_hpicfSensorEntry = '.1.3.6.1.4.1.11.2.14.11.1.2.6.1'; - my $oid_hpicfSensorObjectId = '.1.3.6.1.4.1.11.2.14.11.1.2.6.1.2'; - my $oid_hpicfSensorStatus = '.1.3.6.1.4.1.11.2.14.11.1.2.6.1.4'; - my $oid_hpicfSensorDescr = '.1.3.6.1.4.1.11.2.14.11.1.2.6.1.7'; - - my $result = $self->{snmp}->get_table(oid => $oid_hpicfSensorEntry, nothing_quit => 1); - $self->{output}->output_add(severity => 'OK', - short_msg => sprintf("All sensors are ok.")); - - foreach my $oid (keys %$result) { - next if ($oid !~ /^$oid_hpicfSensorStatus\./); - $oid =~ /\.([0-9]+)$/; - my $instance = $1; - - my $descr = centreon::plugins::misc::trim($result->{$oid_hpicfSensorDescr . '.' . $instance}); - my $status = $result->{$oid_hpicfSensorStatus . '.' . $instance}; - my $object = $result->{$oid_hpicfSensorObjectId . '.' . $instance}; - - $self->{output}->output_add(long_msg => sprintf("%s sensor '%s' state is %s.", - $object_map{$object}, $instance, - ${$states{$status}}[0])); - if (defined($self->{option_results}->{skip_not_present}) && - $status == 5) { - $self->{output}->output_add(long_msg => sprintf("Skipping %s sensor '%s'.", - $object_map{$object}, $instance)); - next; - } - if (${$states{$status}}[1] ne 'OK') { - $self->{output}->output_add(severity => ${$states{$status}}[1], - short_msg => sprintf("%s sensor '%s' state is %s.", - $object_map{$object}, $instance, - ${$states{$status}}[0])); + my $snmp_request = []; + my @components = ('sensor'); + foreach (@components) { + if (/$self->{option_results}->{component}/) { + my $mod_name = "network::hp::procurve::mode::components::$_"; + centreon::plugins::misc::mymodule_load(output => $self->{output}, module => $mod_name, + error_msg => "Cannot load module '$mod_name'."); + my $func = $mod_name->can('load'); + $func->(request => $snmp_request); } } + if (scalar(@{$snmp_request}) == 0) { + $self->{output}->add_option_msg(short_msg => "Wrong option. Cannot find component '" . $self->{option_results}->{component} . "'."); + $self->{output}->option_exit(); + } + $self->{results} = $self->{snmp}->get_multiple_table(oids => $snmp_request); + + foreach (@components) { + if (/$self->{option_results}->{component}/) { + my $mod_name = "network::hp::procurve::mode::components::$_"; + my $func = $mod_name->can('check'); + $func->($self); + } + } + + my $total_components = 0; + my $display_by_component = ''; + my $display_by_component_append = ''; + foreach my $comp (sort(keys %{$self->{components}})) { + # Skipping short msg when no components + next if ($self->{components}->{$comp}->{total} == 0 && $self->{components}->{$comp}->{skip} == 0); + $total_components += $self->{components}->{$comp}->{total} + $self->{components}->{$comp}->{skip}; + my $count_by_components = $self->{components}->{$comp}->{total} + $self->{components}->{$comp}->{skip}; + $display_by_component .= $display_by_component_append . $self->{components}->{$comp}->{total} . '/' . $count_by_components . ' ' . $self->{components}->{$comp}->{name}; + $display_by_component_append = ', '; + } + + $self->{output}->output_add(severity => 'OK', + short_msg => sprintf("All %s components are ok [%s].", + $total_components, + $display_by_component) + ); + + if (defined($self->{option_results}->{no_component}) && $total_components == 0) { + $self->{output}->output_add(severity => $self->{no_components}, + short_msg => 'No components are checked.'); + } + $self->{output}->display(); $self->{output}->exit(); } @@ -129,9 +218,31 @@ Check sensors (hpicfChassis.mib). =over 8 -=item B<--skip-not-present> +=item B<--component> -No warning for state 'not present'. +Which component to check (Default: '.*'). +Can be: 'sensor'. + +=item B<--exclude> + +Exclude some parts (comma seperated list) +Can also exclude specific instance: --exclude=sensor#fan.1# + +=item B<--absent-problem> + +Return an error if an entity is not 'present' (default is skipping) (comma seperated list) +Can be specific or global: --absent-problem=sensor#temperature.2# + +=item B<--no-component> + +Return an error if no compenents are checked. +If total (with skipped) is 0. (Default: 'critical' returns). + +=item B<--threshold-overload> + +Set to overload default threshold values (syntax: section,status,regexp) +It used before default thresholds (order stays). +Example: --threshold-overload='CRITICAL,^(?!(good)$)' =back