From 884c16ee95c1a850b820d661407c992b9ef6a77d Mon Sep 17 00:00:00 2001
From: garnier-quentin <garnier.quentin@gmail.com>
Date: Thu, 18 Apr 2019 14:41:42 +0200
Subject: [PATCH] update nimble with counter class

---
 storage/nimble/snmp/mode/globalstats.pm | 140 ++++---------------
 storage/nimble/snmp/mode/volumeusage.pm | 177 ++++++------------------
 2 files changed, 70 insertions(+), 247 deletions(-)

diff --git a/storage/nimble/snmp/mode/globalstats.pm b/storage/nimble/snmp/mode/globalstats.pm
index 8138291c8..8975119ea 100644
--- a/storage/nimble/snmp/mode/globalstats.pm
+++ b/storage/nimble/snmp/mode/globalstats.pm
@@ -20,17 +20,21 @@
 
 package storage::nimble::snmp::mode::globalstats;
 
-use base qw(centreon::plugins::mode);
+use base qw(centreon::plugins::templates::counter);
 
 use strict;
 use warnings;
 use Digest::MD5 qw(md5_hex);
-use centreon::plugins::values;
-use centreon::plugins::statefile;
 
-my $maps_counters = {
-    global => {
-        '000_read'   => { set => {
+sub set_counters {
+    my ($self, %options) = @_;
+    
+    $self->{maps_counters_type} = [
+        { name => 'global', type => 0, skipped_code => { -10 => 1 } }
+    ];
+    
+    $self->{maps_counters}->{global} = [
+        { label => 'read', nlabel => 'system.io.read.usage.bytespersecond', set => {
                 key_values => [ { name => 'read', diff => 1 } ],
                 per_second => 1,
                 output_template => 'Read I/O : %s %s/s', output_error_template => "Read I/O : %s",
@@ -41,7 +45,7 @@ my $maps_counters = {
                 ],
             }
         },
-        '001_write'   => { set => {
+        { label => 'write', nlabel => 'system.io.write.usage.bytespersecond', set => {
                 key_values => [ { name => 'write', diff => 1 } ],
                 per_second => 1,
                 output_template => 'Write I/O : %s %s/s', output_error_template => "Write I/O : %s",
@@ -52,7 +56,7 @@ my $maps_counters = {
                 ],
             }
         },
-        '002_read-iops'   => { set => {
+        { label => 'read-iops', nlabel => 'system.io.read.usage.iops', set => {
                 key_values => [ { name => 'read_iops', diff => 1 } ],
                 per_second => 1,
                 output_template => 'Read IOPs : %.2f', output_error_template => "Read IOPs : %s",
@@ -62,7 +66,7 @@ my $maps_counters = {
                 ],
             }
         },
-        '003_write-iops'   => { set => {
+        { label => 'write-iops', nlabel => 'system.io.write.usage.iops', set => {
                 key_values => [ { name => 'write_iops', diff => 1 } ],
                 per_second => 1,
                 output_template => 'Write IOPs : %.2f', output_error_template => "Write IOPs : %s",
@@ -72,7 +76,7 @@ my $maps_counters = {
                 ],
             }
         },
-        '004_read-time'   => { set => {
+        { label => 'read-time', nlabel => 'system.io.read.time.seconds', set => {
                 key_values => [ { name => 'read_time', diff => 1 } ],
                 output_template => 'Read Time : %.3f s', output_error_template => "Read Time : %s",
                 perfdatas => [
@@ -81,7 +85,7 @@ my $maps_counters = {
                 ],
             }
         },
-        '005_write-time'   => { set => {
+        { label => 'write-time', nlabel => 'system.io.write.time.seconds', set => {
                 key_values => [ { name => 'write_time', diff => 1 } ],
                 output_template => 'Write Time : %.3f s', output_error_template => "Write Time : %s",
                 perfdatas => [
@@ -90,119 +94,21 @@ my $maps_counters = {
                 ],
             }
         },
-    },
-};
+    ];
+}
 
 sub new {
     my ($class, %options) = @_;
-    my $self = $class->SUPER::new(package => __PACKAGE__, %options);
+    my $self = $class->SUPER::new(package => __PACKAGE__, %options, statefile => 1);
     bless $self, $class;
     
     $self->{version} = '1.0';
-    $options{options}->add_options(arguments =>
-                                {
-                                "filter-counters:s" => { name => 'filter_counters' },
-                                });
-    $self->{statefile_value} = centreon::plugins::statefile->new(%options);
+    $options{options}->add_options(arguments => {
+    });
 
-    foreach my $key (('global')) {
-        foreach (keys %{$maps_counters->{$key}}) {
-            my ($id, $name) = split /_/;
-            if (!defined($maps_counters->{$key}->{$_}->{threshold}) || $maps_counters->{$key}->{$_}->{threshold} != 0) {
-                $options{options}->add_options(arguments => {
-                                                    'warning-' . $name . ':s'    => { name => 'warning-' . $name },
-                                                    'critical-' . $name . ':s'    => { name => 'critical-' . $name },
-                                               });
-            }
-            $maps_counters->{$key}->{$_}->{obj} = centreon::plugins::values->new(statefile => $self->{statefile_value},
-                                                      output => $self->{output},
-                                                      perfdata => $self->{perfdata},
-                                                      label => $name);
-            $maps_counters->{$key}->{$_}->{obj}->set(%{$maps_counters->{$key}->{$_}->{set}});
-        }
-    }
-    
     return $self;
 }
 
-sub check_options {
-    my ($self, %options) = @_;
-    $self->SUPER::init(%options);
-    
-    foreach my $key (('global')) {
-        foreach (keys %{$maps_counters->{$key}}) {
-            $maps_counters->{$key}->{$_}->{obj}->init(option_results => $self->{option_results});
-        }
-    }
-    
-    $self->{statefile_value}->check_options(%options);
-}
-
-sub run_global {
-    my ($self, %options) = @_;
-
-    my ($short_msg, $short_msg_append, $long_msg, $long_msg_append) = ('', '', '', '');
-    my @exits;
-    foreach (sort keys %{$maps_counters->{global}}) {
-        if (defined($self->{option_results}->{filter_counters}) && $self->{option_results}->{filter_counters} ne '' &&
-            $_ !~ /$self->{option_results}->{filter_counters}/) {
-            $self->{output}->output_add(long_msg => "skipping counter $_", debug => 1);
-            next;
-        }
-
-        my $obj = $maps_counters->{global}->{$_}->{obj};
-                
-        $obj->set(instance => 'global');
-    
-        my ($value_check) = $obj->execute(new_datas => $self->{new_datas},
-                                          values => $self->{global});
-
-        if ($value_check != 0) {
-            $long_msg .= $long_msg_append . $obj->output_error();
-            $long_msg_append = ', ';
-            next;
-        }
-        my $exit2 = $obj->threshold_check();
-        push @exits, $exit2;
-
-        my $output = $obj->output();
-        $long_msg .= $long_msg_append . $output;
-        $long_msg_append = ', ';
-        
-        if (!$self->{output}->is_status(litteral => 1, value => $exit2, compare => 'ok')) {
-            $short_msg .= $short_msg_append . $output;
-            $short_msg_append = ', ';
-        }
-        
-        $obj->perfdata();
-    }
-
-    my $exit = $self->{output}->get_most_critical(status => [ @exits ]);
-    if (!$self->{output}->is_status(litteral => 1, value => $exit, compare => 'ok')) {
-        $self->{output}->output_add(severity => $exit,
-                                    short_msg => "$short_msg"
-                                    );
-    } else {
-        $self->{output}->output_add(short_msg => "$long_msg");
-    }    
-}
-
-sub run {
-    my ($self, %options) = @_;
-    
-    $self->manage_selection(%options);
-
-    $self->{new_datas} = {};
-    $self->{statefile_value}->read(statefile => $self->{cache_name});
-    $self->{new_datas}->{last_timestamp} = time();
-    
-    $self->run_global();
-
-    $self->{statefile_value}->write(data => $self->{new_datas});
-    $self->{output}->display();
-    $self->{output}->exit();
-}
-
 sub manage_selection {
     my ($self, %options) = @_;
     
@@ -222,8 +128,10 @@ sub manage_selection {
     my $oid_ioWrites = '.1.3.6.1.4.1.37447.1.3.4.0';
     my $oid_ioWriteBytes = '.1.3.6.1.4.1.37447.1.3.10.0';
     my $oid_ioWriteTimeMicrosec = '.1.3.6.1.4.1.37447.1.3.7.0';
-    my $result = $options{snmp}->get_table(oid => $oid_globalStats,
-                                           nothing_quit => 1);
+    my $result = $options{snmp}->get_table(
+        oid => $oid_globalStats,
+        nothing_quit => 1
+    );
     $self->{global}->{read} = defined($result->{$oid_ioReadBytes}) ? $result->{$oid_ioReadBytes} : undef;
     $self->{global}->{read_iops} = defined($result->{$oid_ioReads}) ? $result->{$oid_ioReads} : undef;
     $self->{global}->{read_time} = defined($result->{$oid_ioReadTimeMicrosec}) ? $result->{$oid_ioReadTimeMicrosec} / 1000000 : undef;
diff --git a/storage/nimble/snmp/mode/volumeusage.pm b/storage/nimble/snmp/mode/volumeusage.pm
index 1ece8361b..a906ffc14 100644
--- a/storage/nimble/snmp/mode/volumeusage.pm
+++ b/storage/nimble/snmp/mode/volumeusage.pm
@@ -20,46 +20,29 @@
 
 package storage::nimble::snmp::mode::volumeusage;
 
-use base qw(centreon::plugins::mode);
+use base qw(centreon::plugins::templates::counter);
 
 use strict;
 use warnings;
-use centreon::plugins::values;
-
-my $instance_mode;
-
-my $maps_counters = {
-    vol => {
-        '000_usage'   => {
-            set => {
-                key_values => [ { name => 'display' }, { name => 'total' }, { name => 'used' } ],
-                closure_custom_calc => \&custom_usage_calc,
-                closure_custom_output => \&custom_usage_output,
-                closure_custom_perfdata => \&custom_usage_perfdata,
-                closure_custom_threshold_check => \&custom_usage_threshold,
-            },
-        },
-    }
-};
 
 sub custom_usage_perfdata {
     my ($self, %options) = @_;
-    
-    my $extra_label = '';
-    if (!defined($options{extra_instance}) || $options{extra_instance} != 0) {
-        $extra_label .= '_' . $self->{result_values}->{display};
-    }
-    $self->{output}->perfdata_add(label => 'used' . $extra_label, unit => 'B',
-                                  value => $self->{result_values}->{used},
-                                  warning => $self->{perfdata}->get_perfdata_for_output(label => 'warning-' . $self->{label}, total => $self->{result_values}->{total}, cast_int => 1),
-                                  critical => $self->{perfdata}->get_perfdata_for_output(label => 'critical-' . $self->{label}, total => $self->{result_values}->{total}, cast_int => 1),
-                                  min => 0, max => $self->{result_values}->{total});
+
+    $self->{output}->perfdata_add(
+        label => 'used', unit => 'B',
+        nlabel => $self->{nlabel},
+        instances => $self->use_instances(extra_instance => $options{extra_instance}) ? $self->{result_values}->{display} : undef,
+        value => $self->{result_values}->{used},
+        warning => $self->{perfdata}->get_perfdata_for_output(label => 'warning-' . $self->{thlabel}, total => $self->{result_values}->{total}, cast_int => 1),
+        critical => $self->{perfdata}->get_perfdata_for_output(label => 'critical-' . $self->{thlabel}, total => $self->{result_values}->{total}, cast_int => 1),
+        min => 0, max => $self->{result_values}->{total}
+    );
 }
 
 sub custom_usage_threshold {
     my ($self, %options) = @_;
     
-    my $exit = $self->{perfdata}->threshold_check(value => $self->{result_values}->{prct_used}, threshold => [ { label => 'critical-' . $self->{label}, exit_litteral => 'critical' }, { label => 'warning-' . $self->{label}, exit_litteral => 'warning' } ]);
+    my $exit = $self->{perfdata}->threshold_check(value => $self->{result_values}->{prct_used}, threshold => [ { label => 'critical-' . $self->{thlabel}, exit_litteral => 'critical' }, { label => 'warning-' . $self->{thlabel}, exit_litteral => 'warning' } ]);
     return $exit;
 }
 
@@ -89,111 +72,42 @@ sub custom_usage_calc {
     return 0;
 }
 
+sub set_counters {
+    my ($self, %options) = @_;
+    
+    $self->{maps_counters_type} = [
+        { name => 'volume', type => 1, cb_prefix_output => 'prefix_volume_output', message_multiple => 'All volumes are ok' }
+    ];
+    
+    $self->{maps_counters}->{volume} = [
+        { label => 'usage', nlabel => 'volume.space.usage.bytes', set => {
+                key_values => [ { name => 'display' }, { name => 'used' }, { name => 'total' } ],
+                closure_custom_calc => $self->can('custom_usage_calc'),
+                closure_custom_output => $self->can('custom_usage_output'),
+                closure_custom_perfdata => $self->can('custom_usage_perfdata'),
+                closure_custom_threshold_check => $self->can('custom_usage_threshold'),
+            }
+        },
+    ];
+}
+
 sub new {
     my ($class, %options) = @_;
     my $self = $class->SUPER::new(package => __PACKAGE__, %options);
     bless $self, $class;
     
     $self->{version} = '1.0';
-    $options{options}->add_options(arguments =>
-                                { 
-                                  "filter-name:s"           => { name => 'filter_name' },
-                                });
-                                
-    foreach my $key (('vol')) {
-        foreach (keys %{$maps_counters->{$key}}) {
-            my ($id, $name) = split /_/;
-            if (!defined($maps_counters->{$key}->{$_}->{threshold}) || $maps_counters->{$key}->{$_}->{threshold} != 0) {
-                $options{options}->add_options(arguments => {
-                                                            'warning-' . $name . ':s'    => { name => 'warning-' . $name },
-                                                            'critical-' . $name . ':s'    => { name => 'critical-' . $name },
-                                               });
-            }
-            $maps_counters->{$key}->{$_}->{obj} = centreon::plugins::values->new(output => $self->{output}, perfdata => $self->{perfdata},
-                                                      label => $name);
-            $maps_counters->{$key}->{$_}->{obj}->set(%{$maps_counters->{$key}->{$_}->{set}});
-        }
-    }
-    
+    $options{options}->add_options(arguments => { 
+        "filter-name:s" => { name => 'filter_name' },
+    });
+
     return $self;
 }
 
-sub check_options {
-    my ($self, %options) = @_;
-    $self->SUPER::init(%options);
-    
-    foreach my $key (('vol')) {
-        foreach (keys %{$maps_counters->{$key}}) {
-            $maps_counters->{$key}->{$_}->{obj}->init(option_results => $self->{option_results});
-        }
-    }
-    $instance_mode = $self;
-}
-
-sub run_instances {
+sub prefix_volume_output {
     my ($self, %options) = @_;
     
-    my $multiple = 1;
-    if (scalar(keys %{$self->{vol}}) == 1) {
-        $multiple = 0;
-    }
-    
-    if ($multiple == 1) {
-        $self->{output}->output_add(severity => 'OK',
-                                    short_msg => 'All volume usages are ok');
-    }
-    
-    foreach my $id (sort keys %{$self->{vol}}) {     
-        my ($short_msg, $short_msg_append, $long_msg, $long_msg_append) = ('', '', '', '');
-        my @exits = ();
-        foreach (sort keys %{$maps_counters->{vol}}) {
-            my $obj = $maps_counters->{vol}->{$_}->{obj};
-            $obj->set(instance => $id);
-        
-            my ($value_check) = $obj->execute(values => $self->{vol}->{$id});
-
-            if ($value_check != 0) {
-                $long_msg .= $long_msg_append . $obj->output_error();
-                $long_msg_append = ', ';
-                next;
-            }
-            my $exit2 = $obj->threshold_check();
-            push @exits, $exit2;
-
-            my $output = $obj->output();
-            $long_msg .= $long_msg_append . $output;
-            $long_msg_append = ', ';
-            
-            if (!$self->{output}->is_status(litteral => 1, value => $exit2, compare => 'ok')) {
-                $short_msg .= $short_msg_append . $output;
-                $short_msg_append = ', ';
-            }
-            
-            $obj->perfdata(level => 1, extra_instance => $multiple);
-        }
-
-        $self->{output}->output_add(long_msg => "Volume '$self->{vol}->{$id}->{display}' $long_msg");
-        my $exit = $self->{output}->get_most_critical(status => [ @exits ]);
-        if (!$self->{output}->is_status(litteral => 1, value => $exit, compare => 'ok')) {
-            $self->{output}->output_add(severity => $exit,
-                                        short_msg => "Volume '$self->{vol}->{$id}->{display}' $short_msg"
-                                        );
-        }
-        
-        if ($multiple == 0) {
-            $self->{output}->output_add(short_msg => "Volume '$self->{vol}->{$id}->{display}' $long_msg");
-        }
-    }
-}
-
-sub run {
-    my ($self, %options) = @_;
-
-    $self->manage_selection(%options);
-    $self->run_instances();
-     
-    $self->{output}->display();
-    $self->{output}->exit();
+    return "Volume '" . $options{instance_value}->{display} . "' ";
 }
 
 my $mapping = {
@@ -208,26 +122,27 @@ sub manage_selection {
     my ($self, %options) = @_;
     
     my $oid_volEntry = '.1.3.6.1.4.1.37447.1.2.1';
-    my $results = $options{snmp}->get_table(oid => $oid_volEntry, nothing_quit => 1);
-    $self->{vol} = {};
-    foreach my $oid (keys %{$results}) {
+    my $snmp_result = $options{snmp}->get_table(oid => $oid_volEntry, nothing_quit => 1);
+
+    $self->{volume} = {};
+    foreach my $oid (keys %{$snmp_result}) {
         next if ($oid !~ /^$mapping->{volName}->{oid}\.(.*)/);
         my $instance = $1;
-        my $result = $options{snmp}->map_instance(mapping => $mapping, results => $results, instance => $instance);
+        my $result = $options{snmp}->map_instance(mapping => $mapping, results => $snmp_result, instance => $instance);
         
         if (defined($self->{option_results}->{filter_name}) && $self->{option_results}->{filter_name} ne '' &&
             $result->{volName} !~ /$self->{option_results}->{filter_name}/) {
-            $self->{output}->output_add(long_msg => "Skipping '" . $result->{volName} . "': no matching vserver name.", debug => 1);
+            $self->{output}->output_add(long_msg => "skipping '" . $result->{volName} . "': no matching volume name.", debug => 1);
             next;
         }
         
         my $total = (($result->{volSizeHigh} << 32) + $result->{volSizeLow}) * 1024 * 1024;
         my $used = (($result->{volUsageHigh} << 32) + $result->{volUsageLow}) * 1024 * 1024;
-        $self->{vol}->{$instance} = { display => $result->{volName}, used => $used, total => $total }; 
+        $self->{volume}->{$instance} = { display => $result->{volName}, used => $used, total => $total }; 
     }
     
-    if (scalar(keys %{$self->{vol}}) <= 0) {
-        $self->{output}->add_option_msg(short_msg => "No entry found.");
+    if (scalar(keys %{$self->{volume}}) <= 0) {
+        $self->{output}->add_option_msg(short_msg => "No volume found.");
         $self->{output}->option_exit();
     }
 }