From e342e4da5c30693b35098f509c6695b49ee11254 Mon Sep 17 00:00:00 2001 From: Sims24 Date: Wed, 12 Aug 2020 20:30:42 +0200 Subject: [PATCH 1/2] new(plugin)polycom hdx viewstation stats --- .../polycom/hdx/snmp/mode/viewstationstats.pm | 119 ++++++++++++++++++ .../devices/polycom/hdx/snmp/plugin.pm | 53 ++++++++ 2 files changed, 172 insertions(+) create mode 100644 centreon-plugins/hardware/devices/polycom/hdx/snmp/mode/viewstationstats.pm create mode 100644 centreon-plugins/hardware/devices/polycom/hdx/snmp/plugin.pm diff --git a/centreon-plugins/hardware/devices/polycom/hdx/snmp/mode/viewstationstats.pm b/centreon-plugins/hardware/devices/polycom/hdx/snmp/mode/viewstationstats.pm new file mode 100644 index 000000000..83dc0087f --- /dev/null +++ b/centreon-plugins/hardware/devices/polycom/hdx/snmp/mode/viewstationstats.pm @@ -0,0 +1,119 @@ +# +# Copyright 2020 Centreon (http://www.centreon.com/) +# +# Centreon is a full-fledged industry-strength solution that meets +# the needs in IT infrastructure and application monitoring for +# service performance. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +package hardware::devices::polycom::hdx::snmp::mode::viewstationstats; + +use base qw(centreon::plugins::templates::counter); + +use strict; +use warnings; + +sub set_counters { + my ($self, %options) = @_; + + $self->{maps_counters_type} = [ + { name => 'global', type => 0, cb_prefix_output => 'prefix_global_output' }, + ]; + $self->{maps_counters}->{global} = [ + { label => 'h323-packet-loss', nlabel => 'viewstation.h323.packet.loss.percentage', set => { + key_values => [ { name => 'polycomVSPercentPacketLoss' }, { name => 'display' } ], + output_template => 'H323 Packet Loss %.2f %%', + perfdatas => [ + { label => 'vs_packet_loss', value => 'polycomVSPercentPacketLoss', template => '%.2f', + min => 0, max => 100, unit => '%' }, + ], + } + }, + { label => 'h323-jitter', nlabel => 'viewstation.h323.jitter.milliseconds', set => { + key_values => [ { name => 'polycomVSJitter' }, { name => 'display' } ], + output_template => 'H323 (audio/video) Jitter %.2f ms', + perfdatas => [ + { label => 'vs_packet_loss', value => 'polycomVSJitter', template => '%.2f', + min => 0, max => 100, unit => 'ms' }, + ], + } + }, + { label => 'h323-latency', nlabel => 'viewstation.h323.latency.count', set => { + key_values => [ { name => 'polycomVSLatency' }, { name => 'display' } ], + output_template => 'H323 (audio/video) Latency %.2f', + perfdatas => [ + { label => 'vs_latency', value => 'polycomVSLatency', template => '%.2f', + min => 0, max => 100, unit => '' }, + ], + } + }, + ]; +} + +sub prefix_global_output { + my ($self, %options) = @_; + + return "View Station Phone Number: '" . $options{instance_value}->{display} . "' Stats: "; +} + +sub new { + my ($class, %options) = @_; + my $self = $class->SUPER::new(package => __PACKAGE__, %options); + bless $self, $class; + + $options{options}->add_options(arguments => { + }); + + return $self; +} + +sub manage_selection { + my ($self, %options) = @_; + + my $oid_polycomVSPhoneNumber = '.1.3.6.1.4.1.2684.1.1.2.0'; + my $oid_polycomVSPercentPacketLoss = '.1.3.6.1.4.1.2684.1.1.21.0'; + my $oid_polycomVSJitter = '.1.3.6.1.4.1.2684.1.1.22.0'; + my $oid_polycomVSLatency = '.1.3.6.1.4.1.2684.1.1.23.0'; + + my $result = $options{snmp}->get_leef(oids => [$oid_polycomVSPhoneNumber, $oid_polycomVSPercentPacketLoss, + $oid_polycomVSJitter, $oid_polycomVSLatency], + nothing_quit => 1); + + $self->{global} = { + display => $result->{$oid_polycomVSPhoneNumber}, + polycomVSPercentPacketLoss => $result->{$oid_polycomVSPercentPacketLoss}, + polycomVSJitter => $result->{$oid_polycomVSJitter}, + polycomVSLatency => $result->{$oid_polycomVSLatency}, + }; +} + +1; + +__END__ + +=head1 MODE + +Check HDX ViewStation statistics during H323 communications + +=over 8 + +=item B<--warning-* --critical> + +Warning and Critical Thresholds. +Possible values are: h323-packet-loss, h323-jitter, h323-latency + +=back + +=cut \ No newline at end of file diff --git a/centreon-plugins/hardware/devices/polycom/hdx/snmp/plugin.pm b/centreon-plugins/hardware/devices/polycom/hdx/snmp/plugin.pm new file mode 100644 index 000000000..74d8f725e --- /dev/null +++ b/centreon-plugins/hardware/devices/polycom/hdx/snmp/plugin.pm @@ -0,0 +1,53 @@ +# +# Copyright 2020 Centreon (http://www.centreon.com/) +# +# Centreon is a full-fledged industry-strength solution that meets +# the needs in IT infrastructure and application monitoring for +# service performance. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +package hardware::devices::polycom::hdx::snmp::plugin; + +use strict; +use warnings; +use base qw(centreon::plugins::script_snmp); + +sub new { + my ($class, %options) = @_; + my $self = $class->SUPER::new(package => __PACKAGE__, %options); + bless $self, $class; + + $self->{version} = '1.0'; + %{$self->{modes}} = ( + 'cpu-detailed' => 'snmp_standard::mode::cpudetailed', + 'interfaces' => 'snmp_standard::mode::interfaces', + 'load' => 'snmp_standard::mode::loadaverage', + 'memory ' => 'snmp_standard::mode::memory', + 'uptime' => 'snmp_standard::mode::uptime', + 'viewstation-stats' => 'hardware::devices::polycom::hdx::snmp::mode::viewstationstats', + ); + + return $self; +} + +1; + +__END__ + +=head1 PLUGIN DESCRIPTION + +Check Polycom HDX View Stations Devices in SNMP. + +=cut From 92ca892a5904e517ce77893439336ab32c597365 Mon Sep 17 00:00:00 2001 From: thibaults-centreon Date: Thu, 13 Aug 2020 18:35:02 +0200 Subject: [PATCH 2/2] enh(mode): style --- .../polycom/hdx/snmp/mode/viewstationstats.pm | 53 ++++++++++--------- .../devices/polycom/hdx/snmp/plugin.pm | 2 +- 2 files changed, 30 insertions(+), 25 deletions(-) diff --git a/centreon-plugins/hardware/devices/polycom/hdx/snmp/mode/viewstationstats.pm b/centreon-plugins/hardware/devices/polycom/hdx/snmp/mode/viewstationstats.pm index 83dc0087f..4aa433f63 100644 --- a/centreon-plugins/hardware/devices/polycom/hdx/snmp/mode/viewstationstats.pm +++ b/centreon-plugins/hardware/devices/polycom/hdx/snmp/mode/viewstationstats.pm @@ -27,38 +27,39 @@ use warnings; sub set_counters { my ($self, %options) = @_; - + $self->{maps_counters_type} = [ - { name => 'global', type => 0, cb_prefix_output => 'prefix_global_output' }, + { name => 'global', type => 0, cb_prefix_output => 'prefix_global_output' } ]; + $self->{maps_counters}->{global} = [ { label => 'h323-packet-loss', nlabel => 'viewstation.h323.packet.loss.percentage', set => { key_values => [ { name => 'polycomVSPercentPacketLoss' }, { name => 'display' } ], output_template => 'H323 Packet Loss %.2f %%', perfdatas => [ - { label => 'vs_packet_loss', value => 'polycomVSPercentPacketLoss', template => '%.2f', - min => 0, max => 100, unit => '%' }, - ], + { value => 'polycomVSPercentPacketLoss', template => '%.2f', + min => 0, max => 100, unit => '%' } + ] } }, { label => 'h323-jitter', nlabel => 'viewstation.h323.jitter.milliseconds', set => { key_values => [ { name => 'polycomVSJitter' }, { name => 'display' } ], output_template => 'H323 (audio/video) Jitter %.2f ms', perfdatas => [ - { label => 'vs_packet_loss', value => 'polycomVSJitter', template => '%.2f', - min => 0, max => 100, unit => 'ms' }, - ], + { value => 'polycomVSJitter', template => '%.2f', + min => 0, max => 100, unit => 'ms' } + ] } }, { label => 'h323-latency', nlabel => 'viewstation.h323.latency.count', set => { key_values => [ { name => 'polycomVSLatency' }, { name => 'display' } ], output_template => 'H323 (audio/video) Latency %.2f', perfdatas => [ - { label => 'vs_latency', value => 'polycomVSLatency', template => '%.2f', - min => 0, max => 100, unit => '' }, - ], + { label => 'vs_latency', value => 'polycomVSLatency', template => '%.2f', + min => 0, max => 100, unit => '' } + ] } - }, + } ]; } @@ -72,10 +73,9 @@ sub new { my ($class, %options) = @_; my $self = $class->SUPER::new(package => __PACKAGE__, %options); bless $self, $class; - - $options{options}->add_options(arguments => { - }); - + + $options{options}->add_options(arguments => {}); + return $self; } @@ -87,31 +87,36 @@ sub manage_selection { my $oid_polycomVSJitter = '.1.3.6.1.4.1.2684.1.1.22.0'; my $oid_polycomVSLatency = '.1.3.6.1.4.1.2684.1.1.23.0'; - my $result = $options{snmp}->get_leef(oids => [$oid_polycomVSPhoneNumber, $oid_polycomVSPercentPacketLoss, - $oid_polycomVSJitter, $oid_polycomVSLatency], - nothing_quit => 1); + my $result = $options{snmp}->get_leef( + oids => [ + $oid_polycomVSPhoneNumber, + $oid_polycomVSPercentPacketLoss, + $oid_polycomVSJitter, + $oid_polycomVSLatency + ], + nothing_quit => 1 + ); $self->{global} = { display => $result->{$oid_polycomVSPhoneNumber}, polycomVSPercentPacketLoss => $result->{$oid_polycomVSPercentPacketLoss}, polycomVSJitter => $result->{$oid_polycomVSJitter}, - polycomVSLatency => $result->{$oid_polycomVSLatency}, + polycomVSLatency => $result->{$oid_polycomVSLatency} }; } - 1; __END__ =head1 MODE -Check HDX ViewStation statistics during H323 communications +Check HDX ViewStation statistics during H323 communications =over 8 -=item B<--warning-* --critical> +=item B<--warning-* --critical-*> -Warning and Critical Thresholds. +Warning and Critical thresholds. Possible values are: h323-packet-loss, h323-jitter, h323-latency =back diff --git a/centreon-plugins/hardware/devices/polycom/hdx/snmp/plugin.pm b/centreon-plugins/hardware/devices/polycom/hdx/snmp/plugin.pm index 74d8f725e..edd614704 100644 --- a/centreon-plugins/hardware/devices/polycom/hdx/snmp/plugin.pm +++ b/centreon-plugins/hardware/devices/polycom/hdx/snmp/plugin.pm @@ -36,7 +36,7 @@ sub new { 'load' => 'snmp_standard::mode::loadaverage', 'memory ' => 'snmp_standard::mode::memory', 'uptime' => 'snmp_standard::mode::uptime', - 'viewstation-stats' => 'hardware::devices::polycom::hdx::snmp::mode::viewstationstats', + 'viewstation-stats' => 'hardware::devices::polycom::hdx::snmp::mode::viewstationstats' ); return $self;