tyler.durden/centreon-plugins
1
0
Fork 0
mirror of https://github.com/centreon/centreon-plugins.git synced 2025-07-27 15:44:21 +02:00
Code Issues Packages Projects Releases Wiki Activity

enh(mode): style

Browse Source
This commit is contained in:
thibaults-centreon 2020-08-13 18:35:02 +02:00
parent 2e82cf9484
commit 99da77f59f
2 changed files with 30 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
hardware/devices/polycom/hdx/snmp/mode/viewstationstats.pm
View File

@ -29,25 +29,26 @@ sub set_counters {
my ($self, %options) = @_; my ($self, %options) = @_;
$self->{maps_counters_type} = [ $self->{maps_counters_type} = [
{ name => 'global', type => 0, cb_prefix_output => 'prefix_global_output' }, { name => 'global', type => 0, cb_prefix_output => 'prefix_global_output' }
]; ];
$self->{maps_counters}->{global} = [ $self->{maps_counters}->{global} = [
{ label => 'h323-packet-loss', nlabel => 'viewstation.h323.packet.loss.percentage', set => { { label => 'h323-packet-loss', nlabel => 'viewstation.h323.packet.loss.percentage', set => {
key_values => [ { name => 'polycomVSPercentPacketLoss' }, { name => 'display' } ], key_values => [ { name => 'polycomVSPercentPacketLoss' }, { name => 'display' } ],
output_template => 'H323 Packet Loss %.2f %%', output_template => 'H323 Packet Loss %.2f %%',
perfdatas => [ perfdatas => [
{ label => 'vs_packet_loss', value => 'polycomVSPercentPacketLoss', template => '%.2f', { value => 'polycomVSPercentPacketLoss', template => '%.2f',
min => 0, max => 100, unit => '%' }, min => 0, max => 100, unit => '%' }
], ]
} }
}, },
{ label => 'h323-jitter', nlabel => 'viewstation.h323.jitter.milliseconds', set => { { label => 'h323-jitter', nlabel => 'viewstation.h323.jitter.milliseconds', set => {
key_values => [ { name => 'polycomVSJitter' }, { name => 'display' } ], key_values => [ { name => 'polycomVSJitter' }, { name => 'display' } ],
output_template => 'H323 (audio/video) Jitter %.2f ms', output_template => 'H323 (audio/video) Jitter %.2f ms',
perfdatas => [ perfdatas => [
{ label => 'vs_packet_loss', value => 'polycomVSJitter', template => '%.2f', { value => 'polycomVSJitter', template => '%.2f',
min => 0, max => 100, unit => 'ms' }, min => 0, max => 100, unit => 'ms' }
], ]
} }
}, },
{ label => 'h323-latency', nlabel => 'viewstation.h323.latency.count', set => { { label => 'h323-latency', nlabel => 'viewstation.h323.latency.count', set => {
@ -55,10 +56,10 @@ sub set_counters {
output_template => 'H323 (audio/video) Latency %.2f', output_template => 'H323 (audio/video) Latency %.2f',
perfdatas => [ perfdatas => [
{ label => 'vs_latency', value => 'polycomVSLatency', template => '%.2f', { label => 'vs_latency', value => 'polycomVSLatency', template => '%.2f',
min => 0, max => 100, unit => '' }, min => 0, max => 100, unit => '' }
], ]
}
} }
},
]; ];
} }
@ -73,8 +74,7 @@ sub new {
my $self = $class->SUPER::new(package => __PACKAGE__, %options); my $self = $class->SUPER::new(package => __PACKAGE__, %options);
bless $self, $class; bless $self, $class;
$options{options}->add_options(arguments => { $options{options}->add_options(arguments => {});
});
return $self; return $self;
} }
@ -87,18 +87,23 @@ sub manage_selection {
my $oid_polycomVSJitter = '.1.3.6.1.4.1.2684.1.1.22.0'; my $oid_polycomVSJitter = '.1.3.6.1.4.1.2684.1.1.22.0';
my $oid_polycomVSLatency = '.1.3.6.1.4.1.2684.1.1.23.0'; my $oid_polycomVSLatency = '.1.3.6.1.4.1.2684.1.1.23.0';
my $result = $options{snmp}->get_leef(oids => [$oid_polycomVSPhoneNumber, $oid_polycomVSPercentPacketLoss, my $result = $options{snmp}->get_leef(
$oid_polycomVSJitter, $oid_polycomVSLatency], oids => [
nothing_quit => 1); $oid_polycomVSPhoneNumber,
$oid_polycomVSPercentPacketLoss,
$oid_polycomVSJitter,
$oid_polycomVSLatency
],
nothing_quit => 1
);
$self->{global} = { $self->{global} = {
display => $result->{$oid_polycomVSPhoneNumber}, display => $result->{$oid_polycomVSPhoneNumber},
polycomVSPercentPacketLoss => $result->{$oid_polycomVSPercentPacketLoss}, polycomVSPercentPacketLoss => $result->{$oid_polycomVSPercentPacketLoss},
polycomVSJitter => $result->{$oid_polycomVSJitter}, polycomVSJitter => $result->{$oid_polycomVSJitter},
polycomVSLatency => $result->{$oid_polycomVSLatency}, polycomVSLatency => $result->{$oid_polycomVSLatency}
}; };
} }
1; 1;
__END__ __END__
@ -109,9 +114,9 @@ Check HDX ViewStation statistics during H323 communications
=over 8 =over 8
=item B<--warning-* --critical> =item B<--warning-* --critical-*>
Warning and Critical Thresholds. Warning and Critical thresholds.
Possible values are: h323-packet-loss, h323-jitter, h323-latency Possible values are: h323-packet-loss, h323-jitter, h323-latency
=back =back

2
hardware/devices/polycom/hdx/snmp/plugin.pm
View File

@ -36,7 +36,7 @@ sub new {
'load' => 'snmp_standard::mode::loadaverage', 'load' => 'snmp_standard::mode::loadaverage',
'memory ' => 'snmp_standard::mode::memory', 'memory ' => 'snmp_standard::mode::memory',
'uptime' => 'snmp_standard::mode::uptime', 'uptime' => 'snmp_standard::mode::uptime',
'viewstation-stats' => 'hardware::devices::polycom::hdx::snmp::mode::viewstationstats', 'viewstation-stats' => 'hardware::devices::polycom::hdx::snmp::mode::viewstationstats'
); );
return $self; return $self;