From 9ba52324168c2f30b2bc17bf24341a7cb463d4d3 Mon Sep 17 00:00:00 2001
From: garnier-quentin <garnier.quentin@gmail.com>
Date: Wed, 10 Jul 2019 10:17:17 +0200
Subject: [PATCH] Fix  #1559

---
 apps/vmware/connector/mode/snapshotvm.pm | 76 ++++++++++++++++--------
 1 file changed, 52 insertions(+), 24 deletions(-)

diff --git a/apps/vmware/connector/mode/snapshotvm.pm b/apps/vmware/connector/mode/snapshotvm.pm
index 2cf945016..67f6a07b7 100644
--- a/apps/vmware/connector/mode/snapshotvm.pm
+++ b/apps/vmware/connector/mode/snapshotvm.pm
@@ -32,25 +32,28 @@ sub new {
     bless $self, $class;
     
     $options{options}->add_options(arguments => {
-        "vm-hostname:s"         => { name => 'vm_hostname' },
-        "filter"                => { name => 'filter' },
-        "scope-datacenter:s"    => { name => 'scope_datacenter' },
-        "scope-cluster:s"       => { name => 'scope_cluster' },
-        "scope-host:s"          => { name => 'scope_host' },
-        "filter-description:s"  => { name => 'filter_description' },
-        "filter-os:s"           => { name => 'filter_os' },
-        "filter-uuid:s"         => { name => 'filter_uuid' },
-        "display-description"   => { name => 'display_description' },
-        "check-consolidation"   => { name => 'check_consolidation' },
-        "nopoweredon-skip"      => { name => 'nopoweredon_skip' },
-        "warning:s"             => { name => 'warning' },
-        "critical:s"            => { name => 'critical' },
-        "disconnect-status:s"   => { name => 'disconnect_status', default => 'unknown' },
+        'vm-hostname:s'         => { name => 'vm_hostname' },
+        'filter'                => { name => 'filter' },
+        'scope-datacenter:s'    => { name => 'scope_datacenter' },
+        'scope-cluster:s'       => { name => 'scope_cluster' },
+        'scope-host:s'          => { name => 'scope_host' },
+        'filter-description:s'  => { name => 'filter_description' },
+        'filter-os:s'           => { name => 'filter_os' },
+        'filter-uuid:s'         => { name => 'filter_uuid' },
+        'display-description'   => { name => 'display_description' },
+        'check-consolidation'   => { name => 'check_consolidation' },
+        'nopoweredon-skip'      => { name => 'nopoweredon_skip' },
+        'warning:s'             => { name => 'warning' },
+        'critical:s'            => { name => 'critical' },
+        'disconnect-status:s'   => { name => 'disconnect_status', default => 'unknown' },
+        'unit:s'                => { name => 'unit', default => 's' },
     });
     
     return $self;
 }
 
+my $unitdiv = { s => ['seconds', 1], w => ['weeks', 604800], d => ['days', 86400], h => ['hours', 3600], m => ['minutes', 60] };
+
 sub check_options {
     my ($self, %options) = @_;
     $self->SUPER::init(%options);
@@ -68,6 +71,10 @@ sub check_options {
         $self->{output}->add_option_msg(short_msg => "Wrong disconnect-status option '" . $self->{option_results}->{disconnect_status} . "'.");
         $self->{output}->option_exit();
     }
+
+    if ($self->{option_results}->{unit} eq '' || !defined($unitdiv->{$self->{option_results}->{unit}})) {
+        $self->{option_results}->{unit} = 's';
+    }
 }
 
 sub run {
@@ -119,7 +126,7 @@ sub run {
             
             my $diff_time = time() - $create_time;
             my $days = int($diff_time / 60 / 60 / 24);
-            my $exit = $self->{perfdata}->threshold_check(value => $diff_time, threshold => [ { label => 'critical', exit_litteral => 'critical' }, { label => 'warning', exit_litteral => 'warning' } ]);
+            my $exit = $self->{perfdata}->threshold_check(value => ($diff_time / $unitdiv->{$self->{option_results}->{unit}}->[1]), threshold => [ { label => 'critical', exit_litteral => 'critical' }, { label => 'warning', exit_litteral => 'warning' } ]);
             
             my $prefix_msg = "'$vm_name'";
             if (defined($self->{display_description}) && defined($response->{data}->{$vm_id}->{'config.annotation'}) &&
@@ -150,19 +157,35 @@ sub run {
         min => 0
     );
     if (scalar(keys %{$vm_errors{warning}}) > 0) {
-        $self->{output}->output_add(severity => 'WARNING',
-                                    short_msg => sprintf('Snapshots for VM older than %d days: [%s]', ($self->{option_results}->{warning} / 86400), 
-                                                         join('] [', sort keys %{$vm_errors{warning}})));
+        $self->{output}->output_add(
+            severity => 'WARNING',
+            short_msg => sprintf(
+                'Snapshots for VM older than %d %s: [%s]',
+                $self->{option_results}->{warning},
+                $unitdiv->{$self->{option_results}->{unit}}->[0],
+                join('] [', sort keys %{$vm_errors{warning}})
+            )
+        );
     }
     if (scalar(keys %{$vm_errors{critical}}) > 0) {
-        $self->{output}->output_add(severity => 'CRITICAL',
-                                    short_msg => sprintf('Snapshots for VM older than %d days: [%s]', ($self->{option_results}->{critical} / 86400), 
-                                                         join('] [', sort keys %{$vm_errors{critical}})));
+        $self->{output}->output_add(
+            severity => 'CRITICAL',
+            short_msg => sprintf(
+                'Snapshots for VM older than %d %s: [%s]',
+                $self->{option_results}->{critical}, 
+                $unitdiv->{$self->{option_results}->{unit}}->[0],
+                join('] [', sort keys %{$vm_errors{critical}})
+            )
+        );
     }
     if (scalar(keys %vm_consolidate) > 0) {
-         $self->{output}->output_add(severity => 'CRITICAL',
-                                     short_msg => sprintf('VMs need consolidation: [%s]',
-                                                          join('] [', sort keys %vm_consolidate)));
+         $self->{output}->output_add(
+            severity => 'CRITICAL',
+            short_msg => sprintf(
+                'VMs need consolidation: [%s]',
+                join('] [', sort keys %vm_consolidate)
+            )
+        );
     }
     
     $self->{output}->display();
@@ -224,6 +247,11 @@ Status if VM disconnected (default: 'unknown').
 
 Skip check if VM is not poweredOn.
 
+=item B<--unit>
+
+Select the unit for performance data and thresholds. May be 's' for seconds, 'm' for minutes,
+'h' for hours, 'd' for days, 'w' for weeks. Default is seconds
+
 =item B<--warning>
 
 Threshold warning in seconds.