mirror of
https://github.com/centreon/centreon-plugins.git
synced 2025-07-30 00:55:18 +02:00
fix(azure-elasticpool): the thresholds weren't applied correctly in storage mode (#5294)
Refs: CTOR-858
This commit is contained in:
omercier
GitHub
parent
b42a281cdf
commit
9cee92778f
@ -56,8 +56,9 @@ sub custom_metric_calc {
|
|||||||
my ($self, %options) = @_;
|
my ($self, %options) = @_;
|
||||||
|
|
||||||
$self->{result_values}->{timeframe} = $options{new_datas}->{$self->{instance} . '_timeframe'};
|
$self->{result_values}->{timeframe} = $options{new_datas}->{$self->{instance} . '_timeframe'};
|
||||||
$self->{result_values}->{value} = $options{new_datas}->{$self->{instance} . '_' . $options{extra_options}->{metric}};
|
$self->{result_values}->{value} = $options{new_datas}->{$self->{instance} . '_' . $options{extra_options}->{metric}};
|
||||||
$self->{result_values}->{metric} = $options{extra_options}->{metric};
|
$self->{result_values}->{metric} = $options{extra_options}->{metric};
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -67,8 +68,8 @@ sub custom_metric_threshold {
|
|||||||
my $exit = $self->{perfdata}->threshold_check(
|
my $exit = $self->{perfdata}->threshold_check(
|
||||||
value => $self->{result_values}->{value},
|
value => $self->{result_values}->{value},
|
||||||
threshold => [
|
threshold => [
|
||||||
{ label => 'critical-' . $metrics_mapping{$self->{result_values}->{metric}}->{label} , exit_litteral => 'critical' },
|
{ label => 'critical-' . $self->{thlabel}, exit_litteral => 'critical' },
|
||||||
{ label => 'warning-' . $metrics_mapping{$self->{result_values}->{metric}}->{label}, exit_litteral => 'warning' }
|
{ label => 'warning-' . $self->{thlabel}, exit_litteral => 'warning' }
|
||||||
]
|
]
|
||||||
);
|
);
|
||||||
return $exit;
|
return $exit;
|
||||||
@ -82,8 +83,8 @@ sub custom_metric_perfdata {
|
|||||||
nlabel => $metrics_mapping{$self->{result_values}->{metric}}->{nlabel},
|
nlabel => $metrics_mapping{$self->{result_values}->{metric}}->{nlabel},
|
||||||
unit => $metrics_mapping{$self->{result_values}->{metric}}->{unit},
|
unit => $metrics_mapping{$self->{result_values}->{metric}}->{unit},
|
||||||
value => sprintf('%.2f', $self->{result_values}->{value}),
|
value => sprintf('%.2f', $self->{result_values}->{value}),
|
||||||
warning => $self->{perfdata}->get_perfdata_for_output(label => 'warning-' . $metrics_mapping{$self->{result_values}->{metric}}->{label}),
|
warning => $self->{perfdata}->get_perfdata_for_output(label => 'warning-' . $self->{thlabel}),
|
||||||
critical => $self->{perfdata}->get_perfdata_for_output(label => 'critical-' . $metrics_mapping{$self->{result_values}->{metric}}->{label})
|
critical => $self->{perfdata}->get_perfdata_for_output(label => 'critical-' . $self->{thlabel})
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -112,7 +113,7 @@ sub prefix_statistics_output {
|
|||||||
sub long_output {
|
sub long_output {
|
||||||
my ($self, %options) = @_;
|
my ($self, %options) = @_;
|
||||||
|
|
||||||
return "Checking Pool'" . $options{instance_value}->{display} . "' ";
|
return "Checking Pool '" . $options{instance_value}->{display} . "' ";
|
||||||
}
|
}
|
||||||
|
|
||||||
sub set_counters {
|
sub set_counters {
|
||||||
@ -128,7 +129,7 @@ sub set_counters {
|
|||||||
}
|
}
|
||||||
];
|
];
|
||||||
|
|
||||||
foreach my $metric (keys %metrics_mapping) {
|
foreach my $metric (sort keys %metrics_mapping) {
|
||||||
my $entry = {
|
my $entry = {
|
||||||
label => $metrics_mapping{$metric}->{label},
|
label => $metrics_mapping{$metric}->{label},
|
||||||
nlabel => $metrics_mapping{$metric}->{nlabel},
|
nlabel => $metrics_mapping{$metric}->{nlabel},
|
||||||
@ -186,8 +187,8 @@ sub check_options {
|
|||||||
}
|
}
|
||||||
|
|
||||||
foreach my $metric (keys %metrics_mapping) {
|
foreach my $metric (keys %metrics_mapping) {
|
||||||
next if (defined($self->{option_results}->{filter_metric}) && $self->{option_results}->{filter_metric} ne ''
|
next if ( !centreon::plugins::misc::is_empty($self->{option_results}->{filter_metric})
|
||||||
&& $metric !~ /$self->{option_results}->{filter_metric}/);
|
&& $metric !~ /$self->{option_results}->{filter_metric}/ );
|
||||||
|
|
||||||
push @{$self->{az_metrics}}, $metric;
|
push @{$self->{az_metrics}}, $metric;
|
||||||
}
|
}
|
||||||
@ -254,48 +255,72 @@ __END__
|
|||||||
|
|
||||||
=head1 MODE
|
=head1 MODE
|
||||||
|
|
||||||
Check Azure SQL Elastic Pool Storage metrics.
|
Monitor Azure SQL Elastic Pool Storage metrics.
|
||||||
|
|
||||||
Example:
|
Example:
|
||||||
|
|
||||||
Using resource name:
|
Using resource name:
|
||||||
|
|
||||||
perl centreon_plugins.pl --plugin=cloud::azure::database::elasticpool::plugin --custommode=azcli --mode=storage
|
perl centreon_plugins.pl --plugin=cloud::azure::database::elasticpool::plugin --custommode=azcli --mode=storage
|
||||||
--resource=<sqlserver>/elasticpools/<elasticpool> --resource-group=<resourcegroup> --aggregation='average'
|
--resource=<sqlserver>/elasticpools/<elasticpool> --resource-group=<resourcegroup> --aggregation='average'
|
||||||
--allocated-data-storage-percent='90' --verbose
|
--allocated-data-storage-percent='90' --verbose
|
||||||
|
|
||||||
Using resource ID:
|
Using resource ID:
|
||||||
|
|
||||||
perl centreon_plugins.pl --plugin=cloud::azure::compute::virtualmachine::plugin --custommode=azcli --mode=sessions
|
perl centreon_plugins.pl --plugin=cloud::azure::compute::virtualmachine::plugin --custommode=azcli --mode=sessions
|
||||||
--resource='/subscriptions/xxx/resourceGroups/xxx/providers/Microsoft.Sql/servers/xxx/elasticpools/xxx'
|
--resource='/subscriptions/xxx/resourceGroups/xxx/providers/Microsoft.Sql/servers/xxx/elasticpools/xxx'
|
||||||
--aggregation='average' --allocated-data-storage-percent='90' --verbose
|
--aggregation='average' --allocated-data-storage-percent='90' --verbose
|
||||||
|
|
||||||
Default aggregation: 'average' / 'minimum' and 'maximum' are valid.
|
Available aggregations: 'average' (default) 'minimum' and 'maximum'.
|
||||||
|
|
||||||
=over 8
|
=over 8
|
||||||
|
|
||||||
=item B<--resource>
|
=item B<--resource>
|
||||||
|
|
||||||
Set resource name or ID (required).
|
Define the resource name or ID (required).
|
||||||
|
|
||||||
=item B<--resource-group>
|
=item B<--resource-group>
|
||||||
|
|
||||||
Set resource group (required if resource's name is used).
|
Define the resource group to monitor (required if the resource name is used).
|
||||||
|
|
||||||
=item B<--filter-metric>
|
=item B<--filter-metric>
|
||||||
|
|
||||||
Filter on specific metrics. The Azure format must be used, for example: 'allocated_data_storage_percent'
|
Filter on specific metrics. The Azure format must be used, for example: 'allocated_data_storage_percent'
|
||||||
(can be a regexp).
|
(can be a regexp).
|
||||||
|
|
||||||
=item B<--warning-*>
|
=item B<--warning-allocated-data-storage>
|
||||||
|
|
||||||
Warning threshold where * can be: 'allocated-data-storage', allocated-data-storage-percent',
|
Thresholds.
|
||||||
'storage-percent', 'storage-used'.
|
|
||||||
|
|
||||||
=item B<--critical-*>
|
=item B<--critical-allocated-data-storage>
|
||||||
|
|
||||||
|
Thresholds.
|
||||||
|
|
||||||
|
=item B<--warning-allocated-data-storage-percent>
|
||||||
|
|
||||||
|
Thresholds.
|
||||||
|
|
||||||
|
=item B<--critical-allocated-data-storage-percent>
|
||||||
|
|
||||||
|
Thresholds.
|
||||||
|
|
||||||
|
|
||||||
|
=item B<--warning-storage-percent>
|
||||||
|
|
||||||
|
Thresholds.
|
||||||
|
|
||||||
|
=item B<--critical-storage-percent>
|
||||||
|
|
||||||
|
Thresholds.
|
||||||
|
|
||||||
|
=item B<--warning-storage-used>
|
||||||
|
|
||||||
|
Thresholds.
|
||||||
|
|
||||||
|
=item B<--critical-storage-used>
|
||||||
|
|
||||||
|
Thresholds.
|
||||||
|
|
||||||
Critical threshold where * can be: 'allocated-data-storage', allocated-data-storage-percent',
|
|
||||||
'storage-percent', 'storage-used'.
|
|
||||||
|
|
||||||
=back
|
=back
|
||||||
|
|
||||||
|
|||||||
270
tests/cloud/azure/database/elasticpool/mockoon.json
Normal file
270
tests/cloud/azure/database/elasticpool/mockoon.json
Normal file
File diff suppressed because one or more lines are too long
40
tests/cloud/azure/database/elasticpool/storage.robot
Normal file
40
tests/cloud/azure/database/elasticpool/storage.robot
Normal file
@ -0,0 +1,40 @@
|
|||||||
|
*** Settings ***
|
||||||
|
Documentation Azure Database Elasticpool plugin
|
||||||
|
|
||||||
|
Resource ${CURDIR}${/}..${/}..${/}..${/}..${/}resources/import.resource
|
||||||
|
|
||||||
|
Suite Setup Start Mockoon ${MOCKOON_JSON}
|
||||||
|
Suite Teardown Stop Mockoon
|
||||||
|
Test Timeout 120s
|
||||||
|
|
||||||
|
|
||||||
|
*** Variables ***
|
||||||
|
${MOCKOON_JSON} ${CURDIR}${/}mockoon.json
|
||||||
|
|
||||||
|
${BASE_URL} http://${HOSTNAME}:${APIPORT}
|
||||||
|
${LOGIN_ENDPOINT} ${BASE_URL}/login
|
||||||
|
${CMD} ${CENTREON_PLUGINS} --plugin=cloud::azure::database::elasticpool::plugin --custommode=api --mode=storage --subscription=subscription --tenant=tenant --client-id=client_id --client-secret=secret --login-endpoint=${LOGIN_ENDPOINT} --management-endpoint=${BASE_URL}
|
||||||
|
|
||||||
|
|
||||||
|
*** Test Cases ***
|
||||||
|
Storage ${tc}
|
||||||
|
[Tags] cloud azure api mockoon
|
||||||
|
${command} Catenate
|
||||||
|
... ${CMD}
|
||||||
|
... --resource=${resource}
|
||||||
|
... --resource-group=${resource_group}
|
||||||
|
... ${thresholds}
|
||||||
|
|
||||||
|
Ctn Run Command And Check Result As Strings ${command} ${expected_result}
|
||||||
|
|
||||||
|
Examples: tc resource resource_group thresholds expected_result --
|
||||||
|
... 1 sql-bb-stsw-prod-do/elasticpools/sql-epool-bb-psme-prod-do emsp-tf-prod-va-rg ${EMPTY} OK: Elastic Pool 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do' Statistic 'average' Metrics Allocated data storage: 201.00 GB, Allocated data storage percentage: 67.00 %, Storage usage percentage: 38.00 %, Storage usage: 114.00 GB | 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.bytes'=215822106624.00B;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.percentage'=67.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.usage.percentage'=38.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.used.bytes'=122406567936.00B;;;;
|
||||||
|
... 2 sql-bb-stsw-prod-do/elasticpools/sql-epool-bb-psme-prod-do emsp-tf-prod-va-rg --warning-allocated-data-storage-percent=0.01 WARNING: Elastic Pool 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do' Statistic 'average' Metrics Allocated data storage percentage: 67.00 % | 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.bytes'=215822106624.00B;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.percentage'=67.00%;0:0.01;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.usage.percentage'=38.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.used.bytes'=122406567936.00B;;;;
|
||||||
|
... 3 sql-bb-stsw-prod-do/elasticpools/sql-epool-bb-psme-prod-do emsp-tf-prod-va-rg --critical-allocated-data-storage-percent=0.01 CRITICAL: Elastic Pool 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do' Statistic 'average' Metrics Allocated data storage percentage: 67.00 % | 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.bytes'=215822106624.00B;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.percentage'=67.00%;;0:0.01;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.usage.percentage'=38.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.used.bytes'=122406567936.00B;;;;
|
||||||
|
... 4 sql-bb-stsw-prod-do/elasticpools/sql-epool-bb-psme-prod-do emsp-tf-prod-va-rg --warning-allocated-data-storage=0.01 WARNING: Elastic Pool 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do' Statistic 'average' Metrics Allocated data storage: 201.00 GB | 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.bytes'=215822106624.00B;0:0.01;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.percentage'=67.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.usage.percentage'=38.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.used.bytes'=122406567936.00B;;;;
|
||||||
|
... 5 sql-bb-stsw-prod-do/elasticpools/sql-epool-bb-psme-prod-do emsp-tf-prod-va-rg --critical-allocated-data-storage=0.01 CRITICAL: Elastic Pool 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do' Statistic 'average' Metrics Allocated data storage: 201.00 GB | 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.bytes'=215822106624.00B;;0:0.01;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.percentage'=67.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.usage.percentage'=38.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.used.bytes'=122406567936.00B;;;;
|
||||||
|
... 6 sql-bb-stsw-prod-do/elasticpools/sql-epool-bb-psme-prod-do emsp-tf-prod-va-rg --warning-storage-percent=0.01 WARNING: Elastic Pool 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do' Statistic 'average' Metrics Storage usage percentage: 38.00 % | 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.bytes'=215822106624.00B;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.percentage'=67.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.usage.percentage'=38.00%;0:0.01;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.used.bytes'=122406567936.00B;;;;
|
||||||
|
... 7 sql-bb-stsw-prod-do/elasticpools/sql-epool-bb-psme-prod-do emsp-tf-prod-va-rg --critical-storage-percent=0.01 CRITICAL: Elastic Pool 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do' Statistic 'average' Metrics Storage usage percentage: 38.00 % | 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.bytes'=215822106624.00B;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.percentage'=67.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.usage.percentage'=38.00%;;0:0.01;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.used.bytes'=122406567936.00B;;;;
|
||||||
|
... 8 sql-bb-stsw-prod-do/elasticpools/sql-epool-bb-psme-prod-do emsp-tf-prod-va-rg --warning-storage-used=0.01 WARNING: Elastic Pool 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do' Statistic 'average' Metrics Storage usage: 114.00 GB | 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.bytes'=215822106624.00B;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.percentage'=67.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.usage.percentage'=38.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.used.bytes'=122406567936.00B;0:0.01;;;
|
||||||
|
... 9 sql-bb-stsw-prod-do/elasticpools/sql-epool-bb-psme-prod-do emsp-tf-prod-va-rg --critical-storage-used=0.01 CRITICAL: Elastic Pool 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do' Statistic 'average' Metrics Storage usage: 114.00 GB | 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.bytes'=215822106624.00B;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.data.allocated.percentage'=67.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.usage.percentage'=38.00%;;;; 'sql-bb-stsw-prod-do/sql-epool-bb-psme-prod-do~average#elasticpool.storage.used.bytes'=122406567936.00B;;0:0.01;;
|
||||||
|
... 10 ${EMPTY} ${EMPTY} ${EMPTY} UNKNOWN: Incorrect resource format
|
||||||
Loading…
x
Reference in New Issue
Block a user