tyler.durden
/
centreon-plugins
mirror of https://github.com/centreon/centreon-plugins.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[MON-22338] [Plugins] Improve the troubleshooting of HTTP Collections (#4708) 

Co-authored-by: omercier <omercier@centreon.com>
This commit is contained in:
Lucie Dubrunfaut 2023-11-08 09:35:30 +01:00 committed by GitHub
parent bea1844582
commit a307023353
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 51 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

69
src/apps/protocols/http/mode/collection.pm
View File

@ -203,11 +203,11 @@ sub validate_name {
my ($self, %options) = @_;
if (!defined($options{name})) {
$self->{output}->add_option_msg(short_msg => "name attribute is missing $options{section}");
$self->{output}->add_option_msg(short_msg => "name attribute is missing in your http collection (path: $options{section})");
$self->{output}->option_exit();
}
if ($options{name} !~ /^[a-zA-Z0-9]+$/) {
$self->{output}->add_option_msg(short_msg => 'incorrect name attribute: ' . $options{name});
$self->{output}->add_option_msg(short_msg => "name attribute in your http collection (path: $options{section}) is incorrect: " . $options{name});
$self->{output}->option_exit();
}
}
@ -218,7 +218,7 @@ sub get_payload {
return if (!defined($options{rq}->{payload}) || !defined($options{rq}->{payload}->{type}));
if ($options{rq}->{payload}->{type} !~ /^(?:file|data|json)$/) {
$self->{output}->add_option_msg(short_msg => "type attribute is wrong [http > requests > $options{rq}->{name} > payload]");
$self->{output}->add_option_msg(short_msg => "type attribute is wrong [http > requests > $options{rq}->{name} > payload] (allowed types: file / data / json)");
$self->{output}->option_exit();
}
@ -230,7 +230,7 @@ sub get_payload {
my $content;
if ($options{rq}->{payload}->{type} eq 'file') {
if (ref($options{rq}->{payload}->{value}) ne '' || $options{rq}->{payload}->{value} eq '') {
$self->{output}->add_option_msg(short_msg => "value attribute is wrong [http > requests > $options{rq}->{name} > payload]");
$self->{output}->add_option_msg(short_msg => "value attribute is wrong for file type [http > requests > $options{rq}->{name} > payload]");
$self->{output}->option_exit();
}
@ -243,7 +243,7 @@ sub get_payload {
};
if ($@) {
$self->{output}->output_add(long_msg => "json payload error: $@", debug => 1);
$self->{output}->add_option_msg(short_msg => "cannot encode json payload [http > requests > $options{rq}->{name} > payload]");
$self->{output}->add_option_msg(short_msg => "cannot encode json type payload [http > requests > $options{rq}->{name} > payload]");
$self->{output}->option_exit();
}
}
@ -337,6 +337,10 @@ sub call_http {
$self->{output}->option_exit();
}
my $encoded = JSON::XS->new->utf8->pretty->encode($content);
$self->{output}->output_add(long_msg => '======> returned JSON structure:', debug => 1);
$self->{output}->output_add(long_msg => "$encoded", debug => 1);
return ($http->get_header(), $content, $http);
}
@ -455,11 +459,23 @@ sub parse_structure {
my $ref = ref($value);
if ($ref eq 'HASH') {
if (!defined($value->{ $_->{id} })) {
$entry->{ $_->{id} } = '';
next;
# Check and assume in case of hash reference first part is the hash ref and second the hash key
if($_->{id} =~ /^(.+?)\.(.*)$/){
if (!defined($value->{$1}->{$2})) {
$entry->{ $_->{id} } = '';
next;
}else{
$entry->{ $_->{id} } = $value->{$1}->{$2};
}
}else {
$entry->{ $_->{id} } = '';
next;
}
}else {
$entry->{ $_->{id} } = $value->{ $_->{id} };
}
$entry->{ $_->{id} } = $value->{ $_->{id} };
} elsif (ref($value) eq 'ARRAY') {
next;
} elsif ($ref eq '' || $ref eq 'JSON::PP::Boolean') {
@ -764,7 +780,14 @@ sub exist_table_name {
sub get_local_variable {
my ($self, %options) = @_;
return $self->{expand}->{ $options{name} };
if (defined( $self->{expand}->{ $options{name} })) {
return $self->{expand}->{ $options{name} };
} else {
$self->{output}->add_option_msg(short_msg => "Key '" . $options{name} . "' not found in ('" . join("', '", keys(%{$self->{expand}})) . "')", debug => 1);
return undef;
}
}
sub set_local_variable {
@ -776,19 +799,24 @@ sub set_local_variable {
sub get_table {
my ($self, %options) = @_;
return undef if (
!defined($self->{http_collected}->{tables}->{ $options{table} })
);
if (!defined($self->{http_collected}->{tables}->{ $options{table} })) {
$self->{output}->add_option_msg(short_msg => "Table '" . $options{table} . "' not found in ('" . join("', '", keys(%{$self->{http_collected}->{tables}})) . "')", debug => 1);
return undef;
}
return $self->{http_collected}->{tables}->{ $options{table} };
}
sub get_table_instance {
my ($self, %options) = @_;
return undef if (
!defined($self->{http_collected}->{tables}->{ $options{table} }) ||
!defined($self->{http_collected}->{tables}->{ $options{table} }->{ $options{instance} })
);
if (!defined($self->{http_collected}->{tables}->{ $options{table} })) {
$self->{output}->add_option_msg(short_msg => "Table '" . $options{table} . "' not found in ('" . join("', '", keys(%{$self->{http_collected}->{tables}})) . "')", debug => 1);
return undef;
}
if (!defined($self->{http_collected}->{tables}->{ $options{table} }->{ $options{instance} })) {
$self->{output}->add_option_msg(short_msg => "Table '" . $options{instance} . "' not found in ('" . join("', '", keys(%{$self->{http_collected}->{tables}->{ $options{table} }})) . "')", debug => 1);
return undef;
}
return $self->{http_collected}->{tables}->{ $options{table} }->{ $options{instance} };
}
@ -914,7 +942,8 @@ sub parse_http_tables {
$self->{output}->option_exit();
}
if (!$self->exist_table_name(name => $table_label)) {
$self->{output}->add_option_msg(short_msg => $self->{current_section} . " unknown table '$table_label'");
my @names = keys %{$self->{http_collected}->{tables}};
$self->{output}->add_option_msg(short_msg => $self->{current_section} . " unknown or empty table '$table_label'. Available tables are (not empty based on your conf) : @names");
$self->{output}->option_exit();
}
if ($options{chars}->[$end] eq ')') {
@ -1721,8 +1750,12 @@ sub check_filter2 {
sub check_filter_option {
my ($self, %options) = @_;
foreach (keys %{$self->{option_results}->{filter_selection}}) {
if(!defined($self->{expand}->{$_}) && grep {/^src\./} keys(%{$self->{expand}}) ne '') {
$self->{output}->add_option_msg(long_msg => "Wrong filter-selection - Available attributes for filtering: " . join(", ", grep {/^src\./} keys(%{$self->{expand}})), debug => 1);
}
return 1 if (
defined($self->{expand}->{$_}) && $self->{option_results}->{filter_selection}->{$_} ne '' &&
$self->{expand}->{$_} !~ /$self->{option_results}->{filter_selection}->{$_}/