fix useless permission required and improve perf

This commit is contained in:
tanguyvda 2024-10-29 09:54:14 +01:00
parent 938557e2fd
commit af8b65f8f8

View File

@ -270,17 +270,7 @@ sub manage_selection {
my $databases = $options{sql}->fetchall_arrayref();
# limit can be: 'unlimited', 'overload', 'other'.
$self->{databases} = {};
foreach my $database (@$databases) {
my $dbname = $database->[0];
next if (defined($self->{option_results}->{filter_database}) && $self->{option_results}->{filter_database} ne '' &&
$dbname !~ /$self->{option_results}->{filter_database}/i);
next if (defined($self->{option_results}->{filter_database_state}) && $self->{option_results}->{filter_database_state} ne '' &&
$database_state->{ $database->[1] } !~ /$self->{option_results}->{filter_database_state}/);
$options{sql}->query(query => qq{
USE [$dbname]
SELECT
[name],
physical_name,
@ -300,6 +290,15 @@ sub manage_selection {
my $rows = $options{sql}->fetchall_arrayref();
# limit can be: 'unlimited', 'overload', 'other'.
$self->{databases} = {};
foreach my $database (@$databases) {
my $dbname = $database->[0];
next if (defined($self->{option_results}->{filter_database}) && $self->{option_results}->{filter_database} ne '' &&
$dbname !~ /$self->{option_results}->{filter_database}/i);
next if (defined($self->{option_results}->{filter_database_state}) && $self->{option_results}->{filter_database_state} ne '' &&
$database_state->{ $database->[1] } !~ /$self->{option_results}->{filter_database_state}/);
foreach my $row (@$rows) {
next if (!defined($row->[6]));