From b0f582ea6bab252cefb35ff34d465d818e270f3d Mon Sep 17 00:00:00 2001 From: garnier-quentin Date: Tue, 19 Feb 2019 11:17:11 +0100 Subject: [PATCH] optimize snapmirrorlag --- storage/netapp/snmp/mode/snapmirrorlag.pm | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/storage/netapp/snmp/mode/snapmirrorlag.pm b/storage/netapp/snmp/mode/snapmirrorlag.pm index 1dd1e63d6..7d7950b81 100644 --- a/storage/netapp/snmp/mode/snapmirrorlag.pm +++ b/storage/netapp/snmp/mode/snapmirrorlag.pm @@ -146,12 +146,11 @@ sub manage_selection { my $snmp_result = $options{snmp}->get_leef(nothing_quit => 1); $self->{snapmirror} = {}; - foreach my $oid (keys %{$snmp_result}) { - next if ($oid !~ /^$mapping->{snapmirrorLag}->{oid}\.(.*)$/); - my $instance = $1; - my $result = $options{snmp}->map_instance(mapping => $mapping, results => $snmp_result, instance => $instance); - $self->{snapmirror}->{$instance} = { - display => $snmp_result_name->{$oid_snapmirrorSrc . '.' . $instance}, + + foreach (@{$id_selected}) { + my $result = $options{snmp}->map_instance(mapping => $mapping, results => $snmp_result, instance => $_); + $self->{snapmirror}->{$_} = { + display => $snmp_result_name->{$oid_snapmirrorSrc . '.' . $_}, status => $result->{snapmirrorState}, lag => int($result->{snapmirrorLag} / 100), };