From 6a616d006e48dae32cae518d4bb13b9bfa6db92a Mon Sep 17 00:00:00 2001 From: Sims24 Date: Wed, 30 Sep 2015 17:06:38 +0200 Subject: [PATCH 1/4] +add verbose mode to print error content If everything ok we get "Error state: NoError Error code: 0" If something went bad then "Error state: Error code: " --- centreon-plugins/storage/ibm/TS3100/mode/globalstatus.pm | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/centreon-plugins/storage/ibm/TS3100/mode/globalstatus.pm b/centreon-plugins/storage/ibm/TS3100/mode/globalstatus.pm index c75b97cac..4ddf6fd21 100644 --- a/centreon-plugins/storage/ibm/TS3100/mode/globalstatus.pm +++ b/centreon-plugins/storage/ibm/TS3100/mode/globalstatus.pm @@ -88,12 +88,15 @@ sub run { # $options{snmp} = snmp object $self->{snmp} = $options{snmp}; + my $oid_ibm3100FaultError = '.1.3.6.1.4.1.2.6.210.3.1.1.22.1'; + my $oid_ibm3100FaultDesc = '.1.3.6.1.4.1.2.6.210.3.1.1.24.1'; my $oid_ibm3100StatusGlobalStatus = '.1.3.6.1.4.1.2.6.210.2.1.0'; - my $result = $self->{snmp}->get_leef(oids => [$oid_ibm3100StatusGlobalStatus], nothing_quit => 1); + my $result = $self->{snmp}->get_leef(oids => [$oid_ibm3100StatusGlobalStatus, $oid_ibm3100FaultError, $oid_ibm3100FaultDesc], nothing_quit => 1); $self->{output}->output_add(severity => $self->get_severity(value => $result->{$oid_ibm3100StatusGlobalStatus}), short_msg => sprintf("Overall global status is '%s'.", ${$states{$result->{$oid_ibm3100StatusGlobalStatus}}}[0])); + $self->{output}->output_add(long_msg => sprintf("Error state: %s Error code: %i", $result->{$oid_ibm3100FaultDesc}, $result->{$oid_ibm3100FaultError})); $self->{output}->display(); $self->{output}->exit(); @@ -117,4 +120,4 @@ Example: --threshold-overload='(unknown|non critical)=critical' =back =cut - \ No newline at end of file + From 6928bed35d731dfe6f225889b4b0e78a71a9bd27 Mon Sep 17 00:00:00 2001 From: Sims24 Date: Wed, 30 Sep 2015 17:12:20 +0200 Subject: [PATCH 2/4] +add verbose mode to globalstatus.pm Get error code and error description in output to explain global status OID return code --- .../storage/ibm/TS3200/mode/globalstatus.pm | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/centreon-plugins/storage/ibm/TS3200/mode/globalstatus.pm b/centreon-plugins/storage/ibm/TS3200/mode/globalstatus.pm index 78e14ac80..7fc400f31 100644 --- a/centreon-plugins/storage/ibm/TS3200/mode/globalstatus.pm +++ b/centreon-plugins/storage/ibm/TS3200/mode/globalstatus.pm @@ -87,14 +87,16 @@ sub run { my ($self, %options) = @_; # $options{snmp} = snmp object $self->{snmp} = $options{snmp}; - + + my $oid_ibm3100FaultError = '.1.3.6.1.4.1.2.6.211.3.1.1.22.1'; + my $oid_ibm3100FaultDesc = '.1.3.6.1.4.1.2.6.211.3.1.1.24.1'; my $oid_ibm3200StatusGlobalStatus = '.1.3.6.1.4.1.2.6.211.2.1.0'; - my $result = $self->{snmp}->get_leef(oids => [$oid_ibm3200StatusGlobalStatus], nothing_quit => 1); + my $result = $self->{snmp}->get_leef(oids => [$oid_ibm3200StatusGlobalStatus, $oid_ibm3100FaultError, $oid_ibm3100FaultDesc], nothing_quit => 1); $self->{output}->output_add(severity => $self->get_severity(value => $result->{$oid_ibm3200StatusGlobalStatus}), short_msg => sprintf("Overall global status is '%s'.", ${$states{$result->{$oid_ibm3200StatusGlobalStatus}}}[0])); - + $self->{output}->output_add(long_msg => sprintf("Error state: %s Error code: %i", $result->{$oid_ibm3100FaultDesc}, $result->{$oid_ibm3100FaultError})); $self->{output}->display(); $self->{output}->exit(); } @@ -117,4 +119,4 @@ Example: --threshold-overload='(unknown|non critical)=critical' =back =cut - \ No newline at end of file + From 71d52c80ce8639e6dbc4816f030a76fdbc29e0fc Mon Sep 17 00:00:00 2001 From: Sims24 Date: Wed, 30 Sep 2015 17:27:32 +0200 Subject: [PATCH 3/4] Update globalstatus.pm protect in sprintf --- centreon-plugins/storage/ibm/TS3100/mode/globalstatus.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/centreon-plugins/storage/ibm/TS3100/mode/globalstatus.pm b/centreon-plugins/storage/ibm/TS3100/mode/globalstatus.pm index 4ddf6fd21..a59855519 100644 --- a/centreon-plugins/storage/ibm/TS3100/mode/globalstatus.pm +++ b/centreon-plugins/storage/ibm/TS3100/mode/globalstatus.pm @@ -96,7 +96,7 @@ sub run { $self->{output}->output_add(severity => $self->get_severity(value => $result->{$oid_ibm3100StatusGlobalStatus}), short_msg => sprintf("Overall global status is '%s'.", ${$states{$result->{$oid_ibm3100StatusGlobalStatus}}}[0])); - $self->{output}->output_add(long_msg => sprintf("Error state: %s Error code: %i", $result->{$oid_ibm3100FaultDesc}, $result->{$oid_ibm3100FaultError})); + $self->{output}->output_add(long_msg => sprintf("Error state: '%s' Error code: '%i'", $result->{$oid_ibm3100FaultDesc}, $result->{$oid_ibm3100FaultError})); $self->{output}->display(); $self->{output}->exit(); From d4f8b9767e62fa706bf60a62beb057ddfacef23f Mon Sep 17 00:00:00 2001 From: Sims24 Date: Wed, 30 Sep 2015 17:28:24 +0200 Subject: [PATCH 4/4] Update globalstatus.pm fix copy/paste dumb things --- centreon-plugins/storage/ibm/TS3200/mode/globalstatus.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/centreon-plugins/storage/ibm/TS3200/mode/globalstatus.pm b/centreon-plugins/storage/ibm/TS3200/mode/globalstatus.pm index 7fc400f31..98bad6d97 100644 --- a/centreon-plugins/storage/ibm/TS3200/mode/globalstatus.pm +++ b/centreon-plugins/storage/ibm/TS3200/mode/globalstatus.pm @@ -88,15 +88,15 @@ sub run { # $options{snmp} = snmp object $self->{snmp} = $options{snmp}; - my $oid_ibm3100FaultError = '.1.3.6.1.4.1.2.6.211.3.1.1.22.1'; - my $oid_ibm3100FaultDesc = '.1.3.6.1.4.1.2.6.211.3.1.1.24.1'; + my $oid_ibm3200FaultError = '.1.3.6.1.4.1.2.6.211.3.1.1.22.1'; + my $oid_ibm3200FaultDesc = '.1.3.6.1.4.1.2.6.211.3.1.1.24.1'; my $oid_ibm3200StatusGlobalStatus = '.1.3.6.1.4.1.2.6.211.2.1.0'; - my $result = $self->{snmp}->get_leef(oids => [$oid_ibm3200StatusGlobalStatus, $oid_ibm3100FaultError, $oid_ibm3100FaultDesc], nothing_quit => 1); + my $result = $self->{snmp}->get_leef(oids => [$oid_ibm3200StatusGlobalStatus, $oid_ibm3200FaultError, $oid_ibm3200FaultDesc], nothing_quit => 1); $self->{output}->output_add(severity => $self->get_severity(value => $result->{$oid_ibm3200StatusGlobalStatus}), short_msg => sprintf("Overall global status is '%s'.", ${$states{$result->{$oid_ibm3200StatusGlobalStatus}}}[0])); - $self->{output}->output_add(long_msg => sprintf("Error state: %s Error code: %i", $result->{$oid_ibm3100FaultDesc}, $result->{$oid_ibm3100FaultError})); + $self->{output}->output_add(long_msg => sprintf("Error state: '%s' Error code: '%i'", $result->{$oid_ibm3200FaultDesc}, $result->{$oid_ibm3200FaultError})); $self->{output}->display(); $self->{output}->exit(); }