tyler.durden
/
centreon-plugins
mirror of https://github.com/centreon/centreon-plugins.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

enh(plugin)counter refacto for new threshold (#2231) 

* enh(plugin)counter refacto for new threshold

* enh(plugin)fix after QGA review

* enh(plugin)fix after QGA review (goodversion)

* enh(plugin) add counters
This commit is contained in:
Simon Bomm 2020-09-29 17:22:41 +02:00 committed by GitHub
parent 2fe24fdc04
commit b482ee2775
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 42 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
network/versa/director/restapi/mode/devices.pm
View File

@ -79,7 +79,14 @@ sub set_counters {
{ name => 'device_disk', type => 0, skipped_code => { -10 => 1 } }, { name => 'device_disk', type => 0, skipped_code => { -10 => 1 } },
{ name => 'device_alarms', type => 0, cb_prefix_output => 'prefix_alarm_output', skipped_code => { -10 => 1 } }, { name => 'device_alarms', type => 0, cb_prefix_output => 'prefix_alarm_output', skipped_code => { -10 => 1 } },
{ name => 'device_policy', type => 0, cb_prefix_output => 'prefix_policy_output', skipped_code => { -10 => 1 } }, { name => 'device_policy', type => 0, cb_prefix_output => 'prefix_policy_output', skipped_code => { -10 => 1 } },
{ name => 'device_health', display_long => 1, cb_prefix_output => 'prefix_health_output', message_multiple => 'all health monitors are ok', type => 1, skipped_code => { -10 => 1 } }, { name => 'device_bgp_health', cb_prefix_output => 'prefix_health_output', type => 0, skipped_code => { -10 => 1 } },
{ name => 'device_config_health', cb_prefix_output => 'prefix_health_output', type => 0, skipped_code => { -10 => 1 } },
{ name => 'device_ike_health', cb_prefix_output => 'prefix_health_output', type => 0, skipped_code => { -10 => 1 } },
{ name => 'device_interface_health', cb_prefix_output => 'prefix_health_output', type => 0, skipped_code => { -10 => 1 } },
{ name => 'device_port_health', cb_prefix_output => 'prefix_health_output', type => 0, skipped_code => { -10 => 1 } },
{ name => 'device_path_health', cb_prefix_output => 'prefix_health_output', type => 0, skipped_code => { -10 => 1 } },
{ name => 'device_reachability_health', cb_prefix_output => 'prefix_health_output', type => 0, skipped_code => { -10 => 1 } },
{ name => 'device_service_health', cb_prefix_output => 'prefix_health_output', type => 0, skipped_code => { -10 => 1 } },
] ]
} }
]; ];
@ -196,32 +203,20 @@ sub set_counters {
} }
]; ];
$self->{maps_counters}->{device_health} = [ foreach my $monitor (('bgp', 'config', 'ike', 'interface', 'port', 'path', 'reachability', 'service')) {
{ label => 'health-up', nlabel => 'health.up.count', set => { foreach my $status (('up', 'down', 'disabled')) {
key_values => [ { name => 'up' }, { name => 'total' }, { name => 'display' } ], push @{$self->{maps_counters}->{$monitor}}, {
output_template => 'up: %s', label => $monitor . '-health-' . $status, nlabel => 'health.' . $status . '.count',
set => {
key_values => [ { name => $status }, { name => 'display' } ],
output_template => $status . ': %s',
perfdatas => [ perfdatas => [
{ template => '%s', min => 0, max => 'total', label_extra_instance => 1 } { template => '%d', min => 0, label_extra_instance => 1 }
] ]
} }
}, };
{ label => 'health-down', nlabel => 'health.down.count', set => {
key_values => [ { name => 'down' }, { name => 'total' }, { name => 'display' } ],
output_template => 'down: %s',
perfdatas => [
{ template => '%s', min => 0, max => 'total', label_extra_instance => 1 }
]
}
},
{ label => 'health-disabled', nlabel => 'health.disabled.count', set => {
key_values => [ { name => 'disabled' }, { name => 'total' }, { name => 'display' } ],
output_template => 'disabled: %s',
perfdatas => [
{ template => '%s', min => 0, max => 'total', label_extra_instance => 1 }
]
} }
} }
];
} }
sub device_long_output { sub device_long_output {
@ -298,6 +293,7 @@ sub manage_selection {
$self->{global} = { total => 0 }; $self->{global} = { total => 0 };
$self->{devices} = {}; $self->{devices} = {};
foreach my $device (@$devices) { foreach my $device (@$devices) {
if (defined($self->{option_results}->{filter_device_name}) && $self->{option_results}->{filter_device_name} ne '' && if (defined($self->{option_results}->{filter_device_name}) && $self->{option_results}->{filter_device_name} ne '' &&
$device->{name} !~ /$self->{option_results}->{filter_device_name}/) { $device->{name} !~ /$self->{option_results}->{filter_device_name}/) {
@ -383,8 +379,19 @@ sub manage_selection {
$self->{devices}->{ $device->{name} }->{device_alarms}->{ lc($_->{firstColumnValue}) } = $_->{columnValues}->[0]; $self->{devices}->{ $device->{name} }->{device_alarms}->{ lc($_->{firstColumnValue}) } = $_->{columnValues}->[0];
} }
my $health_mapping = {
'BGP Adjacencies' => 'device_bgp_health',
'Config Sync Status' => 'device_config_health',
'IKE Status' => 'device_ike_health',
'Interfaces' => 'device_interface_health',
'Paths' => 'device_path_health',
'Physical Ports' => 'device_port_health',
'Reachability Status' => 'device_reachability_health',
'Service Status' => 'device_service_health'
};
foreach (@{$device->{cpeHealth}->{rows}}) { foreach (@{$device->{cpeHealth}->{rows}}) {
$self->{devices}->{ $device->{name} }->{device_health}->{ lc($_->{firstColumnValue}) } = { $self->{devices}->{ $device->{name} }->{ $health_mapping->{$_->{firstColumnValue}} } = {
display => lc($_->{firstColumnValue}), display => lc($_->{firstColumnValue}),
up => $_->{columnValues}->[0], up => $_->{columnValues}->[0],
down => $_->{columnValues}->[1], down => $_->{columnValues}->[1],
@ -392,7 +399,6 @@ sub manage_selection {
total => $_->{columnValues}->[0] + $_->{columnValues}->[1] + $_->{columnValues}->[2] total => $_->{columnValues}->[0] + $_->{columnValues}->[1] + $_->{columnValues}->[2]
}; };
} }
$self->{global}->{total}++; $self->{global}->{total}++;
} }
@ -445,7 +451,14 @@ Thresholds.
Can be: 'total','memory-usage', 'memory-usage-free', 'memory-usage-prct', Can be: 'total','memory-usage', 'memory-usage-free', 'memory-usage-prct',
'disk-usage', 'disk-usage-free', 'disk-usage-prct', 'disk-usage', 'disk-usage-free', 'disk-usage-prct',
'alarms-critical', 'alarms-major', 'alarms-minor', 'alarms-warning', 'alarms-indeterminate', 'alarms-critical', 'alarms-major', 'alarms-minor', 'alarms-warning', 'alarms-indeterminate',
'health-up', 'health-down', 'health-disabled', 'bgp-health-up' 'bgp-health-down' 'bgp-health-disabled'
'path-health-up' 'path-health-down' 'path-health-disabled'
'service-health-up' 'service-health-down' 'service-health-disabled'
'port-health-up' 'port-health-down' 'port-health-disabled'
'reachability-health-up' 'reachability-health-down' 'reachability-health-disabled'
'interface-health-up' 'interface-health-down' 'interface-health-disabled'
'ike-health-up' 'ike-health-down' 'ike-health-disabled'
'config-health-up' 'config-health-down' 'config-health-disabled'
'packets-dropped-novalidlink', 'packets dropped by sla action'. 'packets-dropped-novalidlink', 'packets dropped by sla action'.
=back =back