diff --git a/hardware/ups/powerware/snmp/mode/inputlines.pm b/hardware/ups/powerware/snmp/mode/inputlines.pm index 8627da270..486fee3c9 100644 --- a/hardware/ups/powerware/snmp/mode/inputlines.pm +++ b/hardware/ups/powerware/snmp/mode/inputlines.pm @@ -20,71 +20,61 @@ package hardware::ups::powerware::snmp::mode::inputlines; -use base qw(centreon::plugins::mode); +use base qw(centreon::plugins::templates::counter); use strict; use warnings; -use centreon::plugins::values; -my $maps_counters = { - voltage => { class => 'centreon::plugins::values', obj => undef, - set => { - key_values => [ - { name => 'voltage', no_value => 0, }, - ], - output_template => 'Voltage: %.2f V', output_error_template => 'Voltage: %s', - perfdatas => [ - { value => 'voltage_absolute', label => 'voltage', template => '%.2f', - unit => 'V', min => 0, label_extra_instance => 1 }, - ], - } - }, - current => { class => 'centreon::plugins::values', obj => undef, - set => { - key_values => [ - { name => 'current', no_value => 0 }, - ], - output_template => 'Current: %.2f A', output_error_template => 'Current: %s', - perfdatas => [ - { value => 'current_absolute', label => 'current', template => '%.2f', - unit => 'A', min => 0, label_extra_instance => 1 }, - ], - } - }, - power => { class => 'centreon::plugins::values', obj => undef, - set => { - key_values => [ - { name => 'power', no_value => 0 }, - ], - output_template => 'Power: %.2f W', output_error_template => 'Power: %s', - perfdatas => [ - { value => 'power_absolute', label => 'power', template => '%.2f', - unit => 'W', min => 0, label_extra_instance => 1 }, - ], - } - }, -}; +sub set_counters { + my ($self, %options) = @_; + + $self->{maps_counters_type} = [ + { name => 'global', type => 0, skipped_code => { -10 => 1 } }, + { name => 'iline', type => 1, cb_prefix_output => 'prefix_iline_output', message_multiple => 'All input lines are ok', skipped_code => { -10 => 1 } }, + ]; -my $maps_counters2 = { - frequence => { class => 'centreon::plugins::values', obj => undef, - set => { - key_values => [ - { name => 'frequence', no_value => 0, }, - ], - output_template => 'Frequence: %.2f Hz', output_error_template => 'Frequence: %s', - perfdatas => [ - { value => 'frequence_absolute', label => 'frequence', template => '%.2f', - unit => 'Hz', min => 0 }, - ], - } - }, -}; + $self->{maps_counters}->{global} = [ + { label => 'frequence', nlabel => 'lines.input.frequence.hertz', set => { + key_values => [ { name => 'xupsInputFrequency', no_value => 0 } ], + output_template => 'Frequence : %.2f Hz', + perfdatas => [ + { value => 'xupsInputFrequency_absolute', template => '%.2f', + unit => 'Hz' }, + ], + } + }, + ]; -my $oid_xupsInputVoltageEntry = '.1.3.6.1.4.1.534.1.3.4.1.2'; # in V -my $oid_xupsInputCurrentEntry = '.1.3.6.1.4.1.534.1.3.4.1.3'; # in A -my $oid_xupsInputWattsEntry = '.1.3.6.1.4.1.534.1.3.4.1.4'; # in W -my $oid_xupsInputFrequencyEntry = '.1.3.6.1.4.1.534.1.3.1'; -my $oid_xupsInputFrequency = '.1.3.6.1.4.1.534.1.3.1.0'; # in dHZ + $self->{maps_counters}->{iline} = [ + { label => 'current', nlabel => 'line.input.current.ampere', set => { + key_values => [ { name => 'xupsInputCurrent', no_value => 0 } ], + output_template => 'Current : %.2f A', + perfdatas => [ + { value => 'xupsInputCurrent_absolute', template => '%.2f', + min => 0, unit => 'A', label_extra_instance => 1 }, + ], + } + }, + { label => 'voltage', nlabel => 'line.input.voltage.volt', set => { + key_values => [ { name => 'xupsInputVoltage', no_value => 0 } ], + output_template => 'Voltage : %.2f V', + perfdatas => [ + { value => 'xupsInputVoltage_absolute', template => '%.2f', + unit => 'V', label_extra_instance => 1 }, + ], + } + }, + { label => 'power', nlabel => 'line.input.power.watt', set => { + key_values => [ { name => 'xupsInputWatts', no_value => 0 } ], + output_template => 'Power: %.2f W', + perfdatas => [ + { value => 'xupsInputWatts_absolute', template => '%.2f', + unit => 'W', label_extra_instance => 1 }, + ], + } + }, + ]; +} sub new { my ($class, %options) = @_; @@ -92,157 +82,59 @@ sub new { bless $self, $class; $self->{version} = '1.0'; - $options{options}->add_options(arguments => - { - }); + $options{options}->add_options(arguments => { + }); - $self->{instance_selected} = {}; - - foreach (keys %{$maps_counters}) { - $options{options}->add_options(arguments => { - 'warning-' . $_ . ':s' => { name => 'warning-' . $_ }, - 'critical-' . $_ . ':s' => { name => 'critical-' . $_ }, - }); - my $class = $maps_counters->{$_}->{class}; - $maps_counters->{$_}->{obj} = $class->new(output => $self->{output}, perfdata => $self->{perfdata}, - label => $_); - $maps_counters->{$_}->{obj}->set(%{$maps_counters->{$_}->{set}}); - } - foreach (keys %{$maps_counters2}) { - $options{options}->add_options(arguments => { - 'warning-' . $_ . ':s' => { name => 'warning-' . $_ }, - 'critical-' . $_ . ':s' => { name => 'critical-' . $_ }, - }); - my $class = $maps_counters2->{$_}->{class}; - $maps_counters2->{$_}->{obj} = $class->new(output => $self->{output}, perfdata => $self->{perfdata}, - label => $_); - $maps_counters2->{$_}->{obj}->set(%{$maps_counters2->{$_}->{set}}); - } - return $self; } -sub check_options { +sub prefix_iline_output { my ($self, %options) = @_; - $self->SUPER::init(%options); - - foreach (keys %{$maps_counters}) { - $maps_counters->{$_}->{obj}->init(option_results => $self->{option_results}); - } - foreach (keys %{$maps_counters2}) { - $maps_counters2->{$_}->{obj}->init(option_results => $self->{option_results}); - } + + return "Input Line '" . $options{instance_value}->{display} . "' "; } -sub manage_counters { - my ($self, %options) = @_; - - my ($short_msg, $short_msg_append, $long_msg, $long_msg_append) = ('', '', '', ''); - my @exits; - foreach (sort keys %{$options{maps_counters}}) { - $options{maps_counters}->{$_}->{obj}->set(instance => $options{instance}); - - my ($value_check) = $options{maps_counters}->{$_}->{obj}->execute(values => $self->{instance_selected}->{$options{instance}}); +my $mapping = { + xupsInputVoltage => { oid => '.1.3.6.1.4.1.534.1.3.4.1.2' }, # in V + xupsInputCurrent => { oid => '.1.3.6.1.4.1.534.1.3.4.1.3' }, # in A + xupsInputWatts => { oid => '.1.3.6.1.4.1.534.1.3.4.1.4' }, # in W +}; +my $mapping2 = { + xupsInputFrequency => { oid => '.1.3.6.1.4.1.534.1.3.1' }, # in dHZ +}; - # We don't want to display no value - next if ($value_check == -10); - if ($value_check != 0) { - $long_msg .= $long_msg_append . $options{maps_counters}->{$_}->{obj}->output_error(); - $long_msg_append = ', '; - next; - } - my $exit2 = $options{maps_counters}->{$_}->{obj}->threshold_check(); - push @exits, $exit2; - - my $output = $options{maps_counters}->{$_}->{obj}->output(); - $long_msg .= $long_msg_append . $output; - $long_msg_append = ', '; - - if (!$self->{output}->is_status(litteral => 1, value => $exit2, compare => 'ok')) { - $short_msg .= $short_msg_append . $output; - $short_msg_append = ', '; - } - - $options{maps_counters}->{$_}->{obj}->perfdata(level => 1, extra_instance => $self->{multiple}); - } - - $self->{output}->output_add(long_msg => $options{label} . " " . $long_msg); - my $exit = $self->{output}->get_most_critical(status => [ @exits ]); - if (!$self->{output}->is_status(litteral => 1, value => $exit, compare => 'ok')) { - $self->{output}->output_add(severity => $exit, - short_msg => $options{label} . " " . $short_msg - ); - } - - if ($self->{multiple} == 0) { - $self->{output}->output_add(short_msg => $options{label} . " " . $long_msg); - } -} - -sub run { - my ($self, %options) = @_; - $self->{snmp} = $options{snmp}; - - $self->manage_selection(); - - $self->{multiple} = 1; - if (scalar(keys %{$self->{instance_selected}}) == 1) { - $self->{multiple} = 0; - } - - if ($self->{multiple} == 1) { - $self->{output}->output_add(severity => 'OK', - short_msg => 'Input Lines are ok.'); - } - - foreach my $id (sort keys %{$self->{instance_selected}}) { - $self->manage_counters(instance => $id, maps_counters => $maps_counters, label => "Input Line '" . $id . "'"); - } - - if (defined($self->{results}->{$oid_xupsInputFrequencyEntry}->{$oid_xupsInputFrequencyEntry . '.0'})) { - $self->{instance_selected}->{frequence} = { frequence => $self->{results}->{$oid_xupsInputFrequencyEntry}->{$oid_xupsInputFrequencyEntry . '.0'} * 0.1 }; - $self->manage_counters(instance => 'frequence', maps_counters => $maps_counters2, label => "Input Lines"); - } - - $self->{output}->display(); - $self->{output}->exit(); -} - -sub add_result { - my ($self, %options) = @_; - - $self->{instance_selected}->{$options{instance}} = {} if (!defined($self->{instance_selected}->{$options{instance}})); - $self->{instance_selected}->{$options{instance}}->{$options{name}} = $self->{results}->{$options{oid}}->{$options{oid} . '.' . $options{instance}}; -} +my $oid_xupsInputEntry = '.1.3.6.1.4.1.534.1.3.4.1'; sub manage_selection { my ($self, %options) = @_; - $self->{results} = $self->{snmp}->get_multiple_table(oids => [ - { oid => $oid_xupsInputVoltageEntry }, - { oid => $oid_xupsInputCurrentEntry }, - { oid => $oid_xupsInputWattsEntry }, - { oid => $oid_xupsInputFrequencyEntry }, - ], - , nothing_quit => 1); - - foreach my $oid (keys %{$self->{results}->{$oid_xupsInputVoltageEntry}}) { - $oid =~ /^$oid_xupsInputVoltageEntry\.(\d)$/; - $self->add_result(instance => $1, name => 'voltage', oid => $oid_xupsInputVoltageEntry); - } - foreach my $oid (keys %{$self->{results}->{$oid_xupsInputCurrentEntry}}) { - $oid =~ /^$oid_xupsInputCurrentEntry\.(\d)$/; - $self->add_result(instance => $1, name => 'current', oid => $oid_xupsInputCurrentEntry); - } - foreach my $oid (keys %{$self->{results}->{$oid_xupsInputWattsEntry}}) { - $oid =~ /^$oid_xupsInputWattsEntry\.(\d)$/; - $self->add_result(instance => $1, name => 'power', oid => $oid_xupsInputWattsEntry); + my $snmp_result = $options{snmp}->get_multiple_table( + oids => [ + { oid => $mapping2->{xupsInputFrequency}->{oid} }, + { oid => $oid_xupsInputEntry }, + ], + return_type => 1, nothing_quit => 1 + ); + + $self->{iline} = {}; + foreach my $oid (keys %{$snmp_result}) { + next if ($oid !~ /^$oid_xupsInputEntry\.\d+\.(.*)$/); + my $instance = $1; + next if (defined($self->{iline}->{$instance})); + + my $result = $options{snmp}->map_instance(mapping => $mapping, results => $snmp_result, instance => $instance); + $self->{iline}->{$instance} = { display => $instance, %$result }; } - if (scalar(keys %{$self->{instance_selected}}) <= 0) { + if (scalar(keys %{$self->{iline}}) <= 0) { $self->{output}->add_option_msg(short_msg => "No input lines found."); $self->{output}->option_exit(); - } + } + + my $result = $options{snmp}->map_instance(mapping => $mapping2, results => $snmp_result, instance => '0'); + + $result->{xupsInputFrequency} = defined($result->{xupsInputFrequency}) ? ($result->{xupsInputFrequency} * 0.1) : 0; + $self->{global} = { %$result }; } 1; diff --git a/hardware/ups/powerware/snmp/mode/outputlines.pm b/hardware/ups/powerware/snmp/mode/outputlines.pm index 2b85cc438..ba586b19e 100644 --- a/hardware/ups/powerware/snmp/mode/outputlines.pm +++ b/hardware/ups/powerware/snmp/mode/outputlines.pm @@ -109,8 +109,8 @@ my $mapping = { xupsOutputWatts => { oid => '.1.3.6.1.4.1.534.1.4.4.1.4' }, # in W }; my $mapping2 = { - xupsOutputLoad => { oid => '.1.3.6.1.4.1.534.1.4.1', default => -1 }, # in % - xupsOutputFrequency => { oid => '.1.3.6.1.4.1.534.1.4.2', default => 0 }, # in dHZ + xupsOutputLoad => { oid => '.1.3.6.1.4.1.534.1.4.1' }, # in % + xupsOutputFrequency => { oid => '.1.3.6.1.4.1.534.1.4.2' }, # in dHZ }; my $oid_xupsOutput = '.1.3.6.1.4.1.534.1.4'; @@ -126,7 +126,7 @@ sub manage_selection { ); foreach my $oid (keys %{$snmp_result}) { - $oid =~ /^$oid_xupsOutputEntry\.\d+\.(.*)$/; + next if ($oid !~ /^$oid_xupsOutputEntry\.\d+\.(.*)$/); my $instance = $1; next if (defined($self->{oline}->{$instance}));