From bb4b50f2ed2c50df771a7cac34b2f2f511c95750 Mon Sep 17 00:00:00 2001
From: Lotfi zaouche <lotfi.zaouche@gmail.com>
Date: Wed, 24 Jun 2020 16:55:20 +0000
Subject: [PATCH] change balance fluctuation to balance changes

---
 .../parity/ethpoller/mode/tracking.pm         | 47 ++++++++++++++-----
 1 file changed, 36 insertions(+), 11 deletions(-)

diff --git a/centreon-plugins/blockchain/parity/ethpoller/mode/tracking.pm b/centreon-plugins/blockchain/parity/ethpoller/mode/tracking.pm
index 72cdb5ff4..0f47bef3b 100644
--- a/centreon-plugins/blockchain/parity/ethpoller/mode/tracking.pm
+++ b/centreon-plugins/blockchain/parity/ethpoller/mode/tracking.pm
@@ -74,18 +74,27 @@ sub set_counters {
     ];
 
     $self->{maps_counters}->{balance} = [
-       { label => 'balance-fluctuation-prct', nlabel => 'parity.tracking.balances.fluctuation', display_ok => 0, set => {
-                key_values => [],
-                manual_keys => 1,
-                closure_custom_calc => $self->can('custom_balance_prct_calc'),
-                closure_custom_output => $self->can('custom_balance_prct_output'),
-                threshold_use => 'balance_fluctuation_prct',
+    #    { label => 'balance-fluctuation-prct', nlabel => 'parity.tracking.balances.fluctuation', display_ok => 0, set => {
+    #             key_values => [],
+    #             manual_keys => 1,
+    #             closure_custom_calc => $self->can('custom_balance_prct_calc'),
+    #             closure_custom_output => $self->can('custom_balance_prct_output'),
+    #             threshold_use => 'balance_fluctuation_prct',
+    #             perfdatas => [
+    #                { value => 'balance_fluctuation_prct', template => '%.2f', unit => '%',
+    #                  min => 0, label_extra_instance => 1, instance_use => 'display'  }
+    #             ],
+    #         }
+    #     }
+        { label => 'balance-changes', nlabel => 'parity.tracking.balance.changes.perminute', set => {
+                key_values => [ { name => 'balance_count', per_minute => 1 }, { name => 'display' },
+                                { name => 'last_balance' } ],
+                closure_custom_output => $self->can('custom_balance_output'),
                 perfdatas => [
-                   { value => 'balance_fluctuation_prct', template => '%.2f', unit => '%',
-                     min => 0, label_extra_instance => 1, instance_use => 'display'  }
-                ],
+                    { template => '%.2f', label_extra_instance => 1, unit => 'wei', instance_use => 'display' }
+                ]
             }
-        }
+        },
     ];
 }
 
@@ -183,6 +192,21 @@ sub custom_miner_output {
     }
 }
 
+sub custom_balance_output {
+    my ($self, %options) = @_;
+
+    if (0 eq $self->{result_values}->{balance_count}) {
+        return sprintf("No change in balance. Balance still %s wei",
+            $self->{result_values}->{last_balance});
+    } else {
+        return sprintf(
+            "Balance changes: %.2f/min. New balance: %s",
+            $self->{result_values}->{balance_count},
+            $self->{result_values}->{last_balance}
+        );
+    }
+}
+
 sub new {
     my ($class, %options) = @_;
     my $self = $class->SUPER::new(package => __PACKAGE__, %options, statefile => 1, force_new_perfdata => 1);
@@ -254,7 +278,8 @@ sub manage_selection {
 
         $self->{balance}->{lc($balance->{label})} = {
             display => lc($balance->{label}),
-            balance => $balance->{balance}
+            balance_count => $balance->{balance},
+            last_balance => $balance->{balance}
         };
     }