From cf6f254774374479d423f930123ac5df5e263a94 Mon Sep 17 00:00:00 2001 From: qgarnier Date: Fri, 30 Sep 2022 15:21:59 +0200 Subject: [PATCH] (plugin) network::h3c::snmp - mode interfaces add optical metrics (#3947) --- .../common/h3c/snmp/mode/interfaces.pm | 316 ++++++++++++++++++ centreon-plugins/network/h3c/snmp/plugin.pm | 7 +- .../hp/procurve/snmp/mode/interfaces.pm | 28 +- 3 files changed, 336 insertions(+), 15 deletions(-) create mode 100644 centreon-plugins/centreon/common/h3c/snmp/mode/interfaces.pm diff --git a/centreon-plugins/centreon/common/h3c/snmp/mode/interfaces.pm b/centreon-plugins/centreon/common/h3c/snmp/mode/interfaces.pm new file mode 100644 index 000000000..d0f189a50 --- /dev/null +++ b/centreon-plugins/centreon/common/h3c/snmp/mode/interfaces.pm @@ -0,0 +1,316 @@ +# +# Copyright 2022 Centreon (http://www.centreon.com/) +# +# Centreon is a full-fledged industry-strength solution that meets +# the needs in IT infrastructure and application monitoring for +# service performance. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +package centreon::common::h3c::snmp::mode::interfaces; + +use base qw(snmp_standard::mode::interfaces); + +use strict; +use warnings; + +sub set_counters_errors { + my ($self, %options) = @_; + + $self->SUPER::set_counters_errors(%options); + + push @{$self->{maps_counters}->{int}}, + { label => 'input-power', filter => 'add_optical', nlabel => 'interface.input.power.dbm', set => { + key_values => [ { name => 'input_power' }, { name => 'display' } ], + output_template => 'Input Power : %s dBm', + perfdatas => [ + { template => '%s', unit => 'dBm', label_extra_instance => 1, instance_use => 'display' } + ] + } + }, + { label => 'bias-current', filter => 'add_optical', nlabel => 'interface.bias.current.milliampere', set => { + key_values => [ { name => 'bias_current' }, { name => 'display' } ], + output_template => 'Bias Current : %s mA', + perfdatas => [ + { template => '%s', unit => 'mA', label_extra_instance => 1, instance_use => 'display' } + ] + } + }, + { label => 'output-power', filter => 'add_optical', nlabel => 'interface.output.power.dbm', set => { + key_values => [ { name => 'output_power' }, { name => 'display' } ], + output_template => 'Output Power : %s dBm', + perfdatas => [ + { template => '%s', unit => 'dBm', label_extra_instance => 1, instance_use => 'display' } + ] + } + }, + { label => 'voltage', filter => 'add_optical', nlabel => 'interface.voltage.volt', set => { + key_values => [ { name => 'voltage' }, { name => 'display' } ], + output_template => 'Voltage : %s V', + perfdatas => [ + { template => '%s', unit => 'V', label_extra_instance => 1, instance_use => 'display' } + ] + } + }, + { label => 'module-temperature', filter => 'add_optical', nlabel => 'interface.module.temperature.celsius', set => { + key_values => [ { name => 'module_temperature' }, { name => 'display' } ], + output_template => 'Module Temperature : %.2f C', + perfdatas => [ + { template => '%.2f', unit => 'C', label_extra_instance => 1, instance_use => 'display' } + ] + } + } + ; +} + +sub new { + my ($class, %options) = @_; + my $self = $class->SUPER::new(package => __PACKAGE__, %options); + bless $self, $class; + + $options{options}->add_options(arguments => { + 'add-optical' => { name => 'add_optical' } + }); + + return $self; +} + +sub skip_interface { + my ($self, %options) = @_; + + return ($self->{checking} =~ /cast|errors|traffic|status|volume|optical/ ? 0 : 1); +} + +sub check_options { + my ($self, %options) = @_; + $self->SUPER::check_options(%options); + + $self->{checking} = ''; + foreach (('add_global', 'add_status', 'add_errors', 'add_traffic', 'add_cast', 'add_speed', 'add_volume', 'add_optical')) { + if (defined($self->{option_results}->{$_})) { + $self->{checking} .= $_; + } + } +} + +sub reload_cache_custom { + my ($self, %options) = @_; + + $options{datas}->{optical_ports} = {}; + my $oid_hh3cTransceiverVendorName = '.1.3.6.1.4.1.25506.2.70.1.1.1.4'; + my $snmp_result = $self->{snmp}->get_table(oid => $oid_hh3cTransceiverVendorName); + + foreach (keys %$snmp_result) { + next if (! /^$oid_hh3cTransceiverVendorName\.(\d+)$/); + $options{datas}->{optical_ports}->{$1} = $snmp_result->{$_}; + } +} + +my $mapping_optical = { + output_power => { oid => '.1.3.6.1.4.1.25506.2.70.1.1.1.9' }, # hh3cTransceiverCurTXPower + input_power => { oid => '.1.3.6.1.4.1.25506.2.70.1.1.1.12' }, # hh3cTransceiverCurRXPower + module_temperature => { oid => '.1.3.6.1.4.1.25506.2.70.1.1.1.15' }, # hh3cTransceiverTemperature + voltage => { oid => '.1.3.6.1.4.1.25506.2.70.1.1.1.16' }, # hh3cTransceiverVoltage + bias_current => { oid => '.1.3.6.1.4.1.25506.2.70.1.1.1.17' } # hh3cTransceiverBiasCurrent +}; + +sub custom_load { + my ($self, %options) = @_; + + return if (!defined($self->{option_results}->{add_optical})); + + my $optical_ports = $self->{statefile_cache}->get(name => 'optical_ports'); + $self->{snmp}->load( + oids => [ map($_->{oid}, values(%$mapping_optical)) ], + instances => [keys %$optical_ports] + ); +} + +sub custom_add_result { + my ($self, %options) = @_; + + return if (!defined($self->{option_results}->{add_optical})); + + my $optical_ports = $self->{statefile_cache}->get(name => 'optical_ports'); + return if (!defined($optical_ports->{ $options{instance} })); + + my $result = $self->{snmp}->map_instance(mapping => $mapping_optical, results => $self->{results}, instance => $options{instance}); + + $self->{int}->{ $options{instance} }->{input_power} = undef; + if (defined($result->{input_power}) && $result->{input_power} != 0 && $result->{input_power} != 2147483647) { + $self->{int}->{ $options{instance} }->{input_power} = $result->{input_power} / 100; + } + + $self->{int}->{$options{instance}}->{bias_current} = undef; + if (defined($result->{bias_current}) && $result->{bias_current} != 0 && $result->{bias_current} != 2147483647) { + $self->{int}->{$options{instance}}->{bias_current} = $result->{bias_current} / 100; + } + + $self->{int}->{$options{instance}}->{output_power} = undef; + if (defined($result->{output_power}) && $result->{output_power} != 0 && $result->{output_power} != 2147483647) { + $self->{int}->{$options{instance}}->{output_power} = $result->{output_power} / 100; + } + + $self->{int}->{$options{instance}}->{module_temperature} = undef; + if (defined($result->{module_temperature}) && $result->{module_temperature} != 0 && $result->{module_temperature} != 2147483647) { + $self->{int}->{$options{instance}}->{module_temperature} = $result->{module_temperature}; + } + + $self->{int}->{$options{instance}}->{voltage} = undef; + if (defined($result->{voltage}) && $result->{voltage} != 0 && $result->{voltage} != 2147483647) { + $self->{int}->{$options{instance}}->{voltage} = $result->{voltage} / 100; + } +} + +1; + +__END__ + +=head1 MODE + +Check interfaces. + +=over 8 + +=item B<--add-global> + +Check global port statistics (By default if no --add-* option is set). + +=item B<--add-status> + +Check interface status. + +=item B<--add-duplex-status> + +Check duplex status (with --warning-status and --critical-status). + +=item B<--add-traffic> + +Check interface traffic. + +=item B<--add-errors> + +Check interface errors. + +=item B<--add-cast> + +Check interface cast. + +=item B<--add-speed> + +Check interface speed. + +=item B<--add-volume> + +Check interface data volume between two checks (not supposed to be graphed, useful for BI reporting). + +=item B<--add-optical> + +Check interface optical metrics. + +=item B<--check-metrics> + +If the expression is true, metrics are checked (Default: '%{opstatus} eq "up"'). + +=item B<--warning-status> + +Set warning threshold for status. +Can used special variables like: %{admstatus}, %{opstatus}, %{duplexstatus}, %{display} + +=item B<--critical-status> + +Set critical threshold for status (Default: '%{admstatus} eq "up" and %{opstatus} ne "up"'). +Can used special variables like: %{admstatus}, %{opstatus}, %{duplexstatus}, %{display} + +=item B<--warning-*> B<--critical-*> + +Thresholds. +Can be: 'total-port', 'total-admin-up', 'total-admin-down', 'total-oper-up', 'total-oper-down', +'in-traffic', 'out-traffic', 'in-error', 'in-discard', 'out-error', 'out-discard', +'in-ucast', 'in-bcast', 'in-mcast', 'out-ucast', 'out-bcast', 'out-mcast', +'speed' (b/s). + +And also: 'input-power' (dBm), 'bias-current' (mA), 'output-power' (dBm), 'voltage' (mV), 'module-temperature' (C). + +=item B<--units-traffic> + +Units of thresholds for the traffic (Default: 'percent_delta') ('percent_delta', 'bps', 'counter'). + +=item B<--units-errors> + +Units of thresholds for errors/discards (Default: 'percent_delta') ('percent_delta', 'percent', 'delta', 'counter'). + +=item B<--units-cast> + +Units of thresholds for communication types (Default: 'percent_delta') ('percent_delta', 'percent', 'delta', 'counter'). + +=item B<--nagvis-perfdata> + +Display traffic perfdata to be compatible with nagvis widget. + +=item B<--interface> + +Set the interface (number expected) ex: 1,2,... (empty means 'check all interface'). + +=item B<--name> + +Allows to use interface name with option --interface instead of interface oid index (Can be a regexp) + +=item B<--speed> + +Set interface speed for incoming/outgoing traffic (in Mb). + +=item B<--speed-in> + +Set interface speed for incoming traffic (in Mb). + +=item B<--speed-out> + +Set interface speed for outgoing traffic (in Mb). + +=item B<--force-counters32> + +Force to use 32 bits counters (even in snmp v2c and v3). Should be used when 64 bits counters are buggy. + +=item B<--reload-cache-time> + +Time in minutes before reloading cache file (default: 180). + +=item B<--oid-filter> + +Choose OID used to filter interface (default: ifName) (values: ifDesc, ifAlias, ifName, IpAddr). + +=item B<--oid-display> + +Choose OID used to display interface (default: ifName) (values: ifDesc, ifAlias, ifName, IpAddr). + +=item B<--oid-extra-display> + +Add an OID to display. + +=item B<--display-transform-src> + +Regexp src to transform display value. + +=item B<--display-transform-dst> + +Regexp dst to transform display value. + +=item B<--show-cache> + +Display cache interface datas. + +=back + +=cut diff --git a/centreon-plugins/network/h3c/snmp/plugin.pm b/centreon-plugins/network/h3c/snmp/plugin.pm index a4aa85481..6f7fdc429 100644 --- a/centreon-plugins/network/h3c/snmp/plugin.pm +++ b/centreon-plugins/network/h3c/snmp/plugin.pm @@ -29,14 +29,13 @@ sub new { my $self = $class->SUPER::new(package => __PACKAGE__, %options); bless $self, $class; - $self->{version} = '1.0'; - %{$self->{modes}} = ( + $self->{modes} = { 'cpu' => 'centreon::common::h3c::snmp::mode::cpu', 'hardware' => 'centreon::common::h3c::snmp::mode::hardware', - 'interfaces' => 'snmp_standard::mode::interfaces', + 'interfaces' => 'centreon::common::h3c::snmp::mode::interfaces', 'list-interfaces' => 'snmp_standard::mode::listinterfaces', 'memory' => 'centreon::common::h3c::snmp::mode::memory', - ); + }; return $self; } diff --git a/centreon-plugins/network/hp/procurve/snmp/mode/interfaces.pm b/centreon-plugins/network/hp/procurve/snmp/mode/interfaces.pm index 3d6c9a7c2..4f24ba007 100644 --- a/centreon-plugins/network/hp/procurve/snmp/mode/interfaces.pm +++ b/centreon-plugins/network/hp/procurve/snmp/mode/interfaces.pm @@ -84,6 +84,14 @@ sub set_counters_errors { ] } }, + { label => 'voltage', filter => 'add_optical', nlabel => 'interface.voltage.volt', set => { + key_values => [ { name => 'voltage' }, { name => 'display' } ], + output_template => 'Voltage : %s V', + perfdatas => [ + { template => '%s', unit => 'V', label_extra_instance => 1, instance_use => 'display' } + ] + } + }, { label => 'module-temperature', filter => 'add_optical', nlabel => 'interface.module.temperature.celsius', set => { key_values => [ { name => 'module_temperature' }, { name => 'display' } ], output_template => 'Module Temperature : %.2f C', @@ -138,7 +146,7 @@ sub reload_cache_custom { } $options{datas}->{optical_ports} = {}; - my $oid_hpicfXcvrPortDesc = '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.2'; # + my $oid_hpicfXcvrPortDesc = '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.2'; $snmp_result = $self->{snmp}->get_table(oid => $oid_hpicfXcvrPortDesc); foreach (keys %$snmp_result) { next if (! /^$oid_hpicfXcvrPortDesc\.(\d+)$/); @@ -148,17 +156,10 @@ sub reload_cache_custom { my $mapping_optical = { module_temperature => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.11' }, # hpicfXcvrTemp (/1000) + voltage => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.12' }, # hpicfXcvrVoltage bias_current => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.13' }, # hpicfXcvrBias (microamp / 1000) output_power => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.14' }, # hpicfXcvrTxPower (/1000) - input_power => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.15' }, # hpicfXcvrRxPower (/1000) - tx_high_critical => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.30' }, # hpicfXcvrPwrOutHiAlarm - tx_low_critical => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.31' }, # hpicfXcvrPwrOutLoAlarm - tx_high_warning => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.32' }, # hpicfXcvrPwrOutHiWarn - tx_low_warning => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.33' }, # hpicfXcvrPwrOutLoWarn - rx_high_critical => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.34' }, # hpicfXcvrRcvPwrHiAlarm - rx_low_critical => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.35' }, # hpicfXcvrRcvPwrLoAlarm - rx_high_warning => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.36' }, # hpicfXcvrRcvPwrHiWarn - rx_low_warning => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.37' }, # hpicfXcvrRcvPwrLoWarn + input_power => { oid => '.1.3.6.1.4.1.11.2.14.11.5.1.82.1.1.1.1.15' } # hpicfXcvrRxPower (/1000) }; my $oid_poe_status = '.1.3.6.1.4.1.11.2.14.11.1.9.1.1.1.9'; # hpicfPoePethPsePortOperStatus @@ -238,6 +239,11 @@ sub custom_add_result { if (defined($result->{module_temperature}) && $result->{module_temperature} != 0) { $self->{int}->{$options{instance}}->{module_temperature} = $result->{module_temperature} / 1000; } + + $self->{int}->{$options{instance}}->{voltage} = undef; + if (defined($result->{voltage}) && $result->{voltage} != 0) { + $self->{int}->{$options{instance}}->{voltage} = $result->{voltage} / 10000; + } } 1; @@ -322,7 +328,7 @@ Can be: 'total-port', 'total-admin-up', 'total-admin-down', 'total-oper-up', 'to 'in-ucast', 'in-bcast', 'in-mcast', 'out-ucast', 'out-bcast', 'out-mcast', 'speed' (b/s). -And also: 'input-power' (dBm), 'bias-current' (mA), 'output-power' (dBm), 'module-temperature' (C), 'poe-power-actual'. +And also: 'input-power' (dBm), 'bias-current' (mA), 'output-power' (dBm), 'voltage' (mV), 'module-temperature' (C), 'poe-power-actual'. =item B<--units-traffic>