diff --git a/storage/panzura/snmp/mode/ratios.pm b/storage/panzura/snmp/mode/ratios.pm index dde8ca613..5886cd51e 100644 --- a/storage/panzura/snmp/mode/ratios.pm +++ b/storage/panzura/snmp/mode/ratios.pm @@ -20,45 +20,45 @@ package storage::panzura::snmp::mode::ratios; -use base qw(centreon::plugins::mode); +use base qw(centreon::plugins::templates::counter); use strict; use warnings; -use centreon::plugins::values; -my $maps_counters = { - dedup => { class => 'centreon::plugins::values', obj => undef, - set => { - key_values => [ { name => 'dedup' }, ], - output_template => 'Deduplication ratio : %.2f', - perfdatas => [ - { value => 'dedup_absolute', template => '%.2f', min => 0 }, - ], - } - }, - comp => { class => 'centreon::plugins::values', obj => undef, - set => { - key_values => [ { name => 'comp' }, ], - output_template => 'Compression ratio : %.2f', - perfdatas => [ - { value => 'comp_absolute', template => '%.2f', min => 0 }, - ], - } - }, - save => { class => 'centreon::plugins::values', obj => undef, - set => { - key_values => [ { name => 'save' }, ], - output_template => 'Save ratio : %.2f', - perfdatas => [ - { value => 'save_absolute', template => '%.2f', min => 0 }, - ], - } - }, -}; - -my $oid_dedupRatio = '.1.3.6.1.4.1.32853.1.3.1.5.1.0'; -my $oid_compRatio = '.1.3.6.1.4.1.32853.1.3.1.6.1.0'; -my $oid_saveRatio = '.1.3.6.1.4.1.32853.1.3.1.7.1.0'; +sub set_counters { + my ($self, %options) = @_; + + $self->{maps_counters_type} = [ + { name => 'global', type => 0, skipped_code => { -10 => 1 } } + ]; + + $self->{maps_counters}->{global} = [ + { label => 'dedup', nlabel => 'system.deduplication.ratio.count', set => { + key_values => [ { name => 'dedup' }, ], + output_template => 'Deduplication ratio : %.2f', + perfdatas => [ + { value => 'dedup_absolute', template => '%.2f', min => 0 }, + ], + } + }, + { label => 'comp', nlabel => 'system.compression.ratio.count', set => { + key_values => [ { name => 'comp' }, ], + output_template => 'Compression ratio : %.2f', + perfdatas => [ + { value => 'comp_absolute', template => '%.2f', min => 0 }, + ], + } + }, + { label => 'save', nlabel => 'system.save.ratio.count', set => { + key_values => [ { name => 'save' }, ], + output_template => 'Save ratio : %.2f', + perfdatas => [ + { value => 'save_absolute', template => '%.2f', min => 0 }, + ], + } + }, + ]; +} sub new { my ($class, %options) = @_; @@ -66,92 +66,29 @@ sub new { bless $self, $class; $self->{version} = '1.0'; - $options{options}->add_options(arguments => - { - }); + $options{options}->add_options(arguments => { + }); - foreach (keys %{$maps_counters}) { - $options{options}->add_options(arguments => { - 'warning-' . $_ . ':s' => { name => 'warning-' . $_ }, - 'critical-' . $_ . ':s' => { name => 'critical-' . $_ }, - }); - my $class = $maps_counters->{$_}->{class}; - $maps_counters->{$_}->{obj} = $class->new(statefile => $self->{statefile_value}, - output => $self->{output}, perfdata => $self->{perfdata}, - label => $_); - $maps_counters->{$_}->{obj}->set(%{$maps_counters->{$_}->{set}}); - } return $self; } -sub check_options { - my ($self, %options) = @_; - $self->SUPER::init(%options); - - foreach (keys %{$maps_counters}) { - $maps_counters->{$_}->{obj}->init(option_results => $self->{option_results}); - } -} - -sub run { - my ($self, %options) = @_; - $self->{snmp} = $options{snmp}; - - $self->manage_selection(); - - $self->{output}->output_add(severity => 'OK', - short_msg => 'All ratios are ok'); - - my ($short_msg, $short_msg_append, $long_msg, $long_msg_append) = ('', '', '', ''); - my @exits; - foreach (sort keys %{$maps_counters}) { - $maps_counters->{$_}->{obj}->set(instance => 'global'); - - my ($value_check) = $maps_counters->{$_}->{obj}->execute(values => $self->{global}); - - if ($value_check != 0) { - $long_msg .= $long_msg_append . $maps_counters->{$_}->{obj}->output_error(); - $long_msg_append = ', '; - next; - } - my $exit2 = $maps_counters->{$_}->{obj}->threshold_check(); - push @exits, $exit2; - - my $output = $maps_counters->{$_}->{obj}->output(); - $long_msg .= $long_msg_append . $output; - $long_msg_append = ', '; - - if (!$self->{output}->is_status(litteral => 1, value => $exit2, compare => 'ok')) { - $short_msg .= $short_msg_append . $output; - $short_msg_append = ', '; - } - - $self->{output}->output_add(long_msg => $output); - $maps_counters->{$_}->{obj}->perfdata(); - } - - my $exit = $self->{output}->get_most_critical(status => [ @exits ]); - if (!$self->{output}->is_status(litteral => 1, value => $exit, compare => 'ok')) { - $self->{output}->output_add(severity => $exit, - short_msg => "$short_msg" - ); - } - - $self->{output}->display(); - $self->{output}->exit(); -} - sub manage_selection { my ($self, %options) = @_; + + my $oid_dedupRatio = '.1.3.6.1.4.1.32853.1.3.1.5.1.0'; + my $oid_compRatio = '.1.3.6.1.4.1.32853.1.3.1.6.1.0'; + my $oid_saveRatio = '.1.3.6.1.4.1.32853.1.3.1.7.1.0'; + + my $snmp_result = $options{snmp}->get_leef( + oids => [$oid_dedupRatio, $oid_compRatio, $oid_saveRatio], + nothing_quit => 1 + ); - my $request = [$oid_dedupRatio, $oid_compRatio, $oid_saveRatio]; - - $self->{results} = $self->{snmp}->get_leef(oids => $request, nothing_quit => 1); - - $self->{global} = {}; - $self->{global}->{dedup} = defined($self->{results}->{$oid_dedupRatio}) ? $self->{results}->{$oid_dedupRatio} / 100 : 0; - $self->{global}->{comp} = defined($self->{results}->{$oid_compRatio}) ? $self->{results}->{$oid_compRatio} / 100 : 0; - $self->{global}->{save} = defined($self->{results}->{$oid_saveRatio}) ? $self->{results}->{$oid_saveRatio} / 100 : 0; + $self->{global} = { + dedup => defined($snmp_result->{$oid_dedupRatio}) ? $snmp_result->{$oid_dedupRatio} / 100 : undef, + comp => defined($snmp_result->{$oid_compRatio}) ? $snmp_result->{$oid_compRatio} / 100 : undef, + save => defined($snmp_result->{$oid_saveRatio}) ? $snmp_result->{$oid_saveRatio} / 100 : undef, + }; } 1; @@ -177,4 +114,4 @@ Can be: 'dedup', 'comp', 'save'. =back =cut - \ No newline at end of file +